Re: Review request for a SnapshotManager change

2022-12-09 Thread Ryan Blue
Done. On Fri, Dec 9, 2022 at 1:30 AM Gabor Kaszab wrote: > Hey Committers, > > I have a PR that has been open for a while and I'm wondering if any of the > committers have some spare cycles to take a look at? > This change is related to SnapshotManager that is currently using an > internal Trans

Review request for a SnapshotManager change

2022-12-09 Thread Gabor Kaszab
Hey Committers, I have a PR that has been open for a while and I'm wondering if any of the committers have some spare cycles to take a look at? This change is related to SnapshotManager that is currently using an internal Transaction, however, I'd need to do some of the work from SnapshotManager t

Review Request

2022-07-18 Thread liwei li
hi iceberg dev: Kyle and I have recently done some work on Iceberg Flink New Sink, PR is https://github.com/apache/iceberg/pull/4904 preliminary proposal: https://docs.google.com/document/d/1G4O6JidAoKgbIdy8Ts73OfG_KBEMpsW-LkXIb89I5k8/edit?usp=sharing It refactors our flink writer topology based

Review Request

2022-03-09 Thread OpenInx
Hi iceberg dev I've recently revisited the flink write path to use the newly introduced writers (which is partition specific writers). All the future performance & stability optimization will be made on top of the revisited flink write path. I've just published the PR here: https://github.com/ap

Re: Review request

2022-03-02 Thread Ryan Blue
Looks great. Sorry that I missed this one to review! On Wed, Mar 2, 2022 at 1:31 AM OpenInx wrote: > Thanks Peter for the great work. Just added my comments. > > On Wed, Mar 2, 2022 at 4:20 PM Peter Vary > wrote: > >> Hi Team, >> >> I have a PR (https://github.com/apache/iceberg/pull/4218) wait

Re: Review request

2022-03-02 Thread OpenInx
Thanks Peter for the great work. Just added my comments. On Wed, Mar 2, 2022 at 4:20 PM Peter Vary wrote: > Hi Team, > > I have a PR (https://github.com/apache/iceberg/pull/4218) waiting for > review where with basically a 1 liner change we can improve the performance > of the GenericReader clas

Review request

2022-03-02 Thread Peter Vary
Hi Team, I have a PR (https://github.com/apache/iceberg/pull/4218 ) waiting for review where with basically a 1 liner change we can improve the performance of the GenericReader classes by 10–20%. This onliner is needed in 3 places. The other part of