[GitHub] ignite pull request: Ignite 1187

2016-01-30 Thread DoudTechData
GitHub user DoudTechData opened a pull request: https://github.com/apache/ignite/pull/441 Ignite 1187 fix some issues with sources when using eclipse You can merge this pull request into a Git repository by running: $ git pull https://github.com/DoudTechData/ignite ignite-1187

Re: PR : Please help do the code review for IGNITE-1069

2016-01-30 Thread Ken Cheng
Hi Alexey Kuznetsov, *All the related test cases are passed, please check the detail in jira. I have paste the build link.* Thanks, kcheng On Sat, Jan 30, 2016 at 7:03 PM, Alexey Kuznetsov wrote: > Hi Ken! > I will review you PR shortly. > > > On Sat, Jan 30, 2016 at 4:03 PM, Denis Magda wrot

Re: Adding tracing component to Ignite

2016-01-30 Thread Sergi Vladykin
+1 I think it is a great idea, still it must be carefully designed to avoid additional performance penalty. BTW, for performance measurements there is already a good component: https://github.com/HdrHistogram/HdrHistogram Sergi 2016-01-30 3:01 GMT+03:00 Dmitriy Setrakyan : > How do you disable

Re: PR : Please help do the code review for IGNITE-1069

2016-01-30 Thread Alexey Kuznetsov
Hi Ken! I will review you PR shortly. On Sat, Jan 30, 2016 at 4:03 PM, Denis Magda wrote: > Hi Ken, > > I think that Alex Kuznetsov as a maintainer of visorcmd will be able to > review your contribution. > > Regards, > Denis > > > On 30 янв. 2016 г., at 11:59, Ken Cheng wrote: > > > > @Ilya Su

Re: PR : Please help do the code review for IGNITE-1069

2016-01-30 Thread Denis Magda
Hi Ken, I think that Alex Kuznetsov as a maintainer of visorcmd will be able to review your contribution. Regards, Denis > On 30 янв. 2016 г., at 11:59, Ken Cheng wrote: > > @Ilya Suntsov > , > > You logged this issue, please

Re: PR : Please help do the code review for IGNITE-1069

2016-01-30 Thread Ken Cheng
@Ilya Suntsov , You logged this issue, please help to reivew it. Thanks. Thanks, kcheng On Sat, Jan 30, 2016 at 4:10 PM, Ken Cheng wrote: > > Dear Ignite Developers, > > > I have raised a PR https://github.com/apache/ignite/pul

PR : Please help do the code review for IGNITE-1069

2016-01-30 Thread Ken Cheng
Dear Ignite Developers, I have raised a PR https://github.com/apache/ignite/pull/440 for bug https://issues.apache.org/jira/browse/IGNITE-1069 please help do a code review. Thanks, kcheng