Re: DDL implementation details

2017-01-27 Thread Vladimir Ozerov
Denis, >>> Inventing custom DDL statements is also a dead end. Questionable. Every database has custom SQL, including DDL, are they all "dead-ended"? Each database has unique set of feature and unique architecture. The very goal of custom SQL is to give user control over these differences. Without

IGNITE-3385

2017-01-27 Thread ALEKSEY KUZNETSOV
If you dont mind, i will take IGNITE-3385 ticket -- *Best Regards,* *Kuznetsov Aleksey*

[GitHub] ignite pull request #1471: Ignite 4212 a

2017-01-27 Thread oleg-ostanin
GitHub user oleg-ostanin opened a pull request: https://github.com/apache/ignite/pull/1471 Ignite 4212 a You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-4212-a Alternatively you can review and apply

Re: IGNITE-4212 (Ignite Benchmarking Simplification and Automation)

2017-01-27 Thread Oleg Ostanin
Hi! I've changed the README.txt and DEVNOTES.txt files. Also added a simple config file for quick and easy start. Please take a look at them and tell me what you think. https://github.com/apache/ignite/pull/1471 On Wed, Dec 28, 2016 at 8:59 AM, Ilya Suntsov wrote: > Denis, > > I think we can r

Re: IGNITE-3385

2017-01-27 Thread Alexey Kuznetsov
Hello! My name is also Alexey Kuznetsov :) And I'm one of developer of this utility (IGNITE-3385 Improve schema import utility). In general you could improve schema import utility, but we decided to drop it in favor of Web Console. Web Console also can import schema import and it is already do it

Binary object hash code resolution in Apache Ignite 2.0

2017-01-27 Thread Vladimir Ozerov
Folks, Historically we have fundamental flaw in how we deal with hashCode/equals for BinaryObjects: 1) hashCode() is taken from original deserialized object. 2) But equals() is performed through binary array comparison. We recently introduced BinaryIdentityResolver [1] as a part of DML feature, b

Re: Transactional tasks

2017-01-27 Thread Alexey Goncharuk
Alexei, Can you describe the semantics of the task in greater detail? * What if two jobs on different nodes access and try to put the same key? (this can be resolved by allowing a job only access local primary keys) * How do you define the lock acquisition order and prevent deadlocks? I assume t

Re: IGNITE-3385

2017-01-27 Thread ALEKSEY KUZNETSOV
Hi!) Got it пт, 27 янв. 2017 г. в 13:22, Alexey Kuznetsov : > Hello! My name is also Alexey Kuznetsov :) > > And I'm one of developer of this utility (IGNITE-3385 Improve schema import > utility). > > In general you could improve schema import utility, but we decided to drop > it in favor of Web

IGNITE-4492

2017-01-27 Thread ALEKSEY KUZNETSOV
will take IGNITE-4492 if you don't mind -- *Best Regards,* *Kuznetsov Aleksey*

[jira] [Created] (IGNITE-4623) IGFS test suite should run successfully on Windows agents

2017-01-27 Thread Ivan Veselovsky (JIRA)
Ivan Veselovsky created IGNITE-4623: --- Summary: IGFS test suite should run successfully on Windows agents Key: IGNITE-4623 URL: https://issues.apache.org/jira/browse/IGNITE-4623 Project: Ignite

Re: IGNITE-4492

2017-01-27 Thread Alexey Kuznetsov
Aleksey, FYI: You should assign issue in JIRA to your self. (click "Assign to me" link). On Fri, Jan 27, 2017 at 6:28 PM, ALEKSEY KUZNETSOV wrote: > will take IGNITE-4492 > if > you don't mind > -- > > *Best Regards,* > > *Kuznetsov Aleksey* >

Re: IGNITE-3385

2017-01-27 Thread Alexey Kuznetsov
Added comment to issue and removed "newbie" label. On Fri, Jan 27, 2017 at 6:18 PM, ALEKSEY KUZNETSOV wrote: > Hi!) Got it > > пт, 27 янв. 2017 г. в 13:22, Alexey Kuznetsov : > > > Hello! My name is also Alexey Kuznetsov :) > > > > And I'm one of developer of this utility (IGNITE-3385 Improve sc

Do not use H2 parser for DDL

2017-01-27 Thread Vladimir Ozerov
Folks, H2 has nice and powerful SQL parser, and we pass all incoming SQL commands through it. However it doesn't support custom SQL syntax, which we are likely to need in DDL at some point in future. As DDL statements are relatively easy to parse comparing to SELECTs and they do not involve optim

Re: Do not use H2 parser for DDL

2017-01-27 Thread Alexey Kuznetsov
We should care about statements like this: /* bla-bla */ CREATE TABLE So naive "startsWith(...)" will not work in some scenarios. :) On Fri, Jan 27, 2017 at 7:06 PM, Vladimir Ozerov wrote: > Folks, > > H2 has nice and powerful SQL parser, and we pass all incoming SQL commands > through it. How

[GitHub] ignite pull request #1472: Ignite 4590

2017-01-27 Thread ntikhonov
GitHub user ntikhonov opened a pull request: https://github.com/apache/ignite/pull/1472 Ignite 4590 You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-4590 Alternatively you can review and apply these

Re: IGNITE-4492

2017-01-27 Thread ALEKSEY KUZNETSOV
I know! But i don't have sufficient privileges yet пт, 27 янв. 2017 г. в 14:41, Alexey Kuznetsov : > Aleksey, > > FYI: You should assign issue in JIRA to your self. (click "Assign to me" > link). > > On Fri, Jan 27, 2017 at 6:28 PM, ALEKSEY KUZNETSOV < > alkuznetsov...@gmail.com > > wrote: > > >

[jira] [Created] (IGNITE-4624) ScanQuery shows poor performance.

2017-01-27 Thread Andrew Mashenkov (JIRA)
Andrew Mashenkov created IGNITE-4624: Summary: ScanQuery shows poor performance. Key: IGNITE-4624 URL: https://issues.apache.org/jira/browse/IGNITE-4624 Project: Ignite Issue Type: Improv

Re: Binary object hash code resolution in Apache Ignite 2.0

2017-01-27 Thread Pavel Tupitsyn
Makes sense to me. Ticket for reference: https://issues.apache.org/jira/browse/IGNITE-4558 On Fri, Jan 27, 2017 at 1:37 PM, Vladimir Ozerov wrote: > Folks, > > Historically we have fundamental flaw in how we deal with hashCode/equals > for BinaryObjects: > 1) hashCode() is taken from original d

IGNITE-1948 ClusterTopologyCheckedException can return null for retryReadyFuture()

2017-01-27 Thread Александр Меньшиков
I found a lot of using "ClusterTopologyCheckedException" exception. In most use-case these exceptions were just ignored. It's easier to see if issue-4612 will be applied (I'm waiting for code review by my team leader) where I renamed all unused exceptions in the "ignored". It means that in some ca

ScanQuery shows poor performance.

2017-01-27 Thread Andrey Mashenkov
Hi Igniters, I've found that ScanQuery iterates over partitions in non-optimal way. It uses KeyIterator which gets value for each key via call to cache map. I made a try to replace KeyIterator with EntryIterator to avoid cache map lookups and got significant speed up, about 30%. Is there some r

Re: Do not use H2 parser for DDL

2017-01-27 Thread Sergi Vladykin
H2 to some extent supports syntax (and quirks) from other databases. For example you can start it with MODE=MySQL and it will allow some MySQL specific syntax to be handled. Having said that, IMO the most correct way to handle non-standard syntax is to introduce H2 MODE=ApacheIgnite and put the ne

Re: IGNITE-4492

2017-01-27 Thread Alexey Kuznetsov
What is your JIRA ID? I will add you to Apache Ignite contributors. On Fri, Jan 27, 2017 at 7:34 PM, ALEKSEY KUZNETSOV wrote: > I know! But i don't have sufficient privileges yet > > пт, 27 янв. 2017 г. в 14:41, Alexey Kuznetsov : > > > Aleksey, > > > > FYI: You should assign issue in JIRA to yo

Re: IGNITE-4492

2017-01-27 Thread ALEKSEY KUZNETSOV
https://issues.apache.org/jira/secure/ViewProfile.jspa?name=Alexey+Kuznetsov пт, 27 янв. 2017 г. в 16:48, Alexey Kuznetsov : > What is your JIRA ID? > I will add you to Apache Ignite contributors. > > On Fri, Jan 27, 2017 at 7:34 PM, ALEKSEY KUZNETSOV < > alkuznetsov...@gmail.com > > wrote: > > >

[jira] [Created] (IGNITE-4625) .NET: MixedClusterTest leaves Java-only node running

2017-01-27 Thread Pavel Tupitsyn (JIRA)
Pavel Tupitsyn created IGNITE-4625: -- Summary: .NET: MixedClusterTest leaves Java-only node running Key: IGNITE-4625 URL: https://issues.apache.org/jira/browse/IGNITE-4625 Project: Ignite Iss

Re: IGNITE-4492

2017-01-27 Thread Alexey Kuznetsov
Added to contributors. On Fri, Jan 27, 2017 at 9:04 PM, ALEKSEY KUZNETSOV wrote: > https://issues.apache.org/jira/secure/ViewProfile.jspa? > name=Alexey+Kuznetsov > > пт, 27 янв. 2017 г. в 16:48, Alexey Kuznetsov : > > > What is your JIRA ID? > > I will add you to Apache Ignite contributors. > >

[GitHub] ignite pull request #1473: IGNITE-3196

2017-01-27 Thread daradurvs
GitHub user daradurvs opened a pull request: https://github.com/apache/ignite/pull/1473 IGNITE-3196 We shouldn't check sign at serialization, because the used approach: BigInteger intVal = val.unscaledValue(); byte[] vals = intVal.toByteArray(); #toByteArray() - already i

Re: ScanQuery shows poor performance.

2017-01-27 Thread Alexey Goncharuk
Andrey, >From the top of my head I would guess that this is done so because keyIterator handles on-heap, off-heap and swap, while entrySet() return only on-heap entries. Please check that your change does not break iteration with off-heap and swap enabled (if it does, it just means that we need to

Re: ScanQuery shows poor performance.

2017-01-27 Thread Dmitriy Setrakyan
On Fri, Jan 27, 2017 at 7:03 AM, Alexey Goncharuk < alexey.goncha...@gmail.com> wrote: > Andrey, > > From the top of my head I would guess that this is done so because > keyIterator handles on-heap, off-heap and swap, while entrySet() return > only on-heap entries. Please check that your change do

Re: Do not use H2 parser for DDL

2017-01-27 Thread Dmitriy Setrakyan
On Fri, Jan 27, 2017 at 5:45 AM, Sergi Vladykin wrote: > H2 to some extent supports syntax (and quirks) from other databases. For > example you can start it with MODE=MySQL and it will allow some MySQL > specific syntax to be handled. > > Having said that, IMO the most correct way to handle non-s

[GitHub] ignite pull request #1474: IGNITE-1495 Uppercase index fields in metadata

2017-01-27 Thread skalashnikov
GitHub user skalashnikov opened a pull request: https://github.com/apache/ignite/pull/1474 IGNITE-1495 Uppercase index fields in metadata You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-1495 Alterna

[GitHub] ignite pull request #1475: IGNITE-3793: Need to fix dependencies and it's li...

2017-01-27 Thread asfedotov
GitHub user asfedotov opened a pull request: https://github.com/apache/ignite/pull/1475 IGNITE-3793: Need to fix dependencies and it's licenses 1) Fix H2 license listed at LICENSE_FABRIC. 2) Fix invalid H2 version in examples. 3) Fix incorrect JCache the license generation af

Re: Binary object hash code resolution in Apache Ignite 2.0

2017-01-27 Thread Dmitriy Setrakyan
Why shouldn't we use Object.hashCode() by default, even if the equals check is done by comparing byte arrays? Wouldn't it be faster? On Fri, Jan 27, 2017 at 4:38 AM, Pavel Tupitsyn wrote: > Makes sense to me. > > Ticket for reference: https://issues.apache.org/jira/browse/IGNITE-4558 > > On Fri,

[GitHub] ignite pull request #1444: IGNITE-4106: SQL: parallelize sql queries over ca...

2017-01-27 Thread AMashenkov
Github user AMashenkov closed the pull request at: https://github.com/apache/ignite/pull/1444 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: newbie ticket issue

2017-01-27 Thread Denis Magda
+ dev list > On Jan 27, 2017, at 9:52 AM, Denis Magda wrote: > > Hello Aleksey, > > Welcome to the Ignite community! > > Share your JIRA ID with us so that we can add you to the contributors list. > After that you will be able to assign tickets on yourself. > > As for this ticket, it’s no lo

Re: Binary object hash code resolution in Apache Ignite 2.0

2017-01-27 Thread Vladimir Ozerov
Because it breaks equals/hashCode contract and cannot work with DML (we use ugly hack as a workaround now). 27 янв. 2017 г. 20:33 пользователь "Dmitriy Setrakyan" < dsetrak...@apache.org> написал: > Why shouldn't we use Object.hashCode() by default, even if the equals check > is done by comparing

Re: IGNITE-3385

2017-01-27 Thread Denis Magda
Alex K., Please keep an eye on this task (schema utility discontinue): https://issues.apache.org/jira/browse/IGNITE-4349 Actually, I think you can already remove it completely and commit the change to 2.0 branch, right? — Denis > On Jan 27,

[GitHub] ignite pull request #1476: IGNITE-4106: SQL: parallelize sql queries over ca...

2017-01-27 Thread AMashenkov
GitHub user AMashenkov opened a pull request: https://github.com/apache/ignite/pull/1476 IGNITE-4106: SQL: parallelize sql queries over cache local partitions You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite

Re: Binary object hash code resolution in Apache Ignite 2.0

2017-01-27 Thread Denis Magda
Sounds reasonable to me. Actually, I thought that BinaryArrayIdentityResolver was already enabled by default since 1.8. — Denis > On Jan 27, 2017, at 2:37 AM, Vladimir Ozerov wrote: > > Folks, > > Historically we have fundamental flaw in how we deal with hashCode/equals > for BinaryObjects: >

Re: Binary object hash code resolution in Apache Ignite 2.0

2017-01-27 Thread Vladimir Ozerov
No, we didn't do that because it could break existing user code. Not a problem for AI 2.0. On Fri, Jan 27, 2017 at 9:50 PM, Denis Magda wrote: > Sounds reasonable to me. Actually, I thought that > BinaryArrayIdentityResolver was already enabled by default since 1.8. > > — > Denis > > > On Jan 27

Re: Do not use H2 parser for DDL

2017-01-27 Thread Vladimir Ozerov
My point was that we can avoid dependency on 3rd party developers for this relatively simple logic. On Fri, Jan 27, 2017 at 8:07 PM, Dmitriy Setrakyan wrote: > On Fri, Jan 27, 2017 at 5:45 AM, Sergi Vladykin > wrote: > > > H2 to some extent supports syntax (and quirks) from other databases. For

Re: Binary object hash code resolution in Apache Ignite 2.0

2017-01-27 Thread Dmitriy Setrakyan
On Fri, Jan 27, 2017 at 9:56 AM, Vladimir Ozerov wrote: > Because it breaks equals/hashCode contract and cannot work with DML (we use > ugly hack as a workaround now). > Got it. Perhaps we can calculate hashCode only over the first 10 bytes or so, for performance reasons. > > 27 янв. 2017 г. 2

Re: Binary object hash code resolution in Apache Ignite 2.0

2017-01-27 Thread Valentin Kulichenko
I think hash code can be calculated during serialization, while we write bytes. Obviously, there is no reason to calculate it each time hashCode() is called on the same binary object. -Val On Fri, Jan 27, 2017 at 10:59 AM, Dmitriy Setrakyan wrote: > On Fri, Jan 27, 2017 at 9:56 AM, Vladimir Oze

Re: Do not use H2 parser for DDL

2017-01-27 Thread Alexander Paschenko
Guys, And what would you say if I suggested that we implement custom grammar support with ANTLR? It allows you to describe pretty much any grammar in a declarative way, generates lexer and parser and then allows to easily process parsed commands by implementing few (generated) interfaces. Yesterda