Re: How to improve SQL testing

2017-01-31 Thread Evgeniy Stanilovskiy
Sergey, did you take a look into https://en.wikipedia.org/wiki/YCSB ? https://github.com/joshwilliams/YCSB there is simple jdbc connector looks like it would be ok for us ? Hi, That’s true that the utility/testing framework needs to be as flexible as possible. If the community can’t reuse an

Re: How to improve SQL testing

2017-01-31 Thread Oleg Ostanin
Hi, If there are no objections, I'd like implement this feature. Oleg On Tue, Jan 31, 2017 at 12:07 AM, Denis Magda wrote: > Hi, > > That’s true that the utility/testing framework needs to be as flexible as > possible. If the community can’t reuse an existing one let’s make it up. > > As for V

Re: How to improve SQL testing

2017-01-31 Thread Vladimir Ozerov
Evgeniy, AFAIK YCSB is used for NoSQL database benchmark, right? This is not exactly our case, because we are going to test pure SQL. On Tue, Jan 31, 2017 at 10:55 AM, Evgeniy Stanilovskiy < stanilov...@gmail.com> wrote: > Sergey, did you take a look into https://en.wikipedia.org/wiki/YCSB ? > h

Re: IGNITE-3196 - ready for review

2017-01-31 Thread Igor Sapego
Vyacheslav, I had a look at your PR and left some comments in Jira. Best Regards, Igor On Mon, Jan 30, 2017 at 12:52 PM, Vyacheslav Daradur wrote: > Hello. I fixed it. Please, review. > > https://issues.apache.org/jira/browse/IGNITE-3196 - Marshaling works wrong > for the BigDecimals that have

Re: Unused variables in code

2017-01-31 Thread Александр Меньшиков
And result of testing: http://ci.ignite.apache.org/project.html?projectId=IgniteTests&tab=projectOverview&branch_IgniteTests=pull/1466/head 2017-01-30 18:39 GMT+03:00 Александр Меньшиков : > Done. > > My PR: > https://github.com/apache/ignite/pull/1466/files >

Re: IGNITE-3196 - ready for review

2017-01-31 Thread Vyacheslav Daradur
Pavel, I see that you are the main contributor of Ignite.NET. We should repair BinaryUtils#ReadDecimal and BinaryUtils#WriteDecimal. *ReadDecimal: byte[] mag = ReadByteArray(stream); // including at least one sign bit, which is (ceil((this.bitLength() + 1)/8)) bool neg = (mag[0] < 0); if (scale <

Re: IGNITE-3196 - ready for review

2017-01-31 Thread Pavel Tupitsyn
Vyacheslav, I'm not sure I understand the code you attached. If you know how to fix the .NET part, can you just do it in your PR and run "Platform .NET" on TeamCity to verify? http://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests_IgnitePlatformNet Thanks, Pavel On Tue, Jan 31, 2017

Re: IGNITE-4212 (Ignite Benchmarking Simplification and Automation)

2017-01-31 Thread Oleg Ostanin
Hi Denis, Yes, we have included Ignite Yardstick source files with its pom.xml in Ignite binary release. "Building from standalone sources" is the building instruction for these source files. "Building from Ignite Sources" is the instruction for building Ignite Yardstick from `modules/yardstick` i

[GitHub] ignite pull request #1445: Ignite 4557

2017-01-31 Thread zstan
Github user zstan closed the pull request at: https://github.com/apache/ignite/pull/1445 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] ignite pull request #1465: IGNITE-4552 support eviction for dhtLocalPartitio...

2017-01-31 Thread zstan
Github user zstan closed the pull request at: https://github.com/apache/ignite/pull/1465 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

Re: Review for IGNITE-4436 API to collect list of running SQL queries

2017-01-31 Thread Alexey Kuznetsov
Any feedback, please? On Mon, Jan 30, 2017 at 9:38 PM, Alexey Kuznetsov wrote: > Hi All! > > I prepared first version https://issues.apache.org/jira/browse/IGNITE-4436 > (SQL: create API to collect list of running SQL queries and cancel them). > > Please review it and give a feedback: http://rev

[GitHub] ignite pull request #1481: IGNITE-4552 support eviction for dhtLocalPartitio...

2017-01-31 Thread zstan
GitHub user zstan opened a pull request: https://github.com/apache/ignite/pull/1481 IGNITE-4552 support eviction for dhtLocalPartition remove queue You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-455

[GitHub] ignite pull request #1482: IGNITE-4630 return valid date for org.apache.igni...

2017-01-31 Thread ezhuravl
GitHub user ezhuravl opened a pull request: https://github.com/apache/ignite/pull/1482 IGNITE-4630 return valid date for org.apache.ignite.lang.IgniteProductVersion.releaseDate You can merge this pull request into a Git repository by running: $ git pull https://github.com/ezh

[GitHub] ignite pull request #1483: IGNITE-4570 Parsing for CREATE INDEX and DROP IND...

2017-01-31 Thread alexpaschenko
GitHub user alexpaschenko opened a pull request: https://github.com/apache/ignite/pull/1483 IGNITE-4570 Parsing for CREATE INDEX and DROP INDEX You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-4570 A

Re:

2017-01-31 Thread Denis Magda
Hi, Yes, you can and need to check changes incorporated in a pull-request using TeamCity. Refer to this documentation section: https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-1.CreateGitHubpull-request

[GitHub] ignite pull request #1484: IGNITE-4631 Added check to ensure QueryEntity 'ke...

2017-01-31 Thread skalashnikov
GitHub user skalashnikov opened a pull request: https://github.com/apache/ignite/pull/1484 IGNITE-4631 Added check to ensure QueryEntity 'keyFields' is subset o… …f 'fields' You can merge this pull request into a Git repository by running: $ git pull https://github.com/grid

Re: IGNITE-4212 (Ignite Benchmarking Simplification and Automation)

2017-01-31 Thread Denis Magda
Oleg, Thanks for the clarification. My opinion is that we should leave ‘modules/yardstick/README.txt’ and ‘modules/yardstick/DEVNOTES.txt’ either unchanged or have only those instructions there that explain how to build and run benchmarks from ‘modules/yardstick’. This existing files can refer

Re: Review for IGNITE-4436 API to collect list of running SQL queries

2017-01-31 Thread Denis Magda
Hi Alex, >> 1) Current implementation will collect info and cancel only "TwoStep" >> queries. >>Should we also support LOCAL queries? >> I would make it transparent for the user giving ability to work with LOCAL queries as well. How difficult is to support this? >> 2) Should we also suppor

Apache Ignite 1.9

2017-01-31 Thread Denis Magda
Igniters, Looks like 2.0 will be slightly delayed since the community requires more time to make the new page memory architecture faster. At the same time we have a plenty of bug fixes and performance improvements that were merged or close to be merged into the master and ready to be released.

Re: Integration with RocketMQ

2017-01-31 Thread Denis Magda
Roman, Do you have any progress on this? It will be perfect to have the feature in 1.9. Please join the discussion: http://apache-ignite-developers.2346864.n4.nabble.com/Apache-Ignite-1-9-td14170.html — Deni

Re: moving to geronimo JCache jar

2017-01-31 Thread Denis Magda
Alexander, provided review notes in the Upsource. However, I’m still a bit concerned about the content of ignite-core-licenses.txt (see attached). The file says that it contains licenses different from the Apache Software license but in fact lists shmem, Intellij IDEA annotations and JSR 107 al

Re: moving to geronimo JCache jar

2017-01-31 Thread Alexander Fedotov
Denis, it is my mistake to leave the header unchanged. It should be fixed because from now on the generation of license notes for dependencies under Apache Software License is enabled according to the point 3 in JIRA . I'll fix it and your notes in

Re: Review for IGNITE-4436 API to collect list of running SQL queries

2017-01-31 Thread Alexey Kuznetsov
Denis, >> I would make it transparent for the user giving ability to work with LOCAL queries as well. How difficult is to support this? I think it not should be very hard, but I will need some help from our SQL experts. >> Isn’t the goal of this task to support all SQL queries? Don’t get why you

Re: Review for IGNITE-4436 API to collect list of running SQL queries

2017-01-31 Thread Denis Magda
> On Jan 31, 2017, at 4:24 PM, Alexey Kuznetsov wrote: > > Denis, > >>> I would make it transparent for the user giving ability to work with > LOCAL queries as well. How difficult is to support this? > I think it not should be very hard, but I will need some help from our SQL > experts. > >>>

Re: Python Platform for Ignite

2017-01-31 Thread Shashank Gandham
Okay, I will start look into the C++ shared libraries. > On 31-Jan-2017, at 1:44 AM, Denis Magda wrote: > > Hi Shashank, > > I’ve prepared tickets related to this activity: > https://issues.apache.org/jira/browse/IGNITE-4600 > > > I would agr

[jira] [Created] (IGNITE-4632) AffinityFunction unchecked exception handling (unassigned backup)

2017-01-31 Thread Alexandr Kuramshin (JIRA)
Alexandr Kuramshin created IGNITE-4632: -- Summary: AffinityFunction unchecked exception handling (unassigned backup) Key: IGNITE-4632 URL: https://issues.apache.org/jira/browse/IGNITE-4632 Project

Re: Unused variables in code

2017-01-31 Thread Yakov Zhdanov
Thanks, Alexander! I looked this through and it seems fine to me. Anton V, can you also review and merge if it is OK to you? --Yakov 2017-01-31 12:49 GMT+03:00 Александр Меньшиков : > And result of testing: > http://ci.ignite.apache.org/project.html?projectId=IgniteTests&tab= > projectOverview&