Re: Tx lock partial happens before

2019-07-15 Thread Ivan Rakov
Anton, Step-by-step: 1) primary locked on key mention (get/put) at pessimistic/!read-committed tx 2) backups locked on prepare 3) primary unlocked on finish 4) backups unlocked on finish (after the primary) correct? Yes, this corresponds to my understanding of transactions protocol. With minor

[jira] [Created] (IGNITE-11985) .NET: CompiledQuery.Compile does not work with string parameters

2019-07-15 Thread Pavel Tupitsyn (JIRA)
Pavel Tupitsyn created IGNITE-11985: --- Summary: .NET: CompiledQuery.Compile does not work with string parameters Key: IGNITE-11985 URL: https://issues.apache.org/jira/browse/IGNITE-11985 Project:

[jira] [Created] (IGNITE-11984) .NET CompiledQuery won't work with strings

2019-07-15 Thread Alexandr Shapkin (JIRA)
Alexandr Shapkin created IGNITE-11984: - Summary: .NET CompiledQuery won't work with strings Key: IGNITE-11984 URL: https://issues.apache.org/jira/browse/IGNITE-11984 Project: Ignite

[jira] [Created] (IGNITE-11983) TcpDiscoverySpi: Infinite circulation of TcpStatusCheckMessage after node restart

2019-07-15 Thread Dmitry Lazurkin (JIRA)
Dmitry Lazurkin created IGNITE-11983: Summary: TcpDiscoverySpi: Infinite circulation of TcpStatusCheckMessage after node restart Key: IGNITE-11983 URL: https://issues.apache.org/jira/browse/IGNITE-11983

Re: Read Repair (ex. Consistency Check) - review request #2

2019-07-15 Thread Dmitriy Pavlov
Ok, thank you пн, 15 июл. 2019 г., 16:46 Nikolay Izhikov : > I did the review. > > пн, 15 июля 2019 г., 16:15 Dmitriy Pavlov : > > > Igniters, who did a review of > > https://issues.apache.org/jira/browse/IGNITE-10663 before the merge? > I've > > checked both PR

Re: Read Repair (ex. Consistency Check) - review request #2

2019-07-15 Thread Nikolay Izhikov
I did the review. пн, 15 июля 2019 г., 16:15 Dmitriy Pavlov : > Igniters, who did a review of > https://issues.apache.org/jira/browse/IGNITE-10663 before the merge? I've > checked both PR https://github.com/apache/ignite/pull/5656 and Issue, > and dev.list thread and didn't find any LGTM. > >

[jira] [Created] (IGNITE-11982) Fix bugs of pds

2019-07-15 Thread Anton Kalashnikov (JIRA)
Anton Kalashnikov created IGNITE-11982: -- Summary: Fix bugs of pds Key: IGNITE-11982 URL: https://issues.apache.org/jira/browse/IGNITE-11982 Project: Ignite Issue Type: Bug

Re: Read Repair (ex. Consistency Check) - review request #2

2019-07-15 Thread Dmitriy Pavlov
Igniters, who did a review of https://issues.apache.org/jira/browse/IGNITE-10663 before the merge? I've checked both PR https://github.com/apache/ignite/pull/5656 and Issue, and dev.list thread and didn't find any LGTM. Anton, since you've rejected lazy consensus in our process, we have RTC in

Re: Read Repair (ex. Consistency Check) - review request #2

2019-07-15 Thread Вячеслав Коптилин
Hello Anton, > I'd like to propose you to provide fixes as a PR since you have a vision of how it should be made. I'll review them and merge shortly. Could you please take a look at PR: https://github.com/apache/ignite/pull/6689 > Since your comments mostly about Javadoc (does this mean that my

[jira] [Created] (IGNITE-11981) [IEP-35] Create MU shortcut instead of static import of MetricUtils

2019-07-15 Thread Nikolay Izhikov (JIRA)
Nikolay Izhikov created IGNITE-11981: Summary: [IEP-35] Create MU shortcut instead of static import of MetricUtils Key: IGNITE-11981 URL: https://issues.apache.org/jira/browse/IGNITE-11981

[jira] [Created] (IGNITE-11980) Repairs count metric (ReadRepair)

2019-07-15 Thread Anton Vinogradov (JIRA)
Anton Vinogradov created IGNITE-11980: - Summary: Repairs count metric (ReadRepair) Key: IGNITE-11980 URL: https://issues.apache.org/jira/browse/IGNITE-11980 Project: Ignite Issue Type:

Re: Tx lock partial happens before

2019-07-15 Thread Anton Vinogradov
Ivan R. Thanks for joining! Got an idea, but not sure that got a way of a fix. AFAIK (can be wrong, please correct if necessary), at 2PC, locks are acquired on backups during the "prepare" phase and released at "finish" phase after primary fully committed. Step-by-step: 1) primary locked on key