Re: New committer: Vladimir Ermakov

2021-06-07 Thread Pavel Tupitsyn
Hi Vladimir, Welcome to the Apache Ignite community! I've added you to the Contributors role in JIRA. Note: "Committer" is a community member with direct commit access [1]. [1] https://apache.org/foundation/glossary.html#Committer On Mon, Jun 7, 2021 at 4:27 PM Владимир Ермаков wrote: >

Re: Default Lucene index for String cache values

2021-06-07 Thread Vladimir Pligin
Hi guys, I've checked that a text index is being created only if a user specifies indexedTypes (or something similar). It would be nice to give users an option to avoid this behaviour as it's technically a workaround because it's not possible to somehow specify the @QueryTextField annotation on a

New committer: Vladimir Ermakov

2021-06-07 Thread Владимир Ермаков
Hello Ignite Community! My name is Vladimir, I am a software engineer from Saint-Petersburg, Russia. I want to contribute to Apache Ignite. I am going to start with this issue - IGNITE-14120. My JIRA username is vermakov. Please, provide me with access to Apache Ignite JIRA. Thanks!

Re: [DISCUSSION] Code style. Variable abbrevations

2021-06-07 Thread Nikolay Izhikov
Hello, Anton, Alexei. Thanks for the feedback. Personally, I’m pretty happy current abbreviation rules too. Let see what we can do to make our codebase even more consistent. > 7 июня 2021 г., в 13:23, Alexei Scherbakov > написал(а): > > -1 > Common abbrevs add quality to the code. > > пн, 7

Re: [DISCUSSION] Code style. Variable abbrevations

2021-06-07 Thread Alexei Scherbakov
-1 Common abbrevs add quality to the code. пн, 7 июн. 2021 г. в 12:38, Anton Vinogradov : > -1 here. > We can fix the code and set up the rule. > > This will help to prevent having a weird abbreviation like "mess" (from > "message") or "ign" (from "Ignite"). > Also, the abbreviations list

Re: [DISCUSSION] Code style. Variable abbrevations

2021-06-07 Thread Anton Vinogradov
-1 here. We can fix the code and set up the rule. This will help to prevent having a weird abbreviation like "mess" (from "message") or "ign" (from "Ignite"). Also, the abbreviations list (hardcoded at IDEA plugin) allows to have same names across the whole code, this should simplify the reading.

Re: IGNITE-13364: Improve index inline defaults

2021-06-07 Thread Maksim Timonin
Hi, I've left a comment in your PR, could you please have a look? On Sat, Jun 5, 2021 at 6:09 AM 18624049226 <18624049...@163.com> wrote: > Hello team, > > I think this is a very valuable optimization. This patch has been > developed for a long time, I don't think there is any reason to continue