Re: IGNITE-14812: Statistics

2021-06-22 Thread Nikolay Izhikov
Hello, Taras. Thanks for feedback. > AFAIK and as long as I can remember Ignite project try to minimize external > dependencies usage and adds new external dependency only when there is no > other way out. Does it mean we have to incapsulate every external library we want to use? Taras, can y

Re: IGNITE-14812: Statistics

2021-06-22 Thread Taras Ledkov
Hi, We have discussed BCrypt include/add dependency here [1]. AFAIK and as long as I can remember Ignite project try to minimize external dependencies usage and adds new external dependency only when there is no other way out. [1]. http://apache-ignite-developers.2346864.n4.nabble.com/Usernam

Re: [DISCUSSION] Code style. Variable abbrevations

2021-06-22 Thread Ivan Pavlukhina
Folks, I suppose we should rollout voting regarding abbreviations in Ignite 3. BTW, are you actually aware of any other project defining something similar to our abbreviations? Sent from my iPhone > On 23 Jun 2021, at 14:53, Nikita Ivanov wrote: > > What's worked for countless companies is t

Re: [DISCUSSION] Code style. Variable abbrevations

2021-06-22 Thread Nikita Ivanov
What's worked for countless companies is the combination of the following: 1. Well defined rules (abbreviations, code styles & documentation, code organization, etc., etc.) for common/frequent use cases. 2. Some basic tooling (wherever possible) plus a strong culture of code reviews. 3. And... comm

Re: IGNITE-14812: Statistics

2021-06-22 Thread Valentin Kulichenko
Dmitry, As the PMC chair, would you mind contacting legal regarding the matter? This is not the only example of such code (e.g. [1]), so we should look into this asap. [1] https://github.com/apache/ignite/blob/master/modules/core/src/main/java/org/mindrot/BCrypt.java As for this particular commi

Re: [DISCUSSION] Code style. Variable abbrevations

2021-06-22 Thread Valentin Kulichenko
Nikolay, I'm confused. Konstantin gave you an example of a bad abbreviation that cannot be caught by automated validation, and you referred to the code review as a solution. But then you said that common sense doesn't work. Code review IS common sense for the most part though. Either way, I'm not

Re: IGNITE-14812: Statistics

2021-06-22 Thread Dmitry Pavlov
Hi Nikolai, thank you for noticing. I guess it's not about license, but about Intellectual Property (IP) ownership. AFAIK, Apache License 2.0 is here and AL 2.0 is definetely allowed to be used in the codebase for an Apache project (https://www.apache.org/legal/resolved.html) But licenese and

IGNITE-14812: Statistics

2021-06-22 Thread Nikolay Izhikov
Hello, Igniters. Recently huge commit was merged [1]. Taras, Alexander, can you, please, explain what is purpose of the commit? What feature it implemented? Looked inside the ticket and found no explanation. Description is "Add statistics collection and usage.» Do we have plans to document this

IndexOutOfBoundsException in GridCacheWriteBehindStore Flusher thread lookup (IGNITE-14893)

2021-06-22 Thread Ilya Korol
Hi, All. I'm going to fix issue with IndexOutOfBoundsException in GridCacheWriteBehindStore#flusher(K key) method. https://issues.apache.org/jira/browse/IGNITE-14893 This could happen when flush thread count is not a power of 2 an we fallback to mapping via modulo operation: idx = ((h = k

Share my Apache Ignite Use Case

2021-06-22 Thread Ken Cheng
Thanks, Ken Cheng

Re: Temporary TC Outage

2021-06-22 Thread Petr Ivanov
Good news. TC is back online. In case of any problems, please, write them on dev list, I will check. > On 21 Jun 2021, at 19:40, Dmitry Pavlov wrote: > > Hi Petr, > > Sad news, but anyway, thank you for letting community know. > > Sincerely, > Dmitriy Pavlov > > On 2021/06/21 16:19:16, Pe

Re: [DISCUSSION] Code style. Variable abbrevations

2021-06-22 Thread Nikolay Izhikov
Hello, Pavel > But it doesn't mean that now we need to use only full names. > Abbreviations may be used e.g. for local variables with short scope. > Here we must follow common sense and existing practices of effective naming. > It shouldn't be a cargo cult as it is now. But «common sense» has