Re: IGNITE-14812: Statistics

2021-06-23 Thread Ivan Daschinsky
AFAIK, it is enough to include mention of this library in NOTICE, please see here [1][2][3] [1] -- https://www.apache.org/legal/src-headers.html#3party [2] -- https://www.apache.org/legal/src-headers.html#notice [3] -- https://www.apache.org/legal/resolved.html ср, 23 июн. 2021 г. в 17:36,

Re: [DISCUSSION] Brand new distributed environment testing framework ready to be reviewed/merged.

2021-06-23 Thread Denis Magda
Congrats, Anton, that's a valuable contribution! I attended your session at the Ignite Summit and wonder if you should share that recording with an English-speaking part of the community? - Denis On Wed, Jun 23, 2021 at 7:37 AM Anton Vinogradov wrote: > Folks, > > Here's the video [1] that

Re: IGNITE-14812: Statistics

2021-06-23 Thread Valentin Kulichenko
Taras, It is true that we try to minimize dependencies, but there are some anyway. I think it's perfectly fine to add this library as a dependency. Will you be able to do this asap? It is surely better than reverting the commit :) -Val On Wed, Jun 23, 2021 at 12:32 AM Taras Ledkov wrote: >

Re: IEP-75 Thin Client MsgPack Serialization for 3.0

2021-06-23 Thread Pavel Tupitsyn
Ivan, Yes, this proposal is about the binary protocol - the way we serialize primitive values, the foundation for the thin client protocol. Key-value API still has some uncertainty around it, we'll discuss it separately. On Wed, Jun 23, 2021 at 2:31 PM Ivan Daschinsky wrote: > Pavel, let me

Re: [DISCUSSION] Brand new distributed environment testing framework ready to be reviewed/merged.

2021-06-23 Thread Anton Vinogradov
Folks, Here's the video [1] that explains the proposal in detail. Feel free to ask questions here. [1] https://www.youtube.com/watch?v=f-i9COU5uAQ (in Russian) On Tue, Jun 8, 2021 at 2:51 PM Anton Vinogradov wrote: > Igniters, > Let me present a framework, we developed, that allows automating

Re: IEP-75 Thin Client MsgPack Serialization for 3.0

2021-06-23 Thread Ivan Daschinsky
Pavel, let me clarify one thing. 1. If this proposal is about binary protocol, then there is no objection I suppose. 2. If this proposal about serialization of key-value, there are some uncertainties, especially about complex objects. In this case this proposal needs more work. ср, 23 июн. 2021

Re: IEP-75 Thin Client MsgPack Serialization for 3.0

2021-06-23 Thread Pavel Tupitsyn
Igniters, Looks like there are no objections and we can accept the proposal. I will close it tomorrow and move on to the thin client protocol itself. On Fri, Jun 18, 2021 at 12:10 PM Ivan Daschinsky wrote: > >> To make it fair. Ignite uses thread-local reusable buffers, see [1]. > I know, but

Re: IGNITE-14812: Statistics

2021-06-23 Thread Taras Ledkov
Hi, > Taras, can you, please, describe the features that was implemented in this merge? > How users supposed to use them? > Do we have plans to document? Sure. Alexander Belyak will describe and file ticket to documentation. On 23.06.2021 9:27, Nikolay Izhikov wrote: Hello, Taras. Thanks

Re: [DISCUSSION] Code style. Variable abbrevations

2021-06-23 Thread Nikolay Izhikov
Val. > But then you said that common sense doesn't work. Code review IS common sense > for the most part though. Code review must catch errors like "No validation in the world prevent me from typing manually "mess" instead of «msg»" But, when one reviewer prefers `qry` and another requires

Re: IGNITE-14812: Statistics

2021-06-23 Thread Nikolay Izhikov
Hello, Taras. Thanks for feedback. > AFAIK and as long as I can remember Ignite project try to minimize external > dependencies usage and adds new external dependency only when there is no > other way out. Does it mean we have to incapsulate every external library we want to use? Taras, can

Re: IGNITE-14812: Statistics

2021-06-23 Thread Taras Ledkov
Hi, We have discussed BCrypt include/add dependency here [1]. AFAIK and as long as I can remember Ignite project try to minimize external dependencies usage and adds new external dependency only when there is no other way out. [1].