Hi Pavel,
I've looked at the IEP and the public API - looks good to me.
Quick question - do you plan to add sync methods to the interfaces, or
you're thinking to only leave async? If the latter, what are the arguments
for this? The reason I'm asking is that I'm actually thinking about
suggesting
Igniters,
Please review the IEP [1] and the PoC [2] for .NET Thin Client in Ignite
3.0.
[1]
https://cwiki.apache.org/confluence/display/IGNITE/IEP-78+.NET+Thin+Client
[2] https://github.com/apache/ignite-3/pull/306
Andrey,
> It just doesn't work. If there is precedent of usage of Guava methods
then somebody will use other methods.
Maybe you are right. I would suggest a vote on whether we should allow
Guava methods in the codebase or not. Let's do that in a separate thread?
In the meantime we will prohibit u
Zhenya,
I think that this problem exists regardless of whether we have our own
version of Guava or not: multiple dependencies can depend on Guava which
will lead to clashes on the classpath. If a transitive version is updated
in an incompatible way, we can try updating our version as well. And if
t
> So I would propose to allow at least *some* methods that we consider useful,
> while disallowing everything else.
It just doesn't work. If there is precedent of usage of Guava methods
then somebody will use other methods.
> I think that the benefits of using Guava methods instead of copy-pasti
Alex, what about : «compatibility when the transitive Guava dependency
will be updated to a new version.» ? I don`t know is it an issue for us, but we
need to answer it before move forward.
>Andrey,
>I think that the benefits of using Guava methods instead of copy-pasting
>them are quite obvi
Andrey,
I think that the benefits of using Guava methods instead of copy-pasting
them are quite obvious: you don't have to copy-paste code and support it. I
also find this situation quite strange: we have a dependency and copy-paste
code from it instead of using it directly.
On Thu, Sep 2, 2021 a
Alex,
As I understand we agree to shade Guava transitive dependency and
you said a 'maven-shade-plugin' can drop unused Guava methods to reduce the
footprint of Ignite jar.
At this point, there is no difference between copy-pasting Guava method to
Ignite and use Guava one.
The resulted jar will h
Hi, Andrey!
I mostly agree with your proposal, but, since we already have some
copy-paste in our code, can we at least use Guava to remove it? So I would
propose to allow at least *some* methods that we consider useful, while
disallowing everything else. I understand that it may be difficult to
for
