Re: [DISCUSSION] Add SystemRegionMetricsEnabled property on DataStorageConfiguration.

2021-11-25 Thread Eduard Rakhmankulov
Folks, I have created a new ticket [1] for moving system-region-related-properties to its own class. I will be pleased with your feedback on this topic. 1. https://issues.apache.org/jira/browse/IGNITE-15998 On Tue, 2 Nov 2021 at 19:58, Eduard Rakhmankulov wrote: > Hi, Andrey! > > Thank you

Re: Moving snapshot tests to their own test suites

2021-11-25 Thread Petr Ivanov
My concern was only that 1.0 is too high for TC overall. If it is OK for Nightly builds — no problems. However — ordinary Run All uses 0.1 scale and to use 0.2 in that suite we should hardcode it inside the suite (or to be more precise — compute based on input). > On 25 Nov 2021, at 16:06,

Re: Apache Ignite 2.12 RELEASE [Time, Scope, Manager]

2021-11-25 Thread Nikita Amelchev
Hello Ivan, +1, the issue can be cherry-picked to the 2.12. чт, 25 нояб. 2021 г. в 17:07, Ivan Bessonov : > > Hello everyone, > > is there a chance to add this issue to the release scope? [1] > Currently, defragmentation of certain types of indexes can corrupt them. > Fix is straightforward and

Re: Apache Ignite 2.12 RELEASE [Time, Scope, Manager]

2021-11-25 Thread Ivan Bessonov
Hello everyone, is there a chance to add this issue to the release scope? [1] Currently, defragmentation of certain types of indexes can corrupt them. Fix is straightforward and should not cause any problems. Thank you! [1] https://issues.apache.org/jira/browse/IGNITE-15968 вт, 23 нояб. 2021 г.

Re: Moving snapshot tests to their own test suites

2021-11-25 Thread Maxim Muzafarov
Petr, For the RunAll - 0.2 For the RunAll(Nightly) - 1.0 (the 1.0 is better that 0.2 for sure) On Thu, 25 Nov 2021 at 15:54, Petr Ivanov wrote: > > 0.2 or 1.0? > > > On 25 Nov 2021, at 14:34, Maxim Muzafarov wrote: > > > > Pert, > > > > I think for nightly builds this is the only right option

Re: Moving snapshot tests to their own test suites

2021-11-25 Thread Petr Ivanov
0.2 or 1.0? > On 25 Nov 2021, at 14:34, Maxim Muzafarov wrote: > > Pert, > > I think for nightly builds this is the only right option for the > suites mentioned above. > > On Thu, 25 Nov 2021 at 14:33, Petr Ivanov wrote: >> >> Hi, Maksim. >> >> >> Run All (Nightly) build will run suites

RE: Issue - IGNITE-15348

2021-11-25 Thread Andrei Demidov
Thanks!

Re: Issue - IGNITE-15348

2021-11-25 Thread Alex Plehanov
Nikolay, Andrei, I've already merged the patch. чт, 25 нояб. 2021 г. в 14:36, Nikolay Izhikov : > Hello, Andrei. > > I will review your changes shortly. > > > 25 нояб. 2021 г., в 14:31, Andrei Demidov > написал(а): > > > > Hi! > > > > Could somebody please explain me. > > Should I do something

Re: Issue - IGNITE-15348

2021-11-25 Thread Andrei Demidov
Ok, thanks!

Re: Issue - IGNITE-15348

2021-11-25 Thread Nikolay Izhikov
Hello, Andrei. I will review your changes shortly. > 25 нояб. 2021 г., в 14:31, Andrei Demidov > написал(а): > > Hi! > > Could somebody please explain me. > Should I do something for my changes to be merged? > In contributing guide it's said that changes will be merged by any committer >

Re: Moving snapshot tests to their own test suites

2021-11-25 Thread Maxim Muzafarov
Pert, I think for nightly builds this is the only right option for the suites mentioned above. On Thu, 25 Nov 2021 at 14:33, Petr Ivanov wrote: > > Hi, Maksim. > > > Run All (Nightly) build will run suites with test scale factor 1.0 — will it > be a problem? > > > On 25 Nov 2021, at 14:22,

Re: Moving snapshot tests to their own test suites

2021-11-25 Thread Petr Ivanov
Hi, Maksim. Run All (Nightly) build will run suites with test scale factor 1.0 — will it be a problem? > On 25 Nov 2021, at 14:22, Maxim Muzafarov wrote: > > Folks, > > I've merged the PR [1] to the master branch and applied scale factor > 0.2 to the tests that were moved to dedicated

Re: Issue - IGNITE-15348

2021-11-25 Thread Andrei Demidov
Hi! Could somebody please explain me. Should I do something for my changes to be merged? In contributing guide it's said that changes will be merged by any committer after review. Thanks!

Re: Moving snapshot tests to their own test suites

2021-11-25 Thread Maxim Muzafarov
Folks, I've merged the PR [1] to the master branch and applied scale factor 0.2 to the tests that were moved to dedicated suites. I've created two suites and added them to the Run.All test suite. - Snapshots [2] - SnapshotsWithIndexes [3] [1] https://github.com/apache/ignite/pull/9584/files [2]

Re: IEP-82 Thin Client Retry Policy

2021-11-25 Thread Pavel Tupitsyn
Igor, I think it should list all operations, mostly the same as ClientOperation enum, but without internal things like RESOURCE_CLOSE. Users should be able to implement policies like "retry k/v operations, but not SQL". On Thu, Nov 25, 2021 at 12:27 PM Igor Sapego wrote: > Pavel, > > What is

Re: IEP-82 Thin Client Retry Policy

2021-11-25 Thread Igor Sapego
Pavel, What is ClientOperationType? Will it list basically all operations or only types like Idempotent, NonIdempotent? Best Regards, Igor On Wed, Nov 24, 2021 at 5:21 PM Pavel Tupitsyn wrote: > Igniters, > > I've prepared a proposal about thin client retry behavior. > Please review and let