Re: [DISCUSSION] Change default behaviour of atomic operations inside transactions

2022-10-18 Thread Nikita Amelchev
Hi, Maksim. I think marking the issue as 'important' and filling out the release notes field is enough to get the attention of a release manager. вт, 18 окт. 2022 г. в 20:26, Maksim Timonin : > > Hi guys, > > We agreed here [1] that all deprecations must be noted within release > notes. Do we hav

Re: [DISCUSSION] Change default behaviour of atomic operations inside transactions

2022-10-18 Thread Maksim Timonin
Hi guys, We agreed here [1] that all deprecations must be noted within release notes. Do we have an option to mark a jira ticket in such a way to fill the future release notes correctly? [1] https://lists.apache.org/thread/3ko0kjdv16o3oftsfh8z8nz0tyfvo13v On Mon, Oct 17, 2022 at 8:21 PM Anton Vi

Re: Shutdown policy refactoring

2022-10-18 Thread Aleksandr Polovtsev
My guess is that it reduces the node shutdown time. We may want to keep it for compatibility purposes, because I'm afraid that changing the default behaviour is not that easy. On Tue, Oct 18, 2022 at 12:32 PM Николай Ижиков wrote: > So why it’s default behavior? > And why we want keep it? > > >

Re: Shutdown policy refactoring

2022-10-18 Thread Николай Ижиков
So why it’s default behavior? And why we want keep it? > 18 окт. 2022 г., в 12:27, Aleksandr Polovtsev > написал(а): > > But this is the default behaviour right now, do you mean we should change > it? I'm ok with that if it will not break something > > On Tue, Oct 18, 2022 at 12:13 PM Николай

Re: Shutdown policy refactoring

2022-10-18 Thread Aleksandr Polovtsev
But this is the default behaviour right now, do you mean we should change it? I'm ok with that if it will not break something On Tue, Oct 18, 2022 at 12:13 PM Николай Ижиков wrote: > > I don't know what most people use in the real world, maybe more > experienced guys can clarify that. > > My que

Re: Shutdown policy refactoring

2022-10-18 Thread Николай Ижиков
> I don't know what most people use in the real world, maybe more experienced > guys can clarify that. My question is different. Why we may want to provide cancel=true? Is there any reason to support this in Ignite? > 18 окт. 2022 г., в 11:47, Aleksandr Polovtsev > написал(а): > > Thank you

Re: Shutdown policy refactoring

2022-10-18 Thread Aleksandr Polovtsev
Thank you for the response, Nikolay. As I can see, this is the default behaviour now (ShutdownPolicy = IMMEDIATE, cancel = true). I don't know what most people use in the real world, maybe more experienced guys can clarify that. On Tue, Oct 18, 2022 at 11:15 AM Николай Ижиков wrote: > Hello, > >

Re: Shutdown policy refactoring

2022-10-18 Thread Николай Ижиков
Hello, Why do we need «immediate»? Is there real-world scenarios for it? Can we do graceful or «save all possible data» shutdown always? > 18 окт. 2022 г., в 10:59, Aleksandr Polovtsev > написал(а): > > Hello, dear Igniters! > > I'd like to propose a refactoring of the current Shutdown Pol

Shutdown policy refactoring

2022-10-18 Thread Aleksandr Polovtsev
Hello, dear Igniters! I'd like to propose a refactoring of the current Shutdown Policy mechanism. Currently, node shutdown is controlled by a bunch of flags and enums (I may be missing some of them): 1. ShutdownPolicy enum has only two entries and is basically a flag that dictates if we need to w