It is now required to check all copied files before merge.
>>
>> Sincerely,
>> Dmitriy Pavlov
>>
>> пн, 7 мая 2018 г. в 11:07, Роман Меерсон :
>>
>>> Hello Dmitry!
>>>
>>> was review successfull? Or there are any points to change?
>>>
&
Hello Dmitry!
was review successfull? Or there are any points to change?
сб, 28 апр. 2018 г. в 19:32, Роман Меерсон :
> Ok! I believe in community and that things would change!
> Looking forward for news
> сб, 28 апр. 2018 г. в 19:29, Dmitry Pavlov :
>
>> I hope so!
>&
merged more
> than 1month. This defenetely should be changed. And I hope all Ignite
> committers and maintainters would continue to assist in this.
>
> сб, 28 апр. 2018 г. в 18:24, Роман Меерсон :
>
>> Hi all!
>>
>> Soon we'll celebrate 2 months of my PR :)
>>
Hi all!
Soon we'll celebrate 2 months of my PR :)
Maybe it could be merged?
пн, 23 апр. 2018 г. в 18:52, Dmitry Pavlov :
> No, nothing yet. I'm going to look to new version.
>
> пн, 23 апр. 2018 г. в 17:43, Роман Меерсон :
>
>> Hi all!
>>
>> Are there any
Hi all!
Are there any news about PR merging?
пн, 16 апр. 2018 г. в 19:43, Роман Меерсон :
> Denis,
>
> module naming fixed
>
> пн, 16 апр. 2018 г. в 19:24, Denis Magda :
>
>> Roman,
>>
>> In my last reply, I voted for your approach - using "spring-dat
; to separate a version from the package name.
>
> --
> Denis
>
> On Sun, Apr 15, 2018 at 8:17 AM, Роман Меерсон
> wrote:
>
> > Hi all!
> >
> > So guys let’s make a decision. We leave code in current state as I
> suggest
> > or change module naming
ue, Apr 10, 2018 at 2:50 PM, Роман Меерсон
> wrote:
>
> > Hi all!
> >
> > IMHO if we do so we'll produce big pain for everybody while migrating on
> > new version, because ones should change method and others should change
> > their poms. This change wou
be
>> requiered to update their pom's. In the same time users which are ready to
>> migrate to spring data 2.0 will need to update methods naming.
>>
>> Denis M, what would you say?
>>
>> Sincerely,
>> Dmitriy Pavlov
>>
>> вт, 10 апр. 2018
Hi Dmitry!
I`ve just commited new fix. I renamed package of new module to
springdata20, it helps us to separate old implementation from new and also
should fix all compilation errors.
пн, 9 апр. 2018 г. в 23:54, Роман Меерсон :
> Ok, I'll check it, but I haven't face this probl
. Ignite in
> Idea can't compile.
>
>
> пн, 9 апр. 2018 г., 21:38 Роман Меерсон :
>
>> Hi Dmitry!
>
>
>> Could you specify where you find conflict? Because I don’t have any.
>> пн, 9 апр. 2018 г. в 21:09, Dmitry Pavlov :
>>
>>> Hi Denis,
&
ture. I remember about this change.
>>>>
>>>> If Denis M. would be able to look througt the changes faster than me, I
>>>> can merge without detailed review.
>>>>
>>>> пт, 6 апр. 2018 г. в 16:15, Роман Меерсон :
>>>>
>>>
OK
[image: 1486924635147168240.jpg]
пт, 6 апр. 2018 г. в 17:08, Igor Sapego :
> Hi,
> Well, Dmitry has said he's going to merge it in 3-4 days 2 days ago,
> so I guess, the merge is going to happen in 1-2 days or so.
>
>
> Best Regards,
> Igor
>
> On Fri, Apr 6
Hi all!
As i see everything is awesome and there is no objections, so when my PR
would be merged?
чт, 5 апр. 2018 г. в 18:58, Вячеслав Коптилин :
> Thank you, Roman!
>
> 2018-04-05 17:49 GMT+03:00 Роман Меерсон :
>
> > Hi Slava,
> >
> > Fixed
> >
>
es/spring-data-2.0/src/main/java/org/apache/ignite/springdata/repository/query/IgniteQueryGenerator.java
> >
>
> Best regards,
> Slava.
>
> 2018-04-05 14:59 GMT+03:00 Роман Меерсон :
>
> > Ok, so waiting for accept and commit
> >
> > чт, 5 апр. 2018 г. в 1
Ok, so waiting for accept and commit
чт, 5 апр. 2018 г. в 15:29, Alexey Kukushkin :
> Roman,
>
> Just pay commiter's (Dmitry Pavlov will most likely commit your code)
> attention to include the new test suite to TeamCity configuration.
>
Alexey,
1) Fixed
2) How could i be sure? What do i need to do?
чт, 5 апр. 2018 г. в 14:24, Alexey Kukushkin :
> Roman,
>
> Just two small comments from me:
>
>1. I suggest renaming IgniteSpringDataTestSuite to
>IgniteSpringData2TestSuite: we must be able to test both spring-data and
>
I`ve finished with new module:
https://github.com/apache/ignite/pull/3704
чт, 5 апр. 2018 г. в 12:06, Роман Меерсон :
> Ok guys, I`ll made changes but what should we do with examples and with
> Spring module version?
>
> Exemples couldn`t support both versions, so should i leave upg
Ok guys, I`ll made changes but what should we do with examples and with
Spring module version?
Exemples couldn`t support both versions, so should i leave upgraded to 2.0
version?
Spring module was upgraded to newest version, so should i leave it on
newest version?
чт, 5 апр. 2018 г. в 0:17, Denis
pache/ignite/pull/3704
> Upsource: https://reviews.ignite.apache.org/ignite/review/IGNT-CR-541
> TeamCity:
> https://ci.ignite.apache.org/viewLog.html?buildId=1170373&tab=buildResultsDiv&buildTypeId=IgniteTests24Java8_RunAll
>
> 2018-03-22 21:48 GMT+03:00 Роман Меерсон :
>
Hi all!
Dmitriy thank you for review.
I`ve just fixed all your comments.
чт, 22 мар. 2018 г. в 20:36, Dmitry Pavlov :
> HI Dmitriy, thank you!
>
> Roman, could you please address Dmitriy's comments?
>
> чт, 22 мар. 2018 г. в 19:18, Дмитрий Рябов :
>
>> Hi Dmitriy,
>>
>> I took a look for PR, it
Hello!
I want to work on https://issues.apache.org/jira/browse/IGNITE-6879 issue.
Following the rules here
https://ignite.apache.org/community/contribute.html#contribute my Jira
username is "homich" so assign me to this ticket please.
P.S. I found this rules page after I made PR, so sorry for thi
21 matches
Mail list logo
