GridKernalContextImpl.isDaemon is calling System.Properties frequently

2020-03-26 Thread Sunny Chan, CLSA
Hello, I was performing some tuning using JFR with our application, and I have found that in many of the cache get it makes a lot of calls to get System Properties, which is a synchronized call. Upon further examination of the code I have found that we can potentially optimized the code to cach

RE: Configuring Ignite Thread Pool's Core thread count/max thread count/etc

2020-02-27 Thread Sunny Chan, CLSA
object, similar to my proposal 2 –would that be better? From: Ilya Kasnacheev Sent: Thursday, February 27, 2020 6:05 PM To: Sunny Chan, CLSA Cc: dev Subject: Re: Configuring Ignite Thread Pool's Core thread count/max thread count/etc Hello! My suggestion is t

RE: Configuring Ignite Thread Pool's Core thread count/max thread count/etc

2020-02-26 Thread Sunny Chan, CLSA
hread count/max thread count/etc Hello! We recommend exposing IgniteConfiguration for user to modify. You never know in advance what kind of tuning will be needed, and don't want to play chinese whispers game with your users. Regards, -- Ilya Kasnacheev ср, 26 февр. 2020 г. в 13:07, Sunny

Configuring Ignite Thread Pool's Core thread count/max thread count/etc

2020-02-26 Thread Sunny Chan, CLSA
Hello, We are running Ignite cluster on bare metal on a relatively high core count machine (4x10 cores 20 threads), and looking some of the thread pool initialization code: (IgnitionEx.java) sysExecSvc = new IgniteThreadPoolExecutor( "sys", cfg.getIgniteInstanceN

RE: Log level changes in GridCacheWriteBehindStore.updateStore

2019-12-19 Thread Sunny Chan, CLSA
Sorry for taking so long, but it has dropped down my priority list :( I have now provided a github pull request for the logging changes I would like to make. Please review and let me know whether my patch is acceptable -Original Message- From: Sunny Chan, CLSA Sent: Friday, August 30

RE: Log level changes in GridCacheWriteBehindStore.updateStore

2019-08-30 Thread Sunny Chan, CLSA
Hello! I think you should go ahead and create a JIRA ticket about it, then someone (or even you) can check it and fix it. Regards, -- Ilya Kasnacheev пн, 26 авг. 2019 г. в 09:17, Sunny Chan, CLSA : > Hello, > > > > In the GridCacheWriteBehindStore > <https://urldefense.

Log level changes in GridCacheWriteBehindStore.updateStore

2019-08-25 Thread Sunny Chan, CLSA
Hello, In the GridCacheWriteBehindStore, when the updateStore failed to write to underlying store, it l

RE: Null check removal in IGNITE-5779

2018-05-22 Thread Sunny Chan, CLSA
gor Rudyak Cc: igor.rud...@rallyhealth.com Subject: Re: Null check removal in IGNITE-5779 Hi Igor, Could you please help with answering to this question? Sincerely, Dmitriy Pavlov вт, 15 мая 2018 г. в 5:18, Sunny Chan, CLSA : > Hello, > > > > In Ignite-5779 patch, CassandraSession

Null check removal in IGNITE-5779

2018-05-14 Thread Sunny Chan, CLSA
Hello, In Ignite-5779 patch, CassandraSessionImpl.java line 289 a null check for row has been removed (before the change: https://github.com/apache/ignite/blob/924b1faa64026107bf933ba441e743cf52cb94d1/modules/cassandra/store/src/main/java/org/apache/ignite/cache/store/cassandra/session/Cassandr

RE: IGNITE-6252 patch

2018-01-16 Thread Sunny Chan, CLSA
. will review the changes as soon as prolonged holidays are over. — Denis > On Jan 2, 2018, at 5:24 PM, Sunny Chan, CLSA wrote: > > Hello, > > I have replied to the comment in November and I am okay with your updated > patch – what do I need to do to move this forward? > >

RE: IGNITE-6252 patch

2018-01-02 Thread Sunny Chan, CLSA
Hello, I have replied to the comment in November and I am okay with your updated patch – what do I need to do to move this forward? From: Nikolai Tikhonov [mailto:ntikho...@apache.org] Sent: Tuesday, October 31, 2017 11:50 PM To: dev@ignite.apache.org; Sunny Chan, CLSA Subject: Re: IGNITE-6252

RE: [jira] [Created] (IGNITE-7083) Reduce memory usage of CachePartitionFullCountersMap

2017-12-05 Thread Sunny Chan, CLSA
I have created a pull request for my proposed change. https://github.com/apache/ignite/pull/3152 -Original Message- From: Denis Magda [mailto:dma...@apache.org] Sent: Saturday, December 02, 2017 3:10 AM To: dev@ignite.apache.org; Semen Boikov; Alexey Goncharuk Subject: Fwd: [jira] [Creat

RE: IGNITE-6252 patch

2017-10-31 Thread Sunny Chan, CLSA
I have reviewed and it looks good. From: Nikolai Tikhonov [mailto:ntikho...@apache.org] Sent: Tuesday, October 31, 2017 11:50 PM To: dev@ignite.apache.org; Sunny Chan, CLSA Subject: Re: IGNITE-6252 patch Hello, Thank you for your contribution! I've reviewed your changes and left comme

IGNITE-6252 patch

2017-10-30 Thread Sunny Chan, CLSA
Hello, During our testing we have found an issue and I have raised a JIRA ticket https://issues.apache.org/jira/browse/IGNITE-6252. I have also provided a patch that would fix the issue. Could someone take a look and see whether the patch is acceptable? Thanks. The content of this communicatio