Re: [DISCUSS] Disable socket linger by default in TCP discovery SPI.

2020-11-09 Thread Anton Vinogradov
PR's merged. Please make sure that users who use SSL will be notified to set linger at 2.10 migration doc. On Fri, Nov 6, 2020 at 1:01 PM Steshin Vladimir wrote: > The tickets are: [1] disables linger by default and [2] is the doc. > > > [1]

Re: [DISCUSS] Disable socket linger by default in TCP discovery SPI.

2020-11-06 Thread Steshin Vladimir
    The tickets are: [1] disables linger by default and [2] is the doc. [1] https://issues.apache.org/jira/browse/IGNITE-13643 [2] https://issues.apache.org/jira/browse/IGNITE-13662 05.11.2020 11:00, Anton Vinogradov пишет: Folks, Seems, we've got an agreement that the fix is necessary. Do

Re: [DISCUSS] Disable socket linger by default in TCP discovery SPI.

2020-11-05 Thread Anton Vinogradov
Folks, Seems, we've got an agreement that the fix is necessary. Do we need to do except the following? >> zero linger as default + warning on SSL enabled on JVM before the fix + warning at documentation + migration notes On Tue, Nov 3, 2020 at 2:38 PM Steshin Vladimir wrote: > Ilya, hi. >

Re: [DISCUSS] Disable socket linger by default in TCP discovery SPI.

2020-11-03 Thread Steshin Vladimir
    Ilya, hi.     Of course: /TcpDiscoverySpi.setSoLinger(int)/ property. Always been. 02.11.2020 20:14, Ilya Kasnacheev пишет: Hello! Is there any option to re-enable linger on SSL sockets? Telling people to re-configure does not help if they can't. Regards,

Re: [DISCUSS] Disable socket linger by default in TCP discovery SPI.

2020-11-02 Thread Ivan Daschinsky
Ilya, yes, there is an option TcpDiscoverySpi#soLinger. The main question is why the default value is true, 5 instead of false,0 пн, 2 нояб. 2020 г., 20:14 Ilya Kasnacheev : > Hello! > > Is there any option to re-enable linger on SSL sockets? > > Telling people to re-configure does not help if

Re: [DISCUSS] Disable socket linger by default in TCP discovery SPI.

2020-11-02 Thread Ilya Kasnacheev
Hello! Is there any option to re-enable linger on SSL sockets? Telling people to re-configure does not help if they can't. Regards, -- Ilya Kasnacheev пт, 30 окт. 2020 г. в 15:21, Anton Vinogradov : > > When TLS 1.3 is introduced, whole sun.security.ssl.SSLSocketImpl was > > rewritten. >

Re: [DISCUSS] Disable socket linger by default in TCP discovery SPI.

2020-10-30 Thread Anton Vinogradov
> When TLS 1.3 is introduced, whole sun.security.ssl.SSLSocketImpl was > rewritten. Correct, I meant rewritten TLSv1.3, the good news that 1.2- also were fixed. so, -- brand new TLS with any linger -- plain old TLS with linger>0 On Fri, Oct 30, 2020 at 3:10 PM Ivan Daschinsky wrote: > Ilya,

Re: [DISCUSS] Disable socket linger by default in TCP discovery SPI.

2020-10-30 Thread Ivan Daschinsky
Ilya, Anton. It means that not if TLS 1.3 is worked ok and with TLS < 1.2 is not ok. When TLS 1.3 is introduced, whole sun.security.ssl.SSLSocketImpl was rewritten. There is not any code anymore that could cause a deadlock. Therefore, in JDK, that supports TLS 1.3, this option is unnecessary,

Re: [DISCUSS] Disable socket linger by default in TCP discovery SPI.

2020-10-30 Thread Anton Vinogradov
Ilya > I think we should still keep setting linger if SSL is enabled Modern (updated) JVMs do not require this. AFAIK, Problem caused this workaround already fixed everywhere, including JDK 8. > If SSL only works with TLSv1.3 and no linger SSL works if -- TLSv1.3 with any linger -- TLSv1.2- with

Re: [DISCUSS] Disable socket linger by default in TCP discovery SPI.

2020-10-30 Thread Ilya Kasnacheev
Hello! I think we should still keep setting linger if SSL is enabled, and not expect user to enable it (or face consequences). If SSL only works with TLSv1.3 and no linger, we should make TLSv1.3 a default. If JVM does not support it, user will have to reconfigure explicitly. Regards, -- Ilya

Re: [DISCUSS] Disable socket linger by default in TCP discovery SPI.

2020-10-30 Thread Ivan Daschinsky
Hi! Vova, I agree with you, this default behaviour is quite confusing. Even if we want to workaround bug for old jdk's and SSL, it's strange idea to affect all other users by default. I think that we should add section in documentation how to workaround this issue, and disable socket linger on

[DISCUSS] Disable socket linger by default in TCP discovery SPI.

2020-10-30 Thread Steshin Vladimir
* Hi, Igniters. We’ve found that enabled by default socket linger causes unexpected delay in detection of node failure. Moreover, long closing of socket works as Thread.sleep() within algorithms of failure detection and connection recovery in TCP discovery. These time gaps lead to hardly