Re: [DISCUSSION] Cache warmup

2020-08-10 Thread ткаленко кирилл
Great! Then I proceed to ticket https://issues.apache.org/jira/browse/IGNITE-13345. 10.08.2020, 16:30, "Stanislav Lukyanov" : > All of this looks awesome, covers the use cases I know about. > Thanks! > > Stan > >>  On 10 Aug 2020, at 15:39, ткаленко кирилл wrote: >> >>  Hi, Stan again :-) >> >>

Re: [DISCUSSION] Cache warmup

2020-08-10 Thread Stanislav Lukyanov
All of this looks awesome, covers the use cases I know about. Thanks! Stan > On 10 Aug 2020, at 15:39, ткаленко кирилл wrote: > > Hi, Stan again :-) > > I suggest adding a little more flexibility to configuration: > 1)Add default warm-up configuration for all regions into >

Re: [DISCUSSION] Cache warmup

2020-08-10 Thread ткаленко кирилл
Hi, Stan again :-) I suggest adding a little more flexibility to configuration: 1)Add default warm-up configuration for all regions into org.apache.ignite.configuration.DataStorageConfiguration#setDefaultWarmUpConfiguration 2)Add a NoOp strategy for turning off heating of a specific region

Re: [DISCUSSION] Cache warmup

2020-08-10 Thread ткаленко кирилл
Hi, Stan! As a result of personal correspondence I realized that you are right about making changes: 1)Move warm-up configuration to org.apache.ignite.configuration.DataRegionConfiguration#setWarmUpConfiguration; 2)Start warming up for each region sequentially; 3)Improving warm-up interface:

Re: [DISCUSSION] Cache warmup

2020-08-07 Thread ткаленко кирилл
Hi, Stan! Yes, that's right. > On the interface structure. > So, as a user I'll see one interface, WarmUpConfiguration, with no methods. > I choose an implementation and configure it like > cfg.setWarmUpConfiguration(new LoadEverythingWarmupConfiguration()); > Ignite tries to map the

Re: [DISCUSSION] Cache warmup

2020-08-06 Thread Stanislav Lukyanov
Hi Kirill, Alexey, On the interface structure. So, as a user I'll see one interface, WarmUpConfiguration, with no methods. I choose an implementation and configure it like cfg.setWarmUpConfiguration(new LoadEverythingWarmupConfiguration()); Ignite tries to map the

Re: [DISCUSSION] Cache warmup

2020-08-06 Thread ткаленко кирилл
Hello, Alexey! Your comments are fair. 05.08.2020, 15:51, "Alexey Goncharuk" : > Kirill, > > Thank you for driving this discussion and implementation. > > A few points from my side: > * Agree that it will be best to keep the strategy interface private because > it will be very dependent on the

Re: [DISCUSSION] Cache warmup

2020-08-05 Thread Alexey Goncharuk
Kirill, Thank you for driving this discussion and implementation. A few points from my side: * Agree that it will be best to keep the strategy interface private because it will be very dependent on the persistent storage implementation. We would need to expose page IDs and types to public API,

Re: [DISCUSSION] Cache warmup

2020-08-05 Thread ткаленко кирилл
t; at all, > and "load indexes" will be a significant improvement to no warmup at all. [1] - http://apache-ignite-developers.2346864.n4.nabble.com/DISCUSSION-Cache-warmup-td48582.html#a48649 04.08.2020, 23:22, "Stanislav Lukyanov" : > Kirill, > > Thanks for

Re: [DISCUSSION] Cache warmup

2020-08-04 Thread Stanislav Lukyanov
gt; > I'm afraid that if we make it cache-based, the implementation won't be >>> that >>> > obvious. We already have an API for warmup that appeared to be pretty >>> much >>> > impossible to apply in a useful way: >>> > >

Re: [DISCUSSION] Cache warmup

2020-08-04 Thread ткаленко кирилл
iteCache.html#preloadPartition-int- >>  > Let's make sure that our new tool for warming up is actually useful. >>  > >>  > Denis >>  > >>  > вт, 28 июл. 2020 г. в 09:17, Zhenya Stanilovsky >>  >  >> : >>  > >>  >> L

Re: [DISCUSSION] Cache warmup

2020-08-04 Thread Denis Mekhanikov
gt; Let's make sure that our new tool for warming up is actually useful. > > > > Denis > > > > вт, 28 июл. 2020 г. в 09:17, Zhenya Stanilovsky > >> : > > > >> Looks like we need additional func for static caches, for > >> example: warmup(

Re: [DISCUSSION] Cache warmup

2020-08-04 Thread ткаленко кирилл
--- >>  >From: "Вячеслав Коптилин" < slava.kopti...@gmail.com > >>  >To: dev@ignite.apache.org >>  >Cc: >>  >Subject: Re: [DISCUSSION] Cache warmup >>  >Date: Mon, 27 Jul 2020 16:47:48 +0300 >>  > >>  >Hello Kirill, &g

Re: [DISCUSSION] Cache warmup

2020-08-04 Thread ткаленко кирилл
t;> From: "Вячеслав Коптилин" < slava.kopti...@gmail.com > >> To: dev@ignite.apache.org >> Cc: >> Subject: Re: [DISCUSSION] Cache warmup >> Date: Mon, 27 Jul 2020 16:47:48 +0300 >> >> Hello Kirill, >> >> Thanks a lot for driving this

Re: [DISCUSSION] Cache warmup

2020-08-04 Thread ткаленко кирилл
Hi, Slava! Thank you for looking at the offer and making fair comments. I personally discussed with Anton and Alexey because they are author and sponsor of "IEP-40" and we found out that point 2 in it is no longer relevant and it can be removed. I suggest implementing point 3, since it may

Re: [DISCUSSION] Cache warmup

2020-07-28 Thread Denis Mekhanikov
; spring too. > > > > >--- Forwarded message --- > >From: "Вячеслав Коптилин" < slava.kopti...@gmail.com > > >To: dev@ignite.apache.org > >Cc: > >Subject: Re: [DISCUSSION] Cache warmup > >Date: Mon, 27 Jul 2020 16:47:48 +0300 &g

Re: [DISCUSSION] Cache warmup

2020-07-28 Thread Zhenya Stanilovsky
Looks like we need additional func for static caches, for example:  warmup(List cconf) it would be helpful for spring too.   > >--- Forwarded message --- >From: "Вячеслав Коптилин" < slava.kopti...@gmail.com > >To: dev@ignite.apache.org >Cc: >Subject: R

Re: [DISCUSSION] Cache warmup

2020-07-27 Thread Вячеслав Коптилин
Hello Kirill, Thanks a lot for driving this activity. If I am not mistaken, this discussion relates to IEP-40. > I suggest adding a warmup phase after recovery here [1] after [2], before discovery. This means that the user's thread, which starts Ignite via Ignition.start(), will wait for ana

[DISCUSSION] Cache warmup

2020-07-27 Thread ткаленко кирилл
Now, after restarting node, we have only cold caches, which at first requests to them will gradually load data from disks, which can slow down first calls to them. If node has more RAM than data on disk, then they can be loaded at start "warmup", thereby solving the issue of slowdowns during