Re: [DISCUSSION] Code style for Ignite 3

2021-08-25 Thread Valentin Kulichenko
Created tickets for the migration: - https://issues.apache.org/jira/browse/IGNITE-15370 - https://issues.apache.org/jira/browse/IGNITE-15371 -Val On Fri, Aug 20, 2021 at 7:23 AM Pavel Tupitsyn wrote: > +1, as long as 100% of the rules are checked automatically. > > On Fri, Aug 20, 2021 at 4:00

Re: [DISCUSSION] Code style for Ignite 3

2021-08-20 Thread Pavel Tupitsyn
+1, as long as 100% of the rules are checked automatically. On Fri, Aug 20, 2021 at 4:00 PM Andrey Gura wrote: > Looks good to me. But Idea configuration for style check is not > enough. It helps developers but does not automate style checking. > > Checkstyle project provides ready to use config

Re: [DISCUSSION] Code style for Ignite 3

2021-08-20 Thread Andrey Gura
Looks good to me. But Idea configuration for style check is not enough. It helps developers but does not automate style checking. Checkstyle project provides ready to use config based on Google Code Style [1]. I hope it matches well with Idea config and we'll avoid any confusing incidents. Let's

Re: [DISCUSSION] Code style for Ignite 3

2021-08-20 Thread Alexei Scherbakov
+1 пт, 20 авг. 2021 г. в 10:54, Alexander Polovtcev : > Hi, Val. This is an extremely welcome change, thank you! > > On Fri, Aug 20, 2021 at 12:17 AM Valentin Kulichenko < > valentin.kuliche...@gmail.com> wrote: > > > Igniters, > > > > I would like to discuss a potential change to the coding guid

Re: [DISCUSSION] Code style for Ignite 3

2021-08-20 Thread Alexander Polovtcev
Hi, Val. This is an extremely welcome change, thank you! On Fri, Aug 20, 2021 at 12:17 AM Valentin Kulichenko < valentin.kuliche...@gmail.com> wrote: > Igniters, > > I would like to discuss a potential change to the coding guidelines for > Ignite 3. Currently, we're using the existing guidelines

[DISCUSSION] Code style for Ignite 3

2021-08-19 Thread Valentin Kulichenko
Igniters, I would like to discuss a potential change to the coding guidelines for Ignite 3. Currently, we're using the existing guidelines inherited from Ignite 2, which are described here: https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines Current guidelines, however, exist for