Re: Re[4]: [DISCUSSION] Fail on non-colocated join

2021-02-03 Thread Ilya Kasnacheev
Hello! I don't think this is absolutely needed. From my userlist experience I don't get particularly many questions about distributed joins. They are, but it's not a hot topic, which is somewhat surprising to me actually. I would expect more people struggling with them. To tell people about erron

Re[4]: [DISCUSSION] Fail on non-colocated join

2021-02-03 Thread Zhenya Stanilovsky
I think it`s « absolutely needed » case ) Many people will find erroneous places.   >Hello! > >Many people do read logs, especially developers. You would be amazed how >many people come to discuss even the most benign of warnings. > >I think it violates the Apache Ignite compatibility policy,

Re: Re[2]: [DISCUSSION] Fail on non-colocated join

2021-02-03 Thread Ilya Kasnacheev
Hello! Many people do read logs, especially developers. You would be amazed how many people come to discuss even the most benign of warnings. I think it violates the Apache Ignite compatibility policy, where we do not break existing code during a major release. We do not always hold on to that p

Re[2]: [DISCUSSION] Fail on non-colocated join

2021-02-03 Thread Zhenya Stanilovsky
  >If it breaks existing working code it may not be done that way.   Who reads the logs ?  Is it violates apache way approach or some existing rules ?   thanks !     >Regards, >-- >Ilya Kasnacheev > > >ср, 3 февр. 2021 г. в 09:05, Zhenya Stanilovsky < arzamas...@mail.ru.invalid >>: > >> >> >>

Re: [DISCUSSION] Fail on non-colocated join

2021-02-03 Thread Ilya Kasnacheev
Hello! I think that we should issue a developer warning with LT.warn. I don't think we should raise an exception. Our code may not have enough information. For example, it is possible that the data is collocated via constraint observed by user, such as, ina table of key (id, affKey) there is join

Re: [DISCUSSION] Fail on non-colocated join

2021-02-02 Thread Zhenya Stanilovsky
Maxim it`s cool that it`s moved :) +1 for exception, but take into account such use case : T1 (country, city)  affinity_key=country  and T2 (country,city)  affinity_key=country join with «city» usage — will be correct here (i hope, need to recheck of course) thus seems you must give some flag\h

Re: [DISCUSSION] Fail on non-colocated join

2021-02-02 Thread Valentin Kulichenko
I think it should be the first option - just throw a clear exception if a query with a non-colocated join is executed without the flag set. Explicitly turning this mode on seems wrong, because in most cases this is not what a user intends to do. We also should make sure to run performance tests. A

[DISCUSSION] Fail on non-colocated join

2021-02-02 Thread Max Timonin
Hi, Igniters! Last week I investigated a bug [1]. It's about an incorrect result for non-colocated joins. For such joins it's required to set up the "distributedJoin" flag, or try to make joined tables colocated. It is covered in docs [2]. But it's not obvious and some users don't read that or for