Re: [DISCUSSION] Patch completely breaks MVCC.

2021-03-26 Thread Maksim Timonin
Folks, I ran some tests and got a Segmentation Fault without pretty explanation. It's not actually that user happy to get. Even if there was a warning in the release notes. So, I think we should follow the idea of a check for indexes (and cache) on Ignite start. And looks like designing and

Re: [DISCUSSION] Patch completely breaks MVCC.

2021-03-25 Thread Maxim Muzafarov
Andrey, > * Ignite shouldn't start if existed persistence has the MVCC index (cache) > and maybe other internal persistent MVCC structures. > * Even if the user dropped all MVCC indices/caches before the upgrade, > probably there can be an incomplete checkpoint and there are WAL records >

Re: [DISCUSSION] Patch completely breaks MVCC.

2021-03-25 Thread Maxim Muzafarov
Folks, I see no reason to postpone this patch. I think we can proceed with this patch with the commitment to remove MVCC from the public API until the next release (2.11). These changes for sure must be well-documented but for the 2.10 release, we already have in the release notes [1] warnings

Re: [DISCUSSION] Patch completely breaks MVCC.

2021-03-25 Thread Maksim Timonin
I've moved indexes from the indexing module to the core module, but I did not move H2Mvcc*IO classes that are responsible for storing MVCC data in indexes. Also for other indexes code I've skipped some blocks with if-condition that checks if cache is MVCC or not. Actually, there isn't so much

Re: [DISCUSSION] Patch completely breaks MVCC.

2021-03-25 Thread Alexei Scherbakov
Maksim, It seems to me from the description "Patch completely breaks MVCC" the proposed patch should be postponed until at least the public API for MVCC will be removed. Or can you clarify the impact of the patch ? Does the existing MVCC functionality will remain unbroken ? чт, 25 мар. 2021 г.

Re: [DISCUSSION] Patch completely breaks MVCC.

2021-03-25 Thread Andrey Mashenkov
Hi Maksim, Do you mean MVCC will not work at all or MVCC will not support indices after your changes? Anyway, this looks like a major change and may be too harmful for the minor version (10.1). Before break MVCC index (or MVCC mode) we should force the user first to drop all MVCC indices (or

Re: [DISCUSSION] Patch completely breaks MVCC.

2021-03-25 Thread Maksim Timonin
Hi, Igniters! the MVCC feature marked as IgniteExperimental and this annotation is more weaker than deprecated. So we can remove this functionality in any moment. So I propose: 1. Now I leave all affected tests marked as ignored. 2. Create a ticket for removing TRANSACTIONAL_SNAPSHOT from

[DISCUSSION] Patch completely breaks MVCC.

2021-03-15 Thread Maksim Timonin
Hi, Igniters! I'm working on a feature (moving indexes to the core module) and skip specific implementation for MVCC as it is considered deprecated (the vote result [1]). Am I right that now there is no need to support MVCC? Then there are a lot of tests (both Java, C++) that fail because they