Andrey,
I see the following options for PR checks (without intention to merge it):
1. Disable the checkstyle plugin in pom.xml or remove all rules from
checkstyle.xml (for PR branch).
2.
- import checkstyle.xml cofiguration to IntilliJ IDEA inspections
(Preferences > Editor > Inspections)
- be
Andrey,
I see the following options for PR checks (without intention to merge it):
1.
On Mon, 8 Jun 2020 at 17:59, Andrey Mashenkov
wrote:
>
> HI,
>
> > Why do you want to run a reproducer from the user list on the TC?
> It may be useful to verify a race that can't be reproduced locally on my
HI,
> Why do you want to run a reproducer from the user list on the TC?
It may be useful to verify a race that can't be reproduced locally on my NB
due to some performance reasons.
> If all code style rules are good then we should use them in daily coding,
isn’t it?
Yes, also we do not force
Hello, Andrey.
Sorry, I still don’t understand your use-case.
Can you, please, use correct quoting so I can parse your message? :)
Why do you want to run a reproducer from the user list on the TC?
> There is no specific rule.
If all code style rules are good then we should use them in daily
Hi Niolay,
Why do you ignore code style rules while developing «quick reproducer»?
I don't think it worth effor to fix a user code (e.g. from userlist) just
to validate some race condition.
There is no specific rule.
I'm sad we have no ability to run user code without using any hacks to skip
Hello, Andrey.
> I've just found that I should waste my time fixing styles in user code that
> (may be) reproduce some bug, just to validate the bug or fix provided by the
> user.
Why do you ignore code style rules while developing «quick reproducer»?
What specific code style rule is an issue
Konstantin,
+1
I've just found that I should waste my time fixing styles in user code that
(may be) reproduce some bug, just to validate the bug or fix provided by
the user.
I'm ok with the idea to block commits with style errors to master branch,
but not for other branches\PR.
Can anybody
Hi Ivan,
Thanks for your reply! It’s better to get an answer late than never :)
--
Regards,
Konstantin Orlov
> On 18 May 2020, at 09:04, Ivan Pavlukhin wrote:
>
> Hi Konstantin,
>
> Surprisingly, I found your message in a Spam folder (gmail).
>
> We had discussions about the subject
Hi Konstantin,
Surprisingly, I found your message in a Spam folder (gmail).
We had discussions about the subject before. The most recent one and
reflecting a current state is [1]. You can find many thoughts and
arguments in another discussion [2] (it might be better to start
reading from a
Igniters,
Currently we have code sanity checks [1][2] integrated within a build task [3].
Do we really need to fail the build (and therefore the other tasks) if there is
a minor flaw like a missing line at the end of a file or an unused import? As
for me it could be separated from the build
10 matches
Mail list logo
