Baseline auto-adjust`s discuss

2019-01-24 Thread Anton Kalashnikov
Hello, Igniters! Work on the Phase II of IEP-4 (Baseline topology) [1] has started. I want to start to discuss of implementation of "Baseline auto-adjust" [2]. "Baseline auto-adjust" feature implements mechanism of auto-adjust baseline corresponding to current topology after event join/left w

Re: Baseline auto-adjust`s discuss

2019-01-24 Thread Vladimir Ozerov
Hi Anton, This is great feature, but I am a bit confused about automatic disabling of a feature during manual baseline adjustment. This may lead to unpleasant situations when a user enabled auto-adjustment, then re-adjusted it manually somehow (e.g. from some previously created script) so that aut

Re: Baseline auto-adjust`s discuss

2019-01-25 Thread Anton Kalashnikov
Vladimir, thanks for your notes, both of them looks good enough but I have two different thoughts about it. I think I agree about enabling only one of manual/auto adjustment. It is easier than current solution and in fact as extra feature we can allow user to force task to execute(if they do

Re: Baseline auto-adjust`s discuss

2019-01-25 Thread Vladimir Ozerov
Got it, makes sense. On Fri, Jan 25, 2019 at 11:06 AM Anton Kalashnikov wrote: > Vladimir, thanks for your notes, both of them looks good enough but I > have two different thoughts about it. > > I think I agree about enabling only one of manual/auto adjustment. It is > easier than current solut

Re: Baseline auto-adjust`s discuss

2019-01-25 Thread Sergey Chugunov
Anton, As I understand from the IEP document policy was supposed to support two timeouts: soft and hard, so here you're proposing a bit simpler functionality. Just to clarify, do I understand correctly that this feature when enabled will auto-adjust blt on each node join/node left event, and time

Re: Baseline auto-adjust`s discuss

2019-01-25 Thread Anton Kalashnikov
Initially, hard timeout should protect grid from constantly changing topology(constantly blinking node). But in fact if we have constantly changing topology, baseline adjust operation is failed in most cases. As result hard timeout only added complexity but it don't give any new guarantee. So I

Re: Baseline auto-adjust`s discuss

2019-01-28 Thread Павлухин Иван
Anton, Great feature! Could you please clarify a bit about implementation details? As I understood auto-adjust properties is meant to be consistent across the cluster. And baseline adjustment is put into some delay queue. Do we put event into a queue on each node? Or is there some dedicated node

Re: Baseline auto-adjust`s discuss

2019-01-29 Thread Anton Kalashnikov
Ivan, I glad you interested in this feature. Some answers are below. Yes, it is correct about properties it is consistent across the cluster cause it based on distributed metastore(we have other topic for discuss it). Some details of implementation: When event happened we added task to GridTime

Re: Baseline auto-adjust`s discuss

2019-01-30 Thread Павлухин Иван
Anton, Thank you for the clarification! вт, 29 янв. 2019 г. в 15:15, Anton Kalashnikov : > > Ivan, I glad you interested in this feature. Some answers are below. > > Yes, it is correct about properties it is consistent across the cluster cause > it based on distributed metastore(we have other to