Re: Check Ignite code base with Findbugs.

2015-11-30 Thread Dmitriy Setrakyan
On Mon, Nov 30, 2015 at 9:00 AM, Alexey Goncharuk < alexey.goncha...@gmail.com> wrote: > I think this is a great idea, however this exercise only makes sense if > FindBugs profile is plugged to CI and provides continuous checks for the > new code being committed. > … > Hopefully, somebody from the

Re: Check Ignite code base with Findbugs.

2015-11-30 Thread Alexey Goncharuk
I think this is a great idea, however this exercise only makes sense if FindBugs profile is plugged to CI and provides continuous checks for the new code being committed. Since Alexey K. already has some feedback for the first run, I will cooperate with him to create a minimal set of checks that w

Re: Check Ignite code base with Findbugs.

2015-11-25 Thread Alexey Kuznetsov
Cos, that was only ONE module checked :) And who knows what FindBugs will find when I start it over whole project. :) On Thu, Nov 26, 2015 at 9:31 AM, Konstantin Boudnik wrote: > On Tue, Nov 24, 2015 at 10:50AM, Alexey Kuznetsov wrote: > > Igniters, > > > > I've installed FindBugs plugin for Id

Re: Check Ignite code base with Findbugs.

2015-11-25 Thread Konstantin Boudnik
On Tue, Nov 24, 2015 at 10:50AM, Alexey Kuznetsov wrote: > Igniters, > > I've installed FindBugs plugin for Idea and run it on ignite-core module. > > Well it found a lot... 1331 items... Better than 100500, eh? :) > Some of them are false-positive of course, but this plugin has quite handy > g

Re: Check Ignite code base with Findbugs.

2015-11-24 Thread Alexey Kuznetsov
Ok, I will fix trivial issues and prepare report for most suspicious code. On Tue, Nov 24, 2015 at 4:34 PM, Yakov Zhdanov wrote: > Alex, if you have already run this test, can you please share the report > or, even more, fix vivid trivial issues right away and let us review? > > --Yakov > > 2015

Re: Check Ignite code base with Findbugs.

2015-11-24 Thread Yakov Zhdanov
Alex, if you have already run this test, can you please share the report or, even more, fix vivid trivial issues right away and let us review? --Yakov 2015-11-24 6:50 GMT+03:00 Alexey Kuznetsov : > Igniters, > > I've installed FindBugs plugin for Idea and run it on ignite-core module. > > Well i

Re: Check Ignite code base with Findbugs.

2015-11-23 Thread Alexey Kuznetsov
Igniters, I've installed FindBugs plugin for Idea and run it on ignite-core module. Well it found a lot... 1331 items... Some of them are false-positive of course, but this plugin has quite handy grouping and we could only check important groups like "Multithreading". Also FindBugs found a bu

Re: Check Ignite code base with Findbugs.

2015-11-13 Thread Raul Kripalani
On Fri, Nov 13, 2015 at 4:51 PM, Alexey Kuznetsov wrote: > Raul, I'm afraid it will produce 100500 false-positive warnings. > Yep, it's likely. I think we need to investigate what will be generated by FB tune it and > then decide to include it or not into maven build. > Exactly. We should do a

Re: Check Ignite code base with Findbugs.

2015-11-13 Thread Alexey Kuznetsov
Raul, I'm afraid it will produce 100500 false-positive warnings. I think we need to investigate what will be generated by FB tune it and then decide to include it or not into maven build. Or may be we could have it as optional step (it is possible?). On Fri, Nov 13, 2015 at 11:32 PM, Raul Kripal

Re: Check Ignite code base with Findbugs.

2015-11-13 Thread Raul Kripalani
I'd prefer to plug it into the Maven build: https://gleclaire.github.io/findbugs-maven-plugin/. *Raúl Kripalani* PMC & Committer @ Apache Ignite, Apache Camel | Integration, Big Data and Messaging Engineer http://about.me/raulkripalani | http://www.linkedin.com/in/raulkripalani http://blog.raulkr.

Re: Check Ignite code base with Findbugs.

2015-11-13 Thread Sergi Vladykin
It absolutely does make sense. Of course it will not find complex bugs but it is pretty good at spotting stupid mistakes. Time ago I used to run Eclipse plugin for FindBugs, I believe something alike should exist for Idea as well. Sergi 2015-11-13 17:49 GMT+03:00 Alexey Kuznetsov : > Igniters,

Check Ignite code base with Findbugs.

2015-11-13 Thread Alexey Kuznetsov
Igniters, What do you think about checking Ignite code base with Findbugs ( http://findbugs.sourceforge.net)? Does it make sense? Maybe someone will try? Thoughts? -- Alexey Kuznetsov