Re: Consistent ID specification from previous random UUID

2019-03-18 Thread Павлухин Иван
Hi Dmitriy, Quick start for a new user is a perfect concern. I thought about it as well. I and would like to outline that I am completely ok with an approach in your patch. пн, 18 мар. 2019 г. в 16:16, Dmitriy Pavlov : > > Hi Ivan, > > reasonable points, but we had a long and hot discussion about

Re: Consistent ID specification from previous random UUID

2019-03-18 Thread Dmitriy Pavlov
Hi Ivan, reasonable points, but we had a long and hot discussion about this logic. Reason for selecting auto-generation was users that just try to use Apache Ignite with native persistence for the first time. They must be able to test features without any extensive setup, but before go-live we ex

Re: Consistent ID specification from previous random UUID

2019-03-17 Thread Павлухин Иван
Hi Dmitriy, It is a pitty that we have to guess here. Some comments: 1. The usage scenario is not very complex and erything might work well with aforementioned patch. Unfortunately some tradeoff and extra transformations are involved and consequently it is hard to predict how many users will be tr

Re: Consistent ID specification from previous random UUID

2019-03-15 Thread Dmitriy Pavlov
Hi Ivan, yes, after the restart we need to re-use both folder name and UUID as consistent ID. About returning exact directory name: I'm just guessing here, but the persistent store is not the only folder, there are several more folders, e.g. binary-meta, etc. About several nodes reusing same root

Re: Consistent ID specification from previous random UUID

2019-03-15 Thread Павлухин Иван
Hi Dmitriy, It looks like that case with only one node in working directory is covered. But what is problem is solved? As I understand before fix in such case node after restart uses proper folder and proper consistentId. After fix we can specify automatically generated UUID in configuration and e

Re: Consistent ID specification from previous random UUID

2019-03-14 Thread Dmitriy Pavlov
Hi, I've prepared demo PR for approach 1, just checking UUID and trying to use node00-UUID. https://github.com/apache/ignite/pull/6266/ Actually for this approach it is really simple, no API change is required. I guess the case is not very often because automatic folders assignment works well in m

Re: Consistent ID specification from previous random UUID

2019-03-12 Thread Павлухин Иван
Alex, Why do we need > - check if consistent ID is set to a string 'nodeXX-UUID'. In this case > the consistent ID is set to UUID, and the storage folder is chosen > according to the proper rules. This change has a minimal chance to affect > current users because it's unlikely that somebody is us

Re: Consistent ID specification from previous random UUID

2019-03-12 Thread Alexey Goncharuk
Igniters, I came across the same issue during development and found no sane workaround for this issue. I believe the solution should be as simple as possible because we are already adding a warning to let users know that it is good to specify a consistent ID in production deployments. As for the

Re: Consistent ID specification from previous random UUID

2019-03-12 Thread Dmitriy Pavlov
Hi Igniters, A full description can be found at wiki page https://cwiki.apache.org/confluence/display/IGNITE/Ignite+Persistent+Store+-+under+the+hood#IgnitePersistentStore-underthehood-SubfoldersGeneration I like the idea of introducing a property like nodeStorageName to specify exactly name of a

Re: Consistent ID specification from previous random UUID

2019-03-01 Thread Павлухин Иван
Dmitriy, You wrote > we need an order to scan and lock random-UUID based folders. It would be great if you provide a discussion about that order to complete the picture. Currently I cannot understand why the order is important. Also, couple of raw thoughts: 1. Can we extend a directory lookup pr

Consistent ID specification from previous random UUID

2019-02-28 Thread Dmitriy Pavlov
Hi Ivan, Yes, you catch me, I'm a little bit cheating with lazy consensus on code modification without providing a PR because I was expecting that nobody comes to discussion. I will prepare PR shortly. And since we anyway have a discussion, I will not apply anything by lazy approval. - storageNod

RE: Consistent ID specification from previous random UUID

2019-02-28 Thread Stanislav Lukyanov
, Stan From: Павлухин Иван Sent: 28 февраля 2019 г. 8:03 To: dev@ignite.apache.org Subject: Re: Consistent ID specification from previous random UUID Dmitiy, Could please clarify one thing: 1. Will it be enough to use only storageNodeIndex in order to reuse the same persistence folders when

Re: Consistent ID specification from previous random UUID

2019-02-27 Thread Павлухин Иван
Dmitiy, Could please clarify one thing: 1. Will it be enough to use only storageNodeIndex in order to reuse the same persistence folders when consistentId is auto-generated? E.g. I have a configuration with storageNodeIndex=1 and without explicitly specified consistentId, will the node after resta

Consistent ID specification from previous random UUID

2019-02-27 Thread Dmitriy Pavlov
Hi Igniters, I would like to fix the issue https://issues.apache.org/jira/browse/IGNITE-11432 about specifying some previous randomly generated UUID as a new consistent ID. Folder generation algorithm here ( https://cwiki.apache.org/confluence/display/IGNITE/Ignite+Persistent+Store+-+under+the+hoo