Re: Converting TreeMap to BinaryObject causes ClassCastException (IGNITE-2852)

2016-08-05 Thread Valentin Kulichenko
Hi Jens, The main purpose of binary format is to avoid deploying any classes on server nodes, but with your approach you will need to deploy the comparator class. You will also not be able to dynamically change this. All, This issue becomes more and more critical as more users face with it in di

Re: Converting TreeMap to BinaryObject causes ClassCastException (IGNITE-2852)

2016-08-05 Thread NoTrueScotsman
A new TreeMap gets created when toBinary() is called, and keys as well as values are converted to binary objects and added to it. This fails with a CCE because binary objects are not comparable (so the comparison logic for the keys is lost after conversion). Not sure whether there are discussions

Re: Converting TreeMap to BinaryObject causes ClassCastException (IGNITE-2852)

2016-07-21 Thread Dmitriy Setrakyan
Well, in my view we should have that discussion or close this ticket. What are the challenges there? Is there a dev thread I can review? On Thu, Jul 21, 2016 at 5:41 AM, Denis Magda wrote: > Dmitriy, > > Presently even the guys who spent bunch the time developing and improving > binary marshalle

Re: Converting TreeMap to BinaryObject causes ClassCastException (IGNITE-2852)

2016-07-21 Thread Denis Magda
Dmitriy, Presently even the guys who spent bunch the time developing and improving binary marshaller don’t have a view on how to implement this feature. So initially we should discuss how to implement it in general and after that decide if the ticket can be taken over by new contributors. — De

Re: Converting TreeMap to BinaryObject causes ClassCastException (IGNITE-2852)

2016-07-21 Thread Dmitriy Setrakyan
On Wed, Jul 20, 2016 at 2:45 PM, Denis Magda wrote: > Hi Jens, > > This is not the best candidate for the first contribution and presently I > don’t think that this feature should be supported at all. > Denis, why not? > > I would recommend you picking up one of the tickets with “newbie” filte

Re: Converting TreeMap to BinaryObject causes ClassCastException (IGNITE-2852)

2016-07-20 Thread NoTrueScotsman
Hi Denis, thanks for clarifying. I'll take a look around Jira instead. Thanks Jens On Wed, Jul 20, 2016 at 1:45 PM, Denis Magda wrote: > Hi Jens, > > This is not the best candidate for the first contribution and presently I > don’t think that this feature should be supported at all. > > I woul

Re: Converting TreeMap to BinaryObject causes ClassCastException (IGNITE-2852)

2016-07-20 Thread Denis Magda
Hi Jens, This is not the best candidate for the first contribution and presently I don’t think that this feature should be supported at all. I would recommend you picking up one of the tickets with “newbie” filter. https://issues.apache.org/jira/issues/?filter=12338037

Converting TreeMap to BinaryObject causes ClassCastException (IGNITE-2852)

2016-07-19 Thread NoTrueScotsman
It happens when applying ignite.binary().toBinary(m) to a TreeMap with a custom key K. I thought this would be a nice task to pick as a first (attempt of a) contribution, however there is a ticket for this already assigned to someone: https://issues.apache.org/jira/browse/IGNITE-2852 I haven't se