Re: IGNITE-4374 - Ignite should validate JVM and OS configuration and output warning in log

Thanks, reviewed. — Denis > On Feb 7, 2017, at 3:58 AM, Vyacheslav Daradur wrote: > > Hi, I changed the output. > > Please, review it again) > > If something is bad, I will quickly correct. > > Thanks. > > 2017-01-25 18:24 GMT+03:00 Vyacheslav Daradur

Re: IGNITE-4374 - Ignite should validate JVM and OS configuration and output warning in log

Hi, I changed the output. Please, review it again) If something is bad, I will quickly correct. Thanks. 2017-01-25 18:24 GMT+03:00 Vyacheslav Daradur : > GridPerformanceSuggestions isn't changed. > > JVM checks are encapsulated in JvmConfigurationSuggestions > OS checks

Re: IGNITE-4374 - Ignite should validate JVM and OS configuration and output warning in log

Yakov, I have looked at source codes and I agree with you. Let's rename GridPerformanceSuggestions to ConfigurationSuggestions and to add new checks to suggestOptimizations method in IgniteKernal or separate method. 2016-12-27 14:51 GMT+03:00 Vyacheslav Daradur : > I mean

Re: IGNITE-4374 - Ignite should validate JVM and OS configuration and output warning in log

I mean ConfigurationValidator as another class, not GridPerformanceSuggestion. And invoke it from IgniteKernal. 2016-12-27 14:46 GMT+03:00 Vyacheslav Daradur : > >> > 3. I think this should be a new section in performance suggestion output. > And I think the

Re: IGNITE-4374 - Ignite should validate JVM and OS configuration and output warning in log

>> 3. I think this should be a new section in performance suggestion output. And I think the GridPerformanceSuggestions should be used, but it should be probably renamed to reflect its new role and remove Grid prefix also. How about ConfigurationSuggestions? >> How about: public class

Re: IGNITE-4374 - Ignite should validate JVM and OS configuration and output warning in log

Vyacheslav, my comments are below. >> 1. It is necessary to check a flag MaxDirectMemorySize, but there is no recommendation of it: https://apacheignite.readme.io/docs/jvm-and-system-tuning 2. Whether it is necessary to output message in "Quiet mode"? 3. Where it is better to output information

[jira] [Created] (IGNITE-4374) Ignite should validate JVM and OS configuration and output warning in log

Yakov Zhdanov created IGNITE-4374: - Summary: Ignite should validate JVM and OS configuration and output warning in log Key: IGNITE-4374 URL: https://issues.apache.org/jira/browse/IGNITE-4374 Project: