Fwd: IGNITE - 4760 ready for review

10:45 GMT+03:00 Subject: Re: IGNITE - 4760 ready for review To: Semyon Boikov <sboi...@gridgain.com> Cc: dev@ignite.apache.org, Valentin Kulichenko < valentin.kuliche...@gmail.com> Hi Semyon! I added tests for ReadWrite and NonStrictReadWrite strategy. Also I couldn't find how to get

Re: IGNITE - 4760 ready for review

Hi Semyon! I added tests for ReadWrite and NonStrictReadWrite strategy. Also I couldn't find how to get information about access type for created region and added overload method threadLocalForCache() without param for ReadWrite Strategy case in createAccessStrategy. Is it right ?

Re: IGNITE - 4760 ready for review

Semyon, thanks for comments. - I will change access type for created region. - USE_STRUCTURED_CACHE property needs to store data in cache in a more readable format. Without it I cant cast data from cache to String and HashMap. - I will add the same test for READ_WRITE access strategy. - I will

Re: IGNITE - 4760 ready for review

Hi Vadim, I added comments in JIRA. I'll apply the same fix for hibernate5 when fix is finalized. Thanks! On Thu, Apr 13, 2017 at 12:10 PM, Вадим Опольский wrote: > Hi, guys! > > Semyon, have you had a time to review IGNITE-4760 >

Re: IGNITE - 4760 ready for review

Hi, guys! Semyon, have you had a time to review IGNITE-4760 https://github.com/apache/ignite/pull/1768 ? Is this fix actual for hibernate5 module? Vadim Opolski 2017-04-11 13:40 GMT+03:00 Semyon Boikov : > Thanks Vadim, I'll try to do review today. > > Semyon > > On Mon,

IGNITE - 4760 ready for review

Hello guys! Semyon, review please again. Test check corresponding IgniteCaches contain expected number of entries. Test fails for HibernateNonStrictAccessStrategy. And per-cache thread local in method threadLocalForCache fix this issue. https://github.com/apache/ignite/pull/1768/files Vadim