Re: Ignite commits atomicity & GG tickets

2019-08-08 Thread Dmitriy Pavlov
Ok, thank you. I forgot to mention atomicity. I discourage contributors from so-called bulk commits when several unrelated changes are merged into one commit. In case of any issues, it is not possible to find out reasons why it was changed, it is not possible to easily revert. чт, 8 авг. 2019 г.

Re: Ignite commits atomicity & GG tickets

2019-08-08 Thread Denis Magda
> > Do you find the presence of GG's tickets in the commit is a reason for > revert? No, GG employees just need to follow "commit messages" guidelines removing GG-specific details from the messages. - Denis On Thu, Aug 8, 2019 at 1:52 PM Dmitriy Pavlov wrote: > Hi Igniters, > > I little bi

Ignite commits atomicity & GG tickets

2019-08-08 Thread Dmitriy Pavlov
Hi Igniters, I little bit upset because I sometimes find GG tickets mentioned in Ignite source code as a reason for Ignoring tests, todos, etc. I am personally grateful to all GG's employes for contributing to Ignite code base. I just want to some accuracy for commits provided to Ignite communit