Re: Ignite extensions - ignite-spring-data release.

2020-11-20 Thread Saikat Maitra
Hi Mikhail, Since spring-data-commons is common module and used internally we should be ok to not rename it to spring-data-commons-ext. Thank you for clarifying. Regards, Saikat On Thu, Nov 19, 2020 at 5:02 AM Mikhail Petrov wrote: > Petr, > > The purpose of the spring-data-commons modules

Re: Ignite extensions - ignite-spring-data release.

2020-11-19 Thread Mikhail Petrov
Petr, The purpose of the spring-data-commons modules is to store the general classes needed by spring-data extensions to avoid redundant code duplication between different version of Spring Data integration. I don't think it can be reused outside the "extensions" scope. Why can't it be

Re: Ignite extensions - ignite-spring-data release.

2020-11-19 Thread Petr Ivanov
If it is not an extensions, so why do we put it to ignite-extensions repository? Do we need additional separate ignite-utilities repository for modules like spring-data-commons? > On 19 Nov 2020, at 12:08, Mikhail Petrov wrote: > > Saikat, > > spring-data-commons is a utility Ignite module

Re: Ignite extensions - ignite-spring-data release.

2020-11-19 Thread Mikhail Petrov
Saikat, spring-data-commons is a utility Ignite module that does not provide integration with anything and is only needed to store Spring Data version-independent classes for "spring-data" modules. So, spring-data-commons is not an "extension". Should we rename it in this case? Regards,

Re: Ignite extensions - ignite-spring-data release.

2020-11-19 Thread Alexey Goncharuk
I support having a single vote for all the extensions. Mikhail, do you mind releasing the rest of the modules together with spring-boot? If you do, I can take care of them but looks like this will be a separate vote, though. чт, 19 нояб. 2020 г. в 10:55, Petr Ivanov : > No 11 separate votes, but

Re: Ignite extensions - ignite-spring-data release.

2020-11-18 Thread Petr Ivanov
No 11 separate votes, but 11 separate tags is all I am proposing :) > On 19 Nov 2020, at 10:33, Denis Magda wrote: > > 11+ separate votes is an overkill. We certainly want, and agreed, to be > able to release each extension separately. But I see nothing wrong if > releases of N extensions are

Re: Ignite extensions - ignite-spring-data release.

2020-11-18 Thread Nikolay Izhikov
Hello. I think it’s up to the release manager to decide what extension he(or she) wants to release. Do we have a release manager who wants to release all extensions? > 19 нояб. 2020 г., в 10:33, Denis Magda написал(а): > > 11+ separate votes is an overkill. We certainly want, and agreed, to

Re: Ignite extensions - ignite-spring-data release.

2020-11-18 Thread Denis Magda
11+ separate votes is an overkill. We certainly want, and agreed, to be able to release each extension separately. But I see nothing wrong if releases of N extensions are passed through a single vote. On Wednesday, November 18, 2020, Petr Ivanov wrote: > I would object against all together

Re: Ignite extensions - ignite-spring-data release.

2020-11-18 Thread Petr Ivanov
I would object against all together release of these modules if this process will be done in single release branch / tag. Despite of the fact that all these extensions are in single repository, we have to treat them as separate projects with separate release cycle and release each one of them

Re: Ignite extensions - ignite-spring-data release.

2020-11-18 Thread Saikat Maitra
Hi, Mikhail, Can we please rename ignite-spring-data-commons to ignite-spring-data-commons-ext? Denis, We are good to release the following migrated modules as well... ignite-flink-ext ignite-flume-ext ignite-pub-sub-ext ignite-zeromq-ext ignite-twitter-ext ignite-rocketmq-ext ignite-mqtt-ext

Re: Ignite extensions - ignite-spring-data release.

2020-11-18 Thread Mikhail Petrov
Denis, I omitted "-ext" for simplicity. Currently, this suffix is present in the name of  all Spring Data integration modules [1], [2], [3]. [1] - https://github.com/apache/ignite-extensions/tree/master/modules/spring-data-2.2-ext [2] -

Re: Ignite extensions - ignite-spring-data release.

2020-11-18 Thread Denis Magda
Are we keeping the original names of theses Spring modules? In separate threads I saw that the names of other extensions end with “ext”. Also, how about making a single release of all the extensions that were migrated from the main Ignite repo. There are many of them waiting for this to happen.

Re: Ignite extensions - ignite-spring-data release.

2020-11-18 Thread Nikolay Izhikov
+1 > 18 нояб. 2020 г., в 14:38, Mikhail Petrov написал(а): > > Hello, Igniters. > > Since the migration of Ignite Spring Data modules to extensions, thin client > support for Spring Data integration was implemented. - [1]. > > To make this feature available for users, I propose to start the

Ignite extensions - ignite-spring-data release.

2020-11-18 Thread Mikhail Petrov
Hello, Igniters. Since the migration of Ignite Spring Data modules to extensions, thin client support for Spring Data integration was implemented. - [1]. To make this feature available for users, I propose to start the release process of the following modules: * ignite-spring-data *