Re: IgniteSet, thin client, and WeakReferenceCloseableIterator

2022-06-27 Thread Pavel Tupitsyn
Thanks for your input, I prefer the AutoCloseable approach too. On Sun, Jun 26, 2022 at 4:45 PM Igor Sapego wrote: > I like the closable iterator approach more as well. The difference in API > is not as critical in my opinion, as we have a lot of differences in thick > and > thin APIs already

Re: IgniteSet, thin client, and WeakReferenceCloseableIterator

2022-06-26 Thread Igor Sapego
I like the closable iterator approach more as well. The difference in API is not as critical in my opinion, as we have a lot of differences in thick and thin APIs already and users would normally seek thin client examples and not just re-use thick client code with thin client. Best Regards, Igor

Re: IgniteSet, thin client, and WeakReferenceCloseableIterator

2022-06-24 Thread Alexander Polovtcev
I would personally prefer the closeable iterator approach, since it is what most Java libraries use and most users should be familiar with it. Also most IDEs will warn you, if you don't close an AutoCloseable. On Fri, Jun 24, 2022 at 6:24 PM Pavel Tupitsyn wrote: > Igniters, > > I'm working on

IgniteSet, thin client, and WeakReferenceCloseableIterator

2022-06-24 Thread Pavel Tupitsyn
Igniters, I'm working on IgniteSet in Java thin client [1], and I'm not sure how to deal with iterator release. On the "thick" API side we use WeakReferenceCloseableIterator [2] to release iterator resources automatically when the iterator instance is claimed by GC. a) Reuse this on the client