PR Reivew https://github.com/apache/ignite/pull/4300

Dear igniters, please help do the code review for jira https://issues.apache.org/jira/browse/IGNITE-8776 https://github.com/apache/ignite/pull/4300 Thanks, kcheng.mvp -- Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/

Re: PR Reivew https://github.com/apache/ignite/pull/4300

Hi, Thanks to Stanislav L. for review. In the same time TC was not re-runned after changes and there is several suspicious failures in PR, so I've retriggered run-all. Let's wait for results and I'll check it one more time. Sincerely, Dmitriy Pavlov вт, 10 июл. 2018 г. в 20:52, kcheng.mvp : > D

Re: PR Reivew https://github.com/apache/ignite/pull/4300

Here is the latest TC result The high-lighted part shows as "no changes", which mean my changes would not cause the failure, right? https://ci.ignite.apache.org/viewLog.html?buildId=1480732&tab=buildResultsDiv&buildTypeId=IgniteTests24Java8_RunAll

Re: PR Reivew https://github.com/apache/ignite/pull/4300

Hi, I've checked this results and I guess branch was created at some unlucky moment, and currently most of timeouts were fixed in master. "No changes" mean Teamcity does not detected changes between runs. Probably I've scheduled re-run for some particular suites more than one time. I'll take a l

Re: PR Reivew https://github.com/apache/ignite/pull/4300

Thank you very much! If it's the case of what you said, a merge from latest main to this branch will fix this issue? Thanks, Ken Cheng On Thu, Jul 12, 2018 at 6:16 PM Dmitry Pavlov wrote: > Hi, > > I've checked this results and I guess branch was created at some unlucky > moment, and currentl

Re: PR Reivew https://github.com/apache/ignite/pull/4300

Hi, Yes, correct. In the same time I've checked branch state with custom tool, so we can be pretty sure change does not introduce new failures. I merged your changes, in the same time I needed to do several updates in code (see details in ticket comments). Looking forward to your contributions!