Re: PR for https://issues.apache.org/jira/browse/IGNITE-8956

2018-07-09 Thread Dmitry Pavlov
Done. Thank you for contribution and for review. пн, 9 июл. 2018 г. в 12:37, Vyacheslav Daradur : > Now changes look good to me. > > Dmitry, could you help with a final review and merge, please? > On Mon, Jul 9, 2018 at 9:30 AM Vyacheslav Daradur > wrote: > > > > Hi, > > > > I've commented your

Re: PR for https://issues.apache.org/jira/browse/IGNITE-8956

2018-07-09 Thread Vyacheslav Daradur
Now changes look good to me. Dmitry, could you help with a final review and merge, please? On Mon, Jul 9, 2018 at 9:30 AM Vyacheslav Daradur wrote: > > Hi, > > I've commented your PR on the GitHub. > > > On Mon, Jul 9, 2018 at 5:21 AM kcheng.mvp wrote: > > > > Dear igniters, > > > > does anyone

Re: PR for https://issues.apache.org/jira/browse/IGNITE-8956

2018-07-08 Thread Vyacheslav Daradur
Hi, I've commented your PR on the GitHub. On Mon, Jul 9, 2018 at 5:21 AM kcheng.mvp wrote: > > Dear igniters, > > does anyone can help do the code review? > > As this ticket is created by myself, I need someone else to help me do the > code review. > > > Thanks, > kcmvp > > > > -- > Sent from:

Re: PR for https://issues.apache.org/jira/browse/IGNITE-8956

2018-07-08 Thread kcheng.mvp
Dear igniters, does anyone can help do the code review? As this ticket is created by myself, I need someone else to help me do the code review. Thanks, kcmvp -- Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/

PR for https://issues.apache.org/jira/browse/IGNITE-8956

2018-07-07 Thread kcheng.mvp
Hi Dmitriy Govorukhin, I have fixed the javadoc error, can you please review the PR? -- Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/