Re: Proposal to remove explicit "GC disable" startup suggestion

2021-05-18 Thread Steshin Vladimir
Ilya, hi. +1 from me. We should not worry about weird user actions. Direct calling of GC looks unusual today. Suggestion of forced disabling manual System.gc() looks useless. 14.05.2021 15:06, Ilya Korol пишет: Hi, everyone. There is a proposal to remove suggestion that user should disable

Re: Proposal to remove explicit "GC disable" startup suggestion

2021-05-17 Thread 18624049226
Does the document also need to be adjusted? https://ignite.apache.org/docs/latest/perf-and-troubleshooting/memory-tuning 在 2021/5/18 上午1:46, Valentin Kulichenko 写道: Got it. The proposal makes sense to me, let's remove the suggestion. -Val On Sun, May 16, 2021 at 5:50 AM Ilya Korol wrote: I

Re: Proposal to remove explicit "GC disable" startup suggestion

2021-05-17 Thread Valentin Kulichenko
Got it. The proposal makes sense to me, let's remove the suggestion. -Val On Sun, May 16, 2021 at 5:50 AM Ilya Korol wrote: > In some circumstances there could be a state when direct buffers > (instantiated for IO purposes) hold too many memory and to get this > memory back JVM calls System.gc(

Re: Proposal to remove explicit "GC disable" startup suggestion

2021-05-16 Thread Ilya Korol
In some circumstances there could be a state when direct buffers (instantiated for IO purposes) hold too many memory and to get this memory back JVM calls System.gc() (as was mentioned earlier by Ivan Daschinsky): ByteBuffer.allocateDirect(capacity)     new DirectButeBuffer(capacity)     B

Re: Proposal to remove explicit "GC disable" startup suggestion

2021-05-15 Thread Ivan Daschinsky
Hi, Val! Please take a look to java.nio.Bits.reserveMemory (jdk8). In this method you can see explicit call of System.gc() вс, 16 мая 2021 г., 01:22 Valentin Kulichenko : > Hi Ilya, > > Out of curiosity - what are the potential problems with memory buffers that > you're referring to? > > -Val > >

Re: Proposal to remove explicit "GC disable" startup suggestion

2021-05-15 Thread Valentin Kulichenko
Hi Ilya, Out of curiosity - what are the potential problems with memory buffers that you're referring to? -Val On Fri, May 14, 2021 at 5:06 AM Ilya Korol wrote: > Hi, everyone. > > There is a proposal to remove suggestion that user should disable > explicit GC calls in https://issues.apache.or

Proposal to remove explicit "GC disable" startup suggestion

2021-05-14 Thread Ilya Korol
Hi, everyone. There is a proposal to remove suggestion that user should disable explicit GC calls in https://issues.apache.org/jira/browse/IGNITE-14720. Nowadays people usually don't use this facility directly without huge need (at least we hope so), so this suggestion doesn't bring much pro