Re: [VOTE] @Nullable/@NotNull annotation usage in Ignite 3

2022-01-20 Thread Alexander Polovtcev
Thanks everybody, the voting has finished. Here are the results: Option 2: 7 votes Option 4: 2 votes Other options: 0 votes Looks like the Option 2 is preferred, I will create a more formal description of it in Confluence as soon as we have the Ignite 3 code style page set up. On Thu, Jan 13, 2

Re: [VOTE] @Nullable/@NotNull annotation usage in Ignite 3

2022-01-13 Thread Valentin Kulichenko
+1 for option 2 On Thu, Jan 13, 2022 at 6:17 AM Anton Vinogradov wrote: > +1 to option 4 > > On Thu, Jan 13, 2022 at 5:15 PM Pavel Tupitsyn > wrote: > > > +1 to option 2 > > > > On Thu, Jan 13, 2022 at 3:52 PM Roman Puchkovskiy < > > roman.puchkovs...@gmail.com> wrote: > > > > > +1 to option 2

Re: [VOTE] @Nullable/@NotNull annotation usage in Ignite 3

2022-01-13 Thread Anton Vinogradov
+1 to option 4 On Thu, Jan 13, 2022 at 5:15 PM Pavel Tupitsyn wrote: > +1 to option 2 > > On Thu, Jan 13, 2022 at 3:52 PM Roman Puchkovskiy < > roman.puchkovs...@gmail.com> wrote: > > > +1 to option 2 > > > > чт, 13 янв. 2022 г. в 15:58, Sergey : > > > > > > +1 for option2 (only @Nullable) > > >

Re: [VOTE] @Nullable/@NotNull annotation usage in Ignite 3

2022-01-13 Thread Pavel Tupitsyn
+1 to option 2 On Thu, Jan 13, 2022 at 3:52 PM Roman Puchkovskiy < roman.puchkovs...@gmail.com> wrote: > +1 to option 2 > > чт, 13 янв. 2022 г. в 15:58, Sergey : > > > > +1 for option2 (only @Nullable) > > > > Best regards, > > Sergey Kosarev. > > > > > > чт, 13 янв. 2022 г. в 13:25, Alexander Po

Re: [VOTE] @Nullable/@NotNull annotation usage in Ignite 3

2022-01-13 Thread Roman Puchkovskiy
+1 to option 2 чт, 13 янв. 2022 г. в 15:58, Sergey : > > +1 for option2 (only @Nullable) > > Best regards, > Sergey Kosarev. > > > чт, 13 янв. 2022 г. в 13:25, Alexander Polovtcev : > > > Dear Igniters, > > > > In this thread > > w

Re: [VOTE] @Nullable/@NotNull annotation usage in Ignite 3

2022-01-13 Thread Sergey
+1 for option2 (only @Nullable) Best regards, Sergey Kosarev. чт, 13 янв. 2022 г. в 13:25, Alexander Polovtcev : > Dear Igniters, > > In this thread > we've > discussed possible approaches to using null-related annotations. As t

Re: [VOTE] @Nullable/@NotNull annotation usage in Ignite 3

2022-01-13 Thread Vladimir Steshin
+1 for option 2 13.01.2022 13:25, Alexander Polovtcev пишет: Dear Igniters, In this thread we've discussed possible approaches to using null-related annotations. As the result, the following approaches were proposed: 1. Use

Re: [VOTE] @Nullable/@NotNull annotation usage in Ignite 3

2022-01-13 Thread Vladislav Pyatkov
I am sure the shorter, the better. +1 to option 4. On Thu, Jan 13, 2022 at 2:06 PM ткаленко кирилл wrote: > +1 to option 2 > -- Vladislav Pyatkov

Re:[VOTE] @Nullable/@NotNull annotation usage in Ignite 3

2022-01-13 Thread ткаленко кирилл
+1 to option 2

Re: [VOTE] @Nullable/@NotNull annotation usage in Ignite 3

2022-01-13 Thread Alexander Polovtcev
+1 to option 2 On Thu, Jan 13, 2022 at 1:25 PM Alexander Polovtcev wrote: > Dear Igniters, > > In this thread > we've > discussed possible approaches to using null-related annotations. As the > result, the following approaches we