Re: Re[2]: [DISCUSSION] MaxLineLength checkstyle rule

2021-05-10 Thread Ivan Pavlukhin
+1 for 140 lines compromise. +1 if someone is ready to fix everything to fit 120. BTW, was there any progress with this? 2021-04-15 21:41 GMT+03:00, Maxim Muzafarov : > Folks, > > I've briefly checked the total amount of the max length violations: > > 120 line length - 5540 violations > 130 line

Re: Re[2]: [DISCUSSION] MaxLineLength checkstyle rule

2021-04-15 Thread Maxim Muzafarov
Folks, I've briefly checked the total amount of the max length violations: 120 line length - 5540 violations 130 line length - 1891 violations 140 line length - 895 violations 150 line length - 478 violations I think the 140 max line length might be the best option for us. On Thu, 15 Apr 2021

Re: Re[2]: [DISCUSSION] MaxLineLength checkstyle rule

2021-04-15 Thread Ivan Daschinsky
But super long lines are a real problem while merging. It is super inconvenient. 120 chars is a good compromise. чт, 15 апр. 2021 г. в 14:39, Zhenya Stanilovsky : > > Python is not so verbose as java ) > +1 for 140 > > >Hi! > >Personally, I suppose that 120 chars per line is OK. Moreover, many >

Re[2]: [DISCUSSION] MaxLineLength checkstyle rule

2021-04-15 Thread Zhenya Stanilovsky
Python is not so verbose as java ) +1 for 140   >Hi! >Personally, I suppose that 120 chars per line is OK. Moreover, many >codestyles suggests less chars per line. >For example PEP8 recommends 80 (but we use 120 in pyignite and flake8 >codestyle checks it). Google java codestyle insists on 100. >