Re: Semaphore blocking on tryAcquire() while holding a cache-lock

2016-04-27 Thread Yakov Zhdanov
Vlad and All! I have reviewed and merged ignite-642 ( https://issues.apache.org/jira/browse/IGNITE-642 Implement IgniteReentrantLock data structure) to master. I will send separate email to user- and dev-list on this. --Yakov 2016-04-27 13:07 GMT+03:00 Yakov Zhdanov : > Vlad, not yet, unfortu

Re: Semaphore blocking on tryAcquire() while holding a cache-lock

2016-04-27 Thread Yakov Zhdanov
Vlad, not yet, unfortunately. I will try to do today. --Yakov 2016-04-27 11:40 GMT+03:00 Vladisav Jelisavcic : > Yakov, > > did you had time to do another review round of ignite-642? > > Thanks! > > On Fri, Apr 15, 2016 at 3:53 PM, Vladisav Jelisavcic > wrote: > > > Yakov, > > > > I've finished

Re: Semaphore blocking on tryAcquire() while holding a cache-lock

2016-04-27 Thread Vladisav Jelisavcic
Yakov, did you had time to do another review round of ignite-642? Thanks! On Fri, Apr 15, 2016 at 3:53 PM, Vladisav Jelisavcic wrote: > Yakov, > > I've finished the initialization tests for ignite-642 (and moved > serialization test from GridCacheLockAbstractTest to > IgniteLockAbstractSelfTes

Re: Semaphore blocking on tryAcquire() while holding a cache-lock

2016-04-15 Thread Vladisav Jelisavcic
Yakov, I've finished the initialization tests for ignite-642 (and moved serialization test from GridCacheLockAbstractTest to IgniteLockAbstractSelfTest). Please check the commit and let me know if you spot anything else. Thanks! On Fri, Apr 15, 2016 at 10:11 AM, Vladisav Jelisavcic wrote: > Yak

Re: Semaphore blocking on tryAcquire() while holding a cache-lock

2016-04-15 Thread Vladisav Jelisavcic
Yakov, I reviewed the changes in ignite-642 and it looks good to me, but I have one question. Can you please look at my comment in ignite-642 ticket? Thanks! Vladisav On Thu, Apr 14, 2016 at 7:51 PM, Vladisav Jelisavcic wrote: > Sure, I'll look into it later today, or tomorrow at the latest >

Re: Semaphore blocking on tryAcquire() while holding a cache-lock

2016-04-14 Thread Vladisav Jelisavcic
Sure, I'll look into it later today, or tomorrow at the latest On Thu, Apr 14, 2016 at 5:53 PM, Yakov Zhdanov wrote: > Vlad, please see my changes in ignite-642 and comment in the ticket. > > Alex, can you please take a look at my latest commit as well and provide > comments? > > --Yakov > > 201

Re: Semaphore blocking on tryAcquire() while holding a cache-lock

2016-04-14 Thread Yakov Zhdanov
Vlad, please see my changes in ignite-642 and comment in the ticket. Alex, can you please take a look at my latest commit as well and provide comments? --Yakov 2016-04-12 23:47 GMT+03:00 Yakov Zhdanov : > Very good points, Alexey. I will look at this tomorrow and finalize the > changes. > > --Y

Re: Semaphore blocking on tryAcquire() while holding a cache-lock

2016-04-12 Thread Yakov Zhdanov
Very good points, Alexey. I will look at this tomorrow and finalize the changes. --Yakov 2016-04-12 23:41 GMT+03:00 Alexey Goncharuk : > Guys, > > I fixed code style a bit and pushed my changes to the branch. > > Couple of questions: > - I see that some of the Errors caught do not get re-thrown

Re: Semaphore blocking on tryAcquire() while holding a cache-lock

2016-04-12 Thread Alexey Goncharuk
Guys, I fixed code style a bit and pushed my changes to the branch. Couple of questions: - I see that some of the Errors caught do not get re-thrown (e.g. if interruptAll flag is set). I believe we should at least re-throw OOME in any case. - readResolve method is missing for CacheLockImpl. The

Re: Semaphore blocking on tryAcquire() while holding a cache-lock

2016-04-12 Thread Yakov Zhdanov
Vlad, I reviewed the code and committed it to ignite-642 branch (after some minor style changes + I added new tests to suites). Alex G & Sam can you please review (see diff with our current master) and provide comments here. I think we are very close to finish with this issue. Thanks for contribu

Re: Semaphore blocking on tryAcquire() while holding a cache-lock

2016-04-11 Thread Yakov Zhdanov
Vlad, I did not have time today. Will review tomorrow. --Yakov 2016-04-08 13:51 GMT+03:00 Yakov Zhdanov : > Very good news, Vlad! I will take a look over weekend or on Monday. > > --Yakov > > 2016-04-08 12:58 GMT+03:00 Vladisav Jelisavcic : > >> Yakov, >> >> sorry for the long delay, I added ano

Re: Semaphore blocking on tryAcquire() while holding a cache-lock

2016-04-08 Thread Yakov Zhdanov
Very good news, Vlad! I will take a look over weekend or on Monday. --Yakov 2016-04-08 12:58 GMT+03:00 Vladisav Jelisavcic : > Yakov, > > sorry for the long delay, I added another commit to the PR, > can you please do the review again? > > Thanks! > Vladisav > > On Sun, Mar 27, 2016 at 11:30 AM,

Re: Semaphore blocking on tryAcquire() while holding a cache-lock

2016-04-08 Thread Vladisav Jelisavcic
Yakov, sorry for the long delay, I added another commit to the PR, can you please do the review again? Thanks! Vladisav On Sun, Mar 27, 2016 at 11:30 AM, Vladisav Jelisavcic wrote: > Yakov, I've seen your comments, can you please check the jira again? > > > On Wed, Mar 23, 2016 at 4:46 PM, Yak

Re: Semaphore blocking on tryAcquire() while holding a cache-lock

2016-03-27 Thread Vladisav Jelisavcic
Yakov, I've seen your comments, can you please check the jira again? On Wed, Mar 23, 2016 at 4:46 PM, Yakov Zhdanov wrote: > Vlad, can you please check my comments again? > > --Yakov > > 2016-03-18 17:57 GMT+03:00 Vladisav Jelisavcic : > > > Hi Yakov, > > > > yes, thanks for the comments, I thi

Re: Semaphore blocking on tryAcquire() while holding a cache-lock

2016-03-23 Thread Yakov Zhdanov
Vlad, can you please check my comments again? --Yakov 2016-03-18 17:57 GMT+03:00 Vladisav Jelisavcic : > Hi Yakov, > > yes, thanks for the comments, I think everything should be ok now, > please review the PR and tell me if you think anything else is needed. > > Once ignite-642 is merged into ma

Re: Semaphore blocking on tryAcquire() while holding a cache-lock

2016-03-19 Thread Yakov Zhdanov
Vlad, did you have a chance to review my latest comments? Thanks! -- Yakov Zhdanov, Director R&D *GridGain Systems* www.gridgain.com 2016-03-06 12:21 GMT+03:00 Yakov Zhdanov : > Vlad and all (esp Val and Anton V.), > > I reviewed the PR. My comments are in the ticket. > > Anton V. there is a que

Re: Semaphore blocking on tryAcquire() while holding a cache-lock

2016-03-18 Thread Dmitriy Setrakyan
On Fri, Mar 18, 2016 at 7:57 AM, Vladisav Jelisavcic wrote: > Hi Yakov, > > yes, thanks for the comments, I think everything should be ok now, > please review the PR and tell me if you think anything else is needed. > > Once ignite-642 is merged into master, > I'll submit a PR for IgniteReadWrite

Re: Semaphore blocking on tryAcquire() while holding a cache-lock

2016-03-18 Thread Vladisav Jelisavcic
Hi Yakov, yes, thanks for the comments, I think everything should be ok now, please review the PR and tell me if you think anything else is needed. Once ignite-642 is merged into master, I'll submit a PR for IgniteReadWriteLock (hopefully on time for 1.6. release). Best regrads, Vladisav On F

Re: Semaphore blocking on tryAcquire() while holding a cache-lock

2016-03-14 Thread Anton Vinogradov
I've populated FAQ https://cwiki.apache.org/confluence/display/IGNITE/FAQ On Fri, Mar 11, 2016 at 9:58 PM, Dmitriy Setrakyan wrote: > On Fri, Mar 11, 2016 at 10:20 AM, Christos Erotocritou < > chris...@gridgain.com> wrote: > > > We already have a basic FAQ page which I am populating: > > http://

Re: Semaphore blocking on tryAcquire() while holding a cache-lock

2016-03-11 Thread Dmitriy Setrakyan
On Fri, Mar 11, 2016 at 10:20 AM, Christos Erotocritou < chris...@gridgain.com> wrote: > We already have a basic FAQ page which I am populating: > http://apacheignite.gridgain.org/docs/faq < > http://apacheignite.gridgain.org/docs/faq> > > Please feel free to add to it. > Thanks Christos! Here is

Re: Semaphore blocking on tryAcquire() while holding a cache-lock

2016-03-11 Thread Christos Erotocritou
Ah, I realise now that this FAQ you are talking about is probably more of a dev one where as the one I’ve created is more product focused. Christos > On 11 Mar 2016, at 18:20, Christos Erotocritou wrote: > > We already have a basic FAQ page which I am populating: > http://apacheignite.gridgai

Re: Semaphore blocking on tryAcquire() while holding a cache-lock

2016-03-11 Thread Christos Erotocritou
We already have a basic FAQ page which I am populating: http://apacheignite.gridgain.org/docs/faq Please feel free to add to it. Not sure if we want to migrate this to the wiki? Christos > On 11 Mar 2016, at 17:35, Dmitriy Setrakyan wrote: > > +1 o

Re: Semaphore blocking on tryAcquire() while holding a cache-lock

2016-03-11 Thread Dmitriy Setrakyan
+1 on FAQ Can we just create a page, and start populating it? D. On Fri, Mar 11, 2016 at 3:25 AM, Anton Vinogradov wrote: > Yakov, > > I've answered. > Seems we have to have special FAQ section at Ignite wiki to publish same > things. > > On Sun, Mar 6, 2016 at 12:21 PM, Yakov Zhdanov > wrote

Re: Semaphore blocking on tryAcquire() while holding a cache-lock

2016-03-11 Thread Anton Vinogradov
Yakov, I've answered. Seems we have to have special FAQ section at Ignite wiki to publish same things. On Sun, Mar 6, 2016 at 12:21 PM, Yakov Zhdanov wrote: > Vlad and all (esp Val and Anton V.), > > I reviewed the PR. My comments are in the ticket. > > Anton V. there is a question regarding op

Re: Semaphore blocking on tryAcquire() while holding a cache-lock

2016-03-06 Thread Yakov Zhdanov
Vlad and all (esp Val and Anton V.), I reviewed the PR. My comments are in the ticket. Anton V. there is a question regarding optimized-classnames.properties. Can you please respond in ticket? --Yakov 2016-02-29 16:00 GMT+06:00 Yakov Zhdanov : > Vlad, that's great! I will take a look this wee

Re: Semaphore blocking on tryAcquire() while holding a cache-lock

2016-02-29 Thread Yakov Zhdanov
Vlad, that's great! I will take a look this week. Reassigning ticket to myself. --Yakov 2016-02-26 18:37 GMT+03:00 Vladisav Jelisavcic : > Hi, > > i recently implemented distributed ReentrantLock - IGNITE-642, > i made a pull request, so hopefully this could be added to the next > release. > > B

Re: Semaphore blocking on tryAcquire() while holding a cache-lock

2016-02-26 Thread Vladisav Jelisavcic
Hi, i recently implemented distributed ReentrantLock - IGNITE-642, i made a pull request, so hopefully this could be added to the next release. Best regards, Vladisav On Thu, Feb 18, 2016 at 10:49 AM, Alexey Goncharuk < alexey.goncha...@gmail.com> wrote: > Folks, > > The current implementation

Re: Semaphore blocking on tryAcquire() while holding a cache-lock

2016-02-18 Thread Alexey Goncharuk
Folks, The current implementation of IgniteCache.lock(key).lock() has the same semantics as the transactional locks - cache topology cannot be changed while there exists an ongoing transaction or an explicit lock is held. The restriction for transactions is quite fundamental, the lock() issue can

Re: Semaphore blocking on tryAcquire() while holding a cache-lock

2016-02-17 Thread Vladimir Ozerov
ngleThreadScheduledExecutor() and schedule a > >> worker to run every n seconds > >> - in the worker, get a semaphore and call IgniteSemaphore#tryAcquire() > >> - do some work and call IgniteSemaphore#release() > >> (except for the cache/lock and semaphore no Ignite API ca