Re: Spark SQL Table Name Resolution

2018-08-18 Thread Dmitriy Pavlov
Hi Stuart, I see review already started and Nikolay responded in GitHub. I've added you to contributors list, so now you can assign issues to yourself. Also, I assigned https://issues.apache.org/jira/browse/IGNITE-9228 issue to you. The issue could be correctly filtered by all committers. I

Re: Spark SQL Table Name Resolution

2018-08-17 Thread Stuart Macdonald
Hi Dmitriy, thanks - that’s done now, Stuart. On 16 Aug 2018, at 22:23, Dmitriy Setrakyan wrote: Stuart, can you please move the ticket into PATCH_AVAILABLE state? You need to click "Submit Patch" button in Jira. D. On Wed, Aug 15, 2018 at 10:22 AM, Stuart Macdonald wrote: > Here's the

Re: Spark SQL Table Name Resolution

2018-08-16 Thread Dmitriy Setrakyan
Stuart, can you please move the ticket into PATCH_AVAILABLE state? You need to click "Submit Patch" button in Jira. D. On Wed, Aug 15, 2018 at 10:22 AM, Stuart Macdonald wrote: > Here's the initial pull request for this issue, please review and let me > know your feedback. I had to combine the

Re: Spark SQL Table Name Resolution

2018-08-15 Thread Stuart Macdonald
Here's the initial pull request for this issue, please review and let me know your feedback. I had to combine the two approaches to enable this to work for both standard .read() where we can add the schema option, and catalog-based selects where we use schemaName.tableName. Happy to discuss on a

Re: Spark SQL Table Name Resolution

2018-08-09 Thread Stuart Macdonald
Hi Nikolay, yes would be happy to - will likely be early next week. I’ll go with the approach of adding a new optional field to the Spark data source provider unless there are any objections. Stuart. > On 9 Aug 2018, at 14:20, Nikolay Izhikov wrote: > > Stuart, do you want to work on this

Re: Spark SQL Table Name Resolution

2018-08-09 Thread Nikolay Izhikov
Stuart, do you want to work on this ticket? В Вт, 07/08/2018 в 11:13 -0700, Stuart Macdonald пишет: > Thanks Val, here’s the ticket: > > https://issues.apache.org/jira/projects/IGNITE/issues/IGNITE-9228 > >

Re: Spark SQL Table Name Resolution

2018-08-07 Thread Stuart Macdonald
Thanks Val, here’s the ticket: https://issues.apache.org/jira/projects/IGNITE/issues/IGNITE-9228 (Thanks for correcting my terminology - I work mostly with the traditional CacheConfiguration interface where

Re: Spark SQL Table Name Resolution

2018-08-07 Thread Valentin Kulichenko
Stuart, Two tables can have same names only if they are located in different schemas. Said that, sdding schema name support makes sense to me for sure. We can implement this using either separate SCHEMA_NAME parameter, or similar to what you suggested in option 3 but with schema name instead of

Spark SQL Table Name Resolution

2018-08-07 Thread Stuart Macdonald
Hello Igniters, The Ignite Spark SQL interface currently takes just “table name” as a parameter which it uses to supply a Spark dataset with data from the underlying Ignite SQL table with that name. To do this it loops through each cache and finds the first one with the given table name [1].