Re: Why does DataStreamer swallow exceptions?

2018-03-22 Thread Ilya Kasnacheev
I have created pull requests for both of tickets. https://github.com/apache/ignite/pull/3651/files please comment if you have strong reservations against this usability fix. Note that it doesn't change timeouted get() behaviour because we can't know in advance how long flush() will take. --

Re: Why does DataStreamer swallow exceptions?

2018-03-15 Thread Ilya Kasnacheev
Hello! I have filed an issue https://issues.apache.org/jira/browse/IGNITE-7962 - going to work on it soon. I have also filed a ticket about usability issue: https://issues.apache.org/jira/browse/IGNITE-7963 Feedback is appreciated. Regards, -- Ilya Kasnacheev 2018-03-14 23:35 GMT+03:00

Re: Why does DataStreamer swallow exceptions?

2018-03-14 Thread Valentin Kulichenko
Ilya, Yes, this is definitely a bug, please create a ticket. -Val On Wed, Mar 14, 2018 at 2:16 AM, Ilya Kasnacheev wrote: > Hello Val! > > No, this does NOT happen. If you collect future, call get() on it later, it > will finish normally despite exceptions in server

Re: Why does DataStreamer swallow exceptions?

2018-03-14 Thread Ilya Kasnacheev
Hello Val! No, this does NOT happen. If you collect future, call get() on it later, it will finish normally despite exceptions in server log and entry not being written. I will do some digging to figure out why this happens exactly. There's also another huge problems with DataStreamer's futures.

Re: Why does DataStreamer swallow exceptions?

2018-03-05 Thread Valentin Kulichenko
Ilya, IgniteDataStreamer#addData method returns future which should be completed with error if one is thrown on server side. Does this happen or not? -Val On Mon, Mar 5, 2018 at 4:10 AM, Nikolay Izhikov wrote: > Hello, Ilya. > > > I think it's time to end this, if that

Re: Why does DataStreamer swallow exceptions?

2018-03-05 Thread Nikolay Izhikov
Hello, Ilya. > I think it's time to end this, if that was the case. DataStreamer should > not be a special case and it should guarantee data safety. WDYT? +1 from me. I'm also facing this issue. Ticket - https://issues.apache.org/jira/browse/IGNITE-7756 Discussion -

Why does DataStreamer swallow exceptions?

2018-03-05 Thread Ilya Kasnacheev
Dear Igniters, why do I have a hunch that DataStreamer would readily swallow exceptions? DataStreamerImpl:1756 swallows marshalling error, lines 1774 & 1781 eat deployment errors. Some people are worried they can fill a leaking vessel without noticing anything off. Also in line 2156 fsync() on