Re: store examples

2015-12-18 Thread Denis Magda
Reviewed, looks good. On 12/18/2015 3:07 AM, Valentin Kulichenko wrote: Can you please review my changes?

Re: store examples

2015-12-17 Thread Dmitriy Setrakyan
ot switch to using H2 disk store? > > > > > > > > > > On Tue, Dec 15, 2015 at 4:11 PM, Valentin Kulichenko < > > > > > valentin.kuliche...@gmail.com> wrote: > > > > > > > > > > > As far as I understand, the issue is

Re: store examples

2015-12-17 Thread Dmitriy Setrakyan
> So, I prefer not to add it back - we have 2 store examples more. > > --Yakov > > 2015-12-17 11:22 GMT+03:00 Dmitriy Setrakyan <dsetrak...@apache.org>: > > > Can we please add this example back? > > > > On Wed, Dec 16, 2015 at 10:45 PM, Valentin Kulichenko

Re: store examples

2015-12-17 Thread Dmitriy Setrakyan
> > > > > I see that connection used in ignite store listener and connection > > (and, > > > > moreover, sometimes 2 connections - in case of update-insert > sequence) > > > used > > > > by jdbc template are different. And each connection gets request

Re: store examples

2015-12-16 Thread Valentin Kulichenko
Valentin Kulichenko < > > > > valentin.kuliche...@gmail.com> wrote: > > > > > > > > > As far as I understand, the issue is that CacheJdbcStoreExample > > > > > and CacheSpringStoreExample use in-memory H2 database, so the cache > > > store > &

Re: store examples

2015-12-16 Thread Yakov Zhdanov
tore > > > > is not shared among nodes. What if we just switch to a file-based DB? > > It > > > > looks like a simple change to me. > > > > > > > > And I would remove CacheDummyStoreExample. It looks weird and doesn't > > > > demonstrate

store examples

2015-12-15 Thread Yakov Zhdanov
https://issues.apache.org/jira/browse/IGNITE-2158 Guys, It seems that CacheDummyStoreExample, CacheJdbcStoreExample and CacheSpringStoreExample do not work correctly in distributed environment after code modifications to demonstrate clear() and withSkipStore() This is an old issue and it is

Re: store examples

2015-12-15 Thread Dmitriy Setrakyan
I think we should fix all the examples. What has changed that makes these examples so difficult to fix? I really do not like removing the examples that have been continuously shipped in every release. If it is so difficult for us to upgrade them to 1.5, how difficult will it be for our users? D.

Re: store examples

2015-12-15 Thread Dmitriy Setrakyan
anything that is not shown in other store examples. > > -Val > > On Tue, Dec 15, 2015 at 2:03 PM, Dmitriy Setrakyan <dsetrak...@apache.org> > wrote: > > > I think we should fix all the examples. What has changed that makes these > > examples so difficult to fix? &g

Re: store examples

2015-12-15 Thread Alexey Kuznetsov
SpringStoreExample use in-memory H2 database, so the cache store > > is not shared among nodes. What if we just switch to a file-based DB? It > > looks like a simple change to me. > > > > And I would remove CacheDummyStoreExample. It looks weird and doesn't > > demonstrate a