Re: Incorrect exception is thrown in async mode when partial update occurs.

2015-07-01 Thread Atri Sharma
Thank you so much! On Wed, Jul 1, 2015 at 7:23 PM, Vladimir Ozerov wrote: > Atri, > > Tests passed. I merged the changes. > > On Wed, Jul 1, 2015 at 1:30 PM, Atri Sharma wrote: > > > Vladimir, > > > > Thanks for review of patch. Are we looking at committing this today, > > please? > > > > Regar

Re: Incorrect exception is thrown in async mode when partial update occurs.

2015-07-01 Thread Vladimir Ozerov
Atri, Tests passed. I merged the changes. On Wed, Jul 1, 2015 at 1:30 PM, Atri Sharma wrote: > Vladimir, > > Thanks for review of patch. Are we looking at committing this today, > please? > > Regards, > > Atri > > On Tue, Jun 30, 2015 at 9:42 PM, Atri Sharma wrote: > > > Hi, > > > > I have upl

Re: Incorrect exception is thrown in async mode when partial update occurs.

2015-07-01 Thread Atri Sharma
Vladimir, Thanks for review of patch. Are we looking at committing this today, please? Regards, Atri On Tue, Jun 30, 2015 at 9:42 PM, Atri Sharma wrote: > Hi, > > I have uploaded patch for this. > > I am not sure about internal flow hence might be missing some part. Please > advice if same. >

Re: Incorrect exception is thrown in async mode when partial update occurs.

2015-06-30 Thread Atri Sharma
Hi, I have uploaded patch for this. I am not sure about internal flow hence might be missing some part. Please advice if same. Please see and let me know your comments and feedback. Regards, Atri On Tue, Jun 30, 2015 at 3:18 PM, Vladimir Ozerov wrote: > Atri, > > I would say that this probl

Re: Incorrect exception is thrown in async mode when partial update occurs.

2015-06-30 Thread Vladimir Ozerov
Atri, I would say that this problem is specific for all calls to IgniteCacheProxy.setFuture() method. It looks like we can create an extension for IgniteFutureImpl class (say, IgniteCacheFutureImpl) which will use CU.convertToCacheException(e) to convert exceptions instead of current U.convertExce

Re: Incorrect exception is thrown in async mode when partial update occurs.

2015-06-30 Thread Atri Sharma
Vladimir, Is this problem specific to all checks of isAsync() calls? On Mon, Jun 29, 2015 at 6:29 PM, Vladimir Ozerov wrote: > Atri, > > Currently allmost all exceptions occurring in Ignite kernal are checked. > And if we want to expose them to users, we convert them to their unchecked > counte

Re: Incorrect exception is thrown in async mode when partial update occurs.

2015-06-29 Thread Atri Sharma
Let me hack this and report On Mon, Jun 29, 2015 at 6:29 PM, Vladimir Ozerov wrote: > Atri, > > Currently allmost all exceptions occurring in Ignite kernal are checked. > And if we want to expose them to users, we convert them to their unchecked > counterparts. The same goes for partial update e

Re: Incorrect exception is thrown in async mode when partial update occurs.

2015-06-29 Thread Vladimir Ozerov
Atri, Currently allmost all exceptions occurring in Ignite kernal are checked. And if we want to expose them to users, we convert them to their unchecked counterparts. The same goes for partial update exception: there is CachePartialUpdateCheckedException which is thrown in Ignite internals, and t

Re: Incorrect exception is thrown in async mode when partial update occurs.

2015-06-29 Thread Atri Sharma
I have taken the patch. Please advice on how to implement this. I will get the patch out today since its critical. On Mon, Jun 29, 2015 at 6:05 PM, Vladimir Ozerov wrote: > Igniters, > > I noted that in async mode we throw IgniteException in case of partial > update, while CachePartialUpdateExc

Incorrect exception is thrown in async mode when partial update occurs.

2015-06-29 Thread Vladimir Ozerov
Igniters, I noted that in async mode we throw IgniteException in case of partial update, while CachePartialUpdateException is expected here accoring to our contract. This appears to be pretty critical as user cannot get failed keys when working in async mode. I created a ticket for that: https://