Re: [E] Re: Apache DataSketches integration

2021-08-27 Thread Alexander Saydakov
I submitted a pull request with some changes I tried to explain here. https://github.com/apache/impala/pull/30 There are still open questions for me regarding: - better dependency mechanism - updating dependency to the latest 3.1.0 - process flow in aggregate functions (avoiding overhead of pairwi

[GitHub] [impala] bartash commented on pull request #30: cleaner and faster operations wtih datasketches

2021-08-27 Thread GitBox
bartash commented on pull request #30: URL: https://github.com/apache/impala/pull/30#issuecomment-907551058 Thank you for your interest in contributing to Impala! We do code review via gerrit rather than GitHub PRs; you can see the process described at https://cwiki.apache.org/confluence/d

[GitHub] [impala] AlexanderSaydakov opened a new pull request #30: cleaner and faster operations wtih datasketches

2021-08-27 Thread GitBox
AlexanderSaydakov opened a new pull request #30: URL: https://github.com/apache/impala/pull/30 I believe these changes should result in cleaner code and more efficient operations with datasketches. I would love to compare performance before and after, but I am not sure how to approach this