[hs2client-CR] Initial structure for the C++ hiveserver2 client.

2016-03-31 Thread Wes McKinney (Code Review)
Wes McKinney has posted comments on this change. Change subject: Initial structure for the C++ hiveserver2 client. .. Patch Set 4: > As mentioned, the implementations of the service, session, operation, and > columar row set

[Toolchain-CR] Build Kudu from source

2016-03-31 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Build Kudu from source .. Patch Set 1: > What do you guys think about just removing the 0.7 stuff > altogether? I mostly kept the 0.7 generator because the

[Toolchain-CR] Build Kudu from source

2016-03-31 Thread Casey Ching (Code Review)
Casey Ching has posted comments on this change. Change subject: Build Kudu from source .. Patch Set 1: > (12 comments) > > I'm with MJ; I can see how the the package reparceling stuff is an > optimization, but it's pretty

[Impala-CR](cdh5-trunk) Remove make_test_tarball.sh

2016-03-31 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: Remove make_test_tarball.sh .. Remove make_test_tarball.sh As far as I know nothing actually uses the "test tarball". For some reason building it

[Impala-CR](cdh5-trunk) PREVIEW ONLY: IMPALA-2737: per-partition processing in agg

2016-03-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#4). Change subject: PREVIEW ONLY: IMPALA-2737: per-partition processing in agg .. PREVIEW ONLY: IMPALA-2737: per-partition processing in agg Separates out evaluation of agg input

[Toolchain-CR] Build Kudu from source

2016-03-31 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Build Kudu from source .. Patch Set 1: (12 comments) I'm with MJ; I can see how the the package reparceling stuff is an optimization, but it's pretty confusing

[Impala-CR] Log EE XUnit test result in IMPALA_HOME/logs/ee_tests/results.

2016-03-31 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: Log EE XUnit test result in IMPALA_HOME/logs/ee_tests/results. .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/2693 To unsubscribe,

[Impala-CR](cdh5-trunk) PREVIEW ONLY: IMPALA-2737: per-partition processing in agg

2016-03-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#3). Change subject: PREVIEW ONLY: IMPALA-2737: per-partition processing in agg .. PREVIEW ONLY: IMPALA-2737: per-partition processing in agg Separates out evaluation of agg input

[Impala-CR](cdh5-trunk) PREVIEW ONLY: IMPALA-2737: per-partition processing in agg

2016-03-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#2). Change subject: PREVIEW ONLY: IMPALA-2737: per-partition processing in agg .. PREVIEW ONLY: IMPALA-2737: per-partition processing in agg Separates out evaluation of agg input

[hs2client-CR] Initial structure for the C++ hiveserver2 client.

2016-03-31 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new patch set (#4). Change subject: Initial structure for the C++ hiveserver2 client. .. Initial structure for the C++ hiveserver2 client. The basic model: clients connect to the

[Impala-CR](cdh5-trunk) IMPALA-2645: Set mechUsing only on success

2016-03-31 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-2645: Set mechUsing only on success .. Patch Set 2: Code-Review+2 Thanks Frantisek! I just wrapped the commit message. I'll submit this now. -- To

[Impala-CR](cdh5-trunk) IMPALA-2645: Set mechUsing only on success

2016-03-31 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#2). Change subject: IMPALA-2645: Set mechUsing only on success .. IMPALA-2645: Set mechUsing only on success Better to check success status from sasl_client_start() before using

[Impala-CR](cdh5-trunk) Upgrade LLVM to 3.8.0

2016-03-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#6). Change subject: Upgrade LLVM to 3.8.0 .. Upgrade LLVM to 3.8.0 This requires various changes for Impala to be fully functional with the new version of LLVM. The original JIT was

[Impala-CR](cdh5-trunk) IMPALA-3274: Always start Kudu for testing

2016-03-31 Thread Casey Ching (Code Review)
Casey Ching has posted comments on this change. Change subject: IMPALA-3274: Always start Kudu for testing .. Patch Set 1: The local file system dataload and tests passed on my desktop. The s3 jenkins job passed. -- To

[Impala-CR](cdh5-trunk) IMPALA-3274: Always start Kudu for testing

2016-03-31 Thread Casey Ching (Code Review)
Casey Ching has uploaded a new change for review. http://gerrit.cloudera.org:8080/2690 Change subject: IMPALA-3274: Always start Kudu for testing .. IMPALA-3274: Always start Kudu for testing Previously Kudu would only be

[Impala-CR](cdh5-trunk) IMPALA-3283: Disable runtime filter tests for local filesystems

2016-03-31 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-3283: Disable runtime filter tests for local filesystems .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/2688 To

[Impala-CR](cdh5-trunk) Allow switching between custom and bootstrapped toolchain

2016-03-31 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: Allow switching between custom and bootstrapped toolchain .. Allow switching between custom and bootstrapped toolchain If SKIP_TOOLCHAIN_BOOTSTRAP

[Impala-CR](cdh5-trunk) IMPALA-2645: Set mechUsing only on success

2016-03-31 Thread Frantisek Dvorak (Code Review)
Frantisek Dvorak has uploaded a new change for review. http://gerrit.cloudera.org:8080/2687 Change subject: IMPALA-2645: Set mechUsing only on success .. IMPALA-2645: Set mechUsing only on success Better to check success

[Impala-CR](cdh5-trunk) IMPALA-2835: introduce PARQUET_FALLBACK_SCHEMA_RESOLUTION query option

2016-03-31 Thread Skye Wanderman-Milne (Code Review)
Hello Matthew Jacobs, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/2384 to look at the new patch set (#11). Change subject: IMPALA-2835: introduce PARQUET_FALLBACK_SCHEMA_RESOLUTION query option

[Impala-CR](cdh5-trunk) Regenerate complextypestbl files to include nested_struct.g field

2016-03-31 Thread Skye Wanderman-Milne (Code Review)
Skye Wanderman-Milne has posted comments on this change. Change subject: Regenerate complextypestbl files to include nested_struct.g field .. Patch Set 3: Good call, it turns out the table definition was slightly wrong. --

[Impala-CR](cdh5-trunk) Remove make_test_tarball.sh

2016-03-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Remove make_test_tarball.sh .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/2685 To unsubscribe, visit

[Impala-CR](cdh5-trunk) Remove make_test_tarball.sh

2016-03-31 Thread Casey Ching (Code Review)
Casey Ching has uploaded a new change for review. http://gerrit.cloudera.org:8080/2685 Change subject: Remove make_test_tarball.sh .. Remove make_test_tarball.sh As far as I know nothing actually uses the "test tarball". For

[Toolchain-CR] Build Kudu from source

2016-03-31 Thread Casey Ching (Code Review)
Casey Ching has posted comments on this change. Change subject: Build Kudu from source .. Patch Set 1: > I see, then that works around the issue of needing "phases" since > Impala always builds after toolchain binaries exist

[Toolchain-CR] Build Kudu from source

2016-03-31 Thread Casey Ching (Code Review)
Casey Ching has posted comments on this change. Change subject: Build Kudu from source .. Patch Set 1: > I see. Then I think we need a plan for the stub, right? We were > going to use the stub with the new GetVersion() call

[Toolchain-CR] Build Kudu from source

2016-03-31 Thread Casey Ching (Code Review)
Casey Ching has posted comments on this change. Change subject: Build Kudu from source .. Patch Set 1: > Are you thinking that we would build from source moving forward or > repackage the parcels for future releases and then

[Impala-CR](cdh5-trunk) IMPALA-2835: introduce PARQUET_FALLBACK_SCHEMA_RESOLUTION query option

2016-03-31 Thread Skye Wanderman-Milne (Code Review)
Hello Matthew Jacobs, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/2384 to look at the new patch set (#10). Change subject: IMPALA-2835: introduce PARQUET_FALLBACK_SCHEMA_RESOLUTION query option

[Impala-CR](cdh5-trunk) IMPALA-2805: Order filters based on selectivity and cost

2016-03-31 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new patch set (#3). Change subject: IMPALA-2805: Order filters based on selectivity and cost .. IMPALA-2805: Order filters based on selectivity and cost Added costs to all Exprs, which

[Impala-CR](cdh5-trunk) IMPALA-2805: Order filters based on selectivity and cost

2016-03-31 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-2805: Order filters based on selectivity and cost .. Patch Set 2: (11 comments)

[Impala-CR](cdh5-trunk) Update another Kudu test to wait for modifying operations

2016-03-31 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: Update another Kudu test to wait for modifying operations .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/2680/1/tests/query_test/test_kudu.py File

[Impala-CR](cdh5-trunk) IMPALA-3194: Allow queries materializing scalar type columns in RC/sequence files

2016-03-31 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3194: Allow queries materializing scalar type columns in RC/sequence files .. Patch Set 10: Code-Review+2 -- To view, visit

[Impala-CR](cdh5-trunk) Update another Kudu test to wait for modifying operations

2016-03-31 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: Update another Kudu test to wait for modifying operations .. Patch Set 1: Code-Review+2 (1 comment)

[Impala-CR](cdh5-trunk) Update another Kudu test to wait for modifying operations

2016-03-31 Thread Casey Ching (Code Review)
Casey Ching has uploaded a new change for review. http://gerrit.cloudera.org:8080/2680 Change subject: Update another Kudu test to wait for modifying operations .. Update another Kudu test to wait for modifying operations I

[Impala-CR](cdh5-trunk) IMPALA-3194: Allow queries materializing scalar type columns in RC/sequence files

2016-03-31 Thread Bharath Vissapragada (Code Review)
Hello Marcel Kornacker, Internal Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/2580 to look at the new patch set (#9). Change subject: IMPALA-3194: Allow queries materializing scalar type columns in RC/sequence files

[Toolchain-CR] Build Kudu from source

2016-03-31 Thread Casey Ching (Code Review)
Casey Ching has uploaded a new change for review. http://gerrit.cloudera.org:8080/2679 Change subject: Build Kudu from source .. Build Kudu from source With this change any arbitrary Kudu hash can be built. Previously only a

[Impala-CR](cdh5-trunk) IMPALA-3194: Allow queries materializing scalar type columns in RC/sequence files

2016-03-31 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-3194: Allow queries materializing scalar type columns in RC/sequence files .. Patch Set 7: (2 comments)

[Impala-CR](cdh5-trunk) IMPALA-3038: Add multistream gzip/bzip2 test coverage

2016-03-31 Thread Juan Yu (Code Review)
Juan Yu has uploaded a new patch set (#10). Change subject: IMPALA-3038: Add multistream gzip/bzip2 test coverage .. IMPALA-3038: Add multistream gzip/bzip2 test coverage Change-Id: I9b0e1971145dd457e71fc9c00ce7c06fff8dea88 ---