Michael Ho has uploaded a new patch set (#2).
Change subject: IMPALA-3350: Add some missing StringVal.is_null checks
..
IMPALA-3350: Add some missing StringVal.is_null checks
This change adds some missing StringVal.is_null check
Michael Ho has posted comments on this change.
Change subject: IMPALA-3350: Add some missing StringVal.is_null checks
..
Patch Set 1:
(3 comments)
StringVal() can be NULL for two reasons (1) its length exceeding 1GB and (2)
m
Internal Jenkins has submitted this change and it was merged.
Change subject: IMPALA-3328: xfail TPC-H q9 if memory limit exceeded
..
IMPALA-3328: xfail TPC-H q9 if memory limit exceeded
The test is flaky due to nondeterministi
Casey Ching has posted comments on this change.
Change subject: PREVIEW IMPALA-2686: Add breakpad crash handler to all daemons
..
Patch Set 5:
(7 comments)
http://gerrit.cloudera.org:8080/#/c/2028/5/be/src/common/global-flags.
Lars Volker has uploaded a new patch set (#6).
Change subject: PREVIEW IMPALA-2686: Add breakpad crash handler to all daemons
..
PREVIEW IMPALA-2686: Add breakpad crash handler to all daemons
This changes add breakpad crash hand
Lars Volker has posted comments on this change.
Change subject: PREVIEW IMPALA-2686: Add breakpad crash handler to all daemons
..
Patch Set 5:
(7 comments)
Thanks for the review. Please see PS6.
http://gerrit.cloudera.org:808
Lars Volker has uploaded a new change for review.
http://gerrit.cloudera.org:8080/2788
Change subject: IMPALA-3327: Disable metric validation for backend clients
..
IMPALA-3327: Disable metric validation for backend clients
A
Lars Volker has uploaded a new patch set (#2).
Change subject: IMPALA-3327: Disable metric validation for backend clients
..
IMPALA-3327: Disable metric validation for backend clients
After decoupling the startup of senders and
Lars Volker has uploaded a new patch set (#3).
Change subject: IMPALA-3327: Disable metric validation for backend clients
..
IMPALA-3327: Disable metric validation for backend clients
After decoupling the startup of senders and
Tim Armstrong has submitted this change and it was merged.
Change subject: Add snappy 1.1.3
..
Add snappy 1.1.3
Change-Id: I75d393f79f9fcad7fb7127e63c538a6799c950e6
---
M buildall.sh
1 file changed, 1 insertion(+), 0 deletions(
Tim Armstrong has posted comments on this change.
Change subject: Add snappy 1.1.3
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/2782
To unsubscribe, visit http://gerrit.cloudera.org:8080/setting
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3334: Fix some bugs in query options' parsing.
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/2776
To unsubscribe, visit
Sailesh Mukil has posted comments on this change.
Change subject: IMPALA-1850 Allow fs.defaultFS to be set to a non-HDFS
filesystem
..
Patch Set 17:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/1121/17/bin/impala-config.sh
Dan Hecht has posted comments on this change.
Change subject: IMPALA-3350: Add some missing StringVal.is_null checks
..
Patch Set 2:
Is there an easy way we could exercise (some of) these paths? Maybe add more
cases to that t
Taras Bobrovytsky has posted comments on this change.
Change subject: IMPALA-3155: Disable implicit casting of CHAR to STRING in CASE
statements
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/2762/1/fe/src/ma
Hello Henry Robinson,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/1121
to look at the new patch set (#18).
Change subject: IMPALA-1850 Allow fs.defaultFS to be set to a non-HDFS
filesystem
...
Michael Brown has posted comments on this change.
Change subject: IMPALA-3329: custom cluster tests: set -max_log_files to
unlimited
..
Patch Set 1:
Bump. CI test failures like those described in IMPALA-3272, IMPALA-3325, and
anujphadke has posted comments on this change.
Change subject: IMPALA-1850 Allow fs.defaultFS to be set to a non-HDFS
filesystem
..
Patch Set 18:
This patch contains the following changes-
1. Skips metadata load on s3 if there
Michael Ho has posted comments on this change.
Change subject: IMPALA-3350: Add some missing StringVal.is_null checks
..
Patch Set 2:
Sure. Will add some more tests to exercise the paths in question.
--
To view, visit http://
Dan Hecht has posted comments on this change.
Change subject: IMPALA-3115: Hoist some variables out of loops in
cross-compiled code.
..
Patch Set 4:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/2661/4/be/src/exec/partitio
Michael Ho has posted comments on this change.
Change subject: IMPALA-3317: fix crash in sorter when spilling zero-length
strings
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/2780/1/testdata/workloads/funct
Juan Yu has posted comments on this change.
Change subject: IMPALA-2076: Correct execution time tracking for
DataStreamSender.
..
Patch Set 3:
(14 comments)
http://gerrit.cloudera.org:8080/#/c/2578/3/be/src/runtime/backend-cl
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3115: Hoist some variables out of loops in
cross-compiled code.
..
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/2661/4/be/src/exec/parti
Juan Yu has uploaded a new patch set (#4).
Change subject: IMPALA-2076: Correct execution time tracking for
DataStreamSender.
..
IMPALA-2076: Correct execution time tracking for DataStreamSender.
DataStreamSender uses multiple
Taras Bobrovytsky has uploaded a new patch set (#3).
Change subject: IMPALA-3270 & IMPALA-3237: Improve handling of unsupported data
types
..
IMPALA-3270 & IMPALA-3237: Improve handling of unsupported data types
This patch intr
Taras Bobrovytsky has abandoned this change.
Change subject: IMPALA-3237: Disallow inserting into tables with unsupported
types
..
Abandoned
I moved these changes to my other patch
--
To view, visit http://gerrit.cloudera.or
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3115: Hoist some variables out of loops in
cross-compiled code.
..
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/2661/4/be/src/exec/parti
Dan Hecht has posted comments on this change.
Change subject: IMPALA-3105: avoid overrunning allocated tuple buffer
..
Patch Set 7: Code-Review+2
(2 comments)
http://gerrit.cloudera.org:8080/#/c/2473/7/be/src/runtime/row-batch
Casey Ching has posted comments on this change.
Change subject: Updates for new Kudu toolchain layout and upgrade Kudu
..
Patch Set 4:
Ping
--
To view, visit http://gerrit.cloudera.org:8080/2720
To unsubscribe, visit http://g
Dan Hecht has posted comments on this change.
Change subject: IMPALA-3334: Fix some bugs in query options' parsing.
..
Patch Set 1: Code-Review+2
Please make sure it gets backported.
--
To view, visit http://gerrit.cloudera.o
Henry Robinson has posted comments on this change.
Change subject: IMPALA-2995: Fix apparent time-travel in timestamp expr-test
..
Patch Set 1:
Looped for another 4.5 hours with no failure in this test. I eventually ran
into I
Michael Ho has posted comments on this change.
Change subject: IMPALA-3115: Hoist some variables out of loops in
cross-compiled code.
..
Patch Set 4:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/2661/4/be/src/exec/partiti
Dan Hecht has posted comments on this change.
Change subject: IMPALA-2995: Fix apparent time-travel in timestamp expr-test
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/2787
To unsubscribe, vi
Casey Ching has posted comments on this change.
Change subject: PREVIEW IMPALA-2686: Add breakpad crash handler to all daemons
..
Patch Set 6:
Looks pretty good to me. If there was some sort of test I'd give it a +1.
--
To vi
Dan Hecht has posted comments on this change.
Change subject: IMPALA-3115: Hoist some variables out of loops in
cross-compiled code.
..
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/2661/4/be/src/exec/partition
Dan Hecht has posted comments on this change.
Change subject: IMPALA-2107: Add Base64 encoder/decoder
..
Patch Set 2:
(5 comments)
could you also test the error paths?
http://gerrit.cloudera.org:8080/#/c/2633/2/be/src/exprs/e
Hello Michael Brown,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/2768
to look at the new patch set (#3).
Change subject: IMPALA-3326: TestShowCreateTable switched to use unique_database
...
Michael Brown has posted comments on this change.
Change subject: IMPALA-3326: TestShowCreateTable switched to use unique_database
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/2768
To unsubsc
Henry Robinson has posted comments on this change.
Change subject: IMPALA-1850 Allow fs.defaultFS to be set to a non-HDFS
filesystem
..
Patch Set 18:
Anuj - please reply to all the comments that the reviewers make (even if it'
Matthew Jacobs has posted comments on this change.
Change subject: Simplify control flow in AnalyticEvalNode::GetNext()
..
Patch Set 3:
+1
--
To view, visit http://gerrit.cloudera.org:8080/2773
To unsubscribe, visit http://ge
Hello Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/2473
to look at the new patch set (#8).
Change subject: IMPALA-3105: avoid overrunning allocated tuple buffer
..
IMPALA-310
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3105: avoid overrunning allocated tuple buffer
..
Patch Set 7:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/2473/7/be/src/runtime/row-batch.h
File be
Hello Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/2473
to look at the new patch set (#9).
Change subject: IMPALA-3105: avoid overrunning allocated tuple buffer
..
IMPALA-310
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3105: avoid overrunning allocated tuple buffer
..
Patch Set 9: Code-Review+2
Carry +2
--
To view, visit http://gerrit.cloudera.org:8080/2473
To unsubscr
Tim Armstrong has uploaded a new patch set (#9).
Change subject: Upgrade LLVM to 3.8.0
..
Upgrade LLVM to 3.8.0
This requires various changes for Impala to be fully functional with the
new version of LLVM.
The original JIT was
Taras Bobrovytsky has uploaded a new change for review.
http://gerrit.cloudera.org:8080/2791
Change subject: Preview: IMPALA-3163: Fix Decimal to Timestamp casting
..
Preview: IMPALA-3163: Fix Decimal to Timestamp casting
Cha
Tim Armstrong has posted comments on this change.
Change subject: Upgrade LLVM to 3.8.0
..
Patch Set 7:
(27 comments)
http://gerrit.cloudera.org:8080/#/c/2486/7/be/CMakeLists.txt
File be/CMakeLists.txt:
Line 307: ${LLVM_SYS
Tim Armstrong has posted comments on this change.
Change subject: Upgrade LLVM to 3.8.0
..
Patch Set 9:
A private exhaustive build passes aside from the ir_udf issue fixed by
http://gerrit.cloudera.org/#/c/2656/
http://sandbo
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-1769: Added hostname to all cgroup failure messages.
..
Patch Set 2:
In addition to what Juan said, I think it's misleading to have the error
messages i
Matthew Jacobs has abandoned this change.
Change subject: IMPALA-1346: Add intra-query/intra-node RM.
..
Abandoned
--
To view, visit http://gerrit.cloudera.org:8080/1113
To unsubscribe, visit http://gerrit.cloudera.org:8080/se
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-1769: Added hostname to all cgroup failure messages.
..
Patch Set 2:
For reference, here's the JIRA tracking the removal of Llama:
https://issues.cloude
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-1346: Add intra-query/intra-node RM.
..
Patch Set 1:
The buffer management work will replace this.
--
To view, visit http://gerrit.cloudera.org:8080/11
Henry Robinson has uploaded a new patch set (#2).
Change subject: IMPALA-3077: Enable runtime filters when PHJ spills
..
IMPALA-3077: Enable runtime filters when PHJ spills
This patch changes when runtime filters are produced in
Henry Robinson has posted comments on this change.
Change subject: IMPALA-3077: Enable runtime filters when PHJ spills
..
Patch Set 1:
(8 comments)
http://gerrit.cloudera.org:8080/#/c/2783/1/be/src/exec/partitioned-hash-join-n
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3077: Enable runtime filters when PHJ spills
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/2783
To unsubscribe, visit h
Alex Behm has posted comments on this change.
Change subject: IMPALA-3155: Disable implicit casting of CHAR to STRING in CASE
statements
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/2762/1/fe/src/main/java/
Tim Armstrong has posted comments on this change.
Change subject: Add TPC-H and TPC-DS
..
Patch Set 5: Code-Review+2
Looks good but I'm not sure on how we're planning to distribute this - could
you maybe write up a short doc o
Casey Ching has posted comments on this change.
Change subject: Add TPC-H and TPC-DS
..
Patch Set 5:
> Looks good but I'm not sure on how we're planning to distribute
> this - could you maybe write up a short doc on the Apache
anujphadke has posted comments on this change.
Change subject: IMPALA-1850 Allow fs.defaultFS to be set to a non-HDFS
filesystem
..
Patch Set 15:
(5 comments)
Changed the hardcoded hdfs:// to DEFAULT_FS and verified that it
anujphadke has posted comments on this change.
Change subject: IMPALA-1850 Allow fs.defaultFS to be set to a non-HDFS
filesystem
..
Patch Set 17:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/1121/17/bin/impala-config.sh
Fi
anujphadke has posted comments on this change.
Change subject: IMPALA-1850 Allow fs.defaultFS to be set to a non-HDFS
filesystem
..
Patch Set 12:
(8 comments)
http://gerrit.cloudera.org:8080/#/c/1121/12/be/src/runtime/exec-en
Jim Apple has uploaded a new patch set (#3).
Change subject: IMPALA-2107: Add Base64 encoder/decoder
..
IMPALA-2107: Add Base64 encoder/decoder
Change-Id: I911451c5d68e8ae9d352abfcf4d5ff36484f0bf3
---
M be/src/exprs/expr-test.cc
Jim Apple has posted comments on this change.
Change subject: IMPALA-2107: Add Base64 encoder/decoder
..
Patch Set 2:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/2633/2/be/src/exprs/expr-test.cc
File be/src/exprs/expr-tes
Michael Ho has posted comments on this change.
Change subject: IMPALA-3350: Add some missing StringVal.is_null checks
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/2786/1/be/src/exprs/aggregate-functions.cc
F
Taras Bobrovytsky has uploaded a new patch set (#2).
Change subject: Preview: IMPALA-3163: Fix Decimal to Timestamp casting
..
Preview: IMPALA-3163: Fix Decimal to Timestamp casting
Change-Id: Iabeea9f4ab4880b2f814408add63c77916
Alex Behm has posted comments on this change.
Change subject: IMPALA-1850 Allow fs.defaultFS to be set to a non-HDFS
filesystem
..
Patch Set 18:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/1121/18/testdata/bin/create-load
Henry Robinson has posted comments on this change.
Change subject: IMPALA-2076: Correct execution time tracking for
DataStreamSender.
..
Patch Set 4:
(11 comments)
Thanks for adding the tests.
http://gerrit.cloudera.org:8080
Tim Armstrong has posted comments on this change.
Change subject: Add TPC-H and TPC-DS
..
Patch Set 5:
Sounds ok to me, I think I misinterpreted what you meant saying it wasn't for
build purposes.
--
To view, visit http://ge
Dan Hecht has posted comments on this change.
Change subject: IMPALA-2107: Add Base64 encoder/decoder
..
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/2633/3/be/src/exprs/string-functions.cc
File be/src/exprs/st
Michael Ho has posted comments on this change.
Change subject: Fix LLVM linker bug
..
Patch Set 3:
(2 comments)
I am not super familiar with the context on why the linker distinguishes
between opaque and non-opaque type to be
Michael Ho has posted comments on this change.
Change subject: Fix LLVM linker bug
..
Patch Set 3: Code-Review+1
Would be great to get the upstream reviews too.
--
To view, visit http://gerrit.cloudera.org:8080/2656
To unsubs
Internal Jenkins has submitted this change and it was merged.
Change subject: IMPALA-2995: Fix apparent time-travel in timestamp expr-test
..
IMPALA-2995: Fix apparent time-travel in timestamp expr-test
The expr test which test
Henry Robinson has posted comments on this change.
Change subject: Source query files from shell.
..
Patch Set 1:
Anyone want to take a look at this?
--
To view, visit http://gerrit.cloudera.org:8080/2663
To unsubscribe, visi
Dan Hecht has posted comments on this change.
Change subject: IMPALA-3077: Enable runtime filters when PHJ spills
..
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/2783/2/be/src/exec/partitioned-hash-join-node.c
Tim Armstrong has posted comments on this change.
Change subject: PREVIEW IMPALA-2686: Add breakpad crash handler to all daemons
..
Patch Set 6:
(4 comments)
Some initial comments.
Also, is there any way we can test this?
It
Tim Armstrong has uploaded a new change for review.
http://gerrit.cloudera.org:8080/2793
Change subject: PREVIEW ONLY: basic perf support and asm dumps for codegened
code
..
PREVIEW ONLY: basic perf support and asm dumps for
Hello Alex Behm,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/2721
to look at the new patch set (#3).
Change subject: IMPALA-3245 / IMPALA-3305: Fix crash with global filters when
NUM_NODES=1
.
Henry Robinson has posted comments on this change.
Change subject: IMPALA-3245 / IMPALA-3305: Fix crash with global filters when
NUM_NODES=1
..
Patch Set 2:
(2 comments)
One more bug-fix needed - computeHasLocalTarget() wasn'
Internal Jenkins has submitted this change and it was merged.
Change subject: IMPALA-3334: Fix some bugs in query options' parsing.
..
IMPALA-3334: Fix some bugs in query options' parsing.
This change fixes two problems:
1. Th
Internal Jenkins has submitted this change and it was merged.
Change subject: IMPALA-3105: avoid overrunning allocated tuple buffer
..
IMPALA-3105: avoid overrunning allocated tuple buffer
This change reworks allocation of tupl
Hello Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/2783
to look at the new patch set (#3).
Change subject: IMPALA-3077: Enable runtime filters when PHJ spills
..
IMPALA-3
Henry Robinson has posted comments on this change.
Change subject: IMPALA-3077: Enable runtime filters when PHJ spills
..
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/2783/2/be/src/exec/partitioned-hash-join-n
Internal Jenkins has submitted this change and it was merged.
Change subject: IMPALA-3326: TestShowCreateTable switched to use unique_database
..
IMPALA-3326: TestShowCreateTable switched to use unique_database
There were two t
Dan Hecht has posted comments on this change.
Change subject: Upgrade LLVM to 3.8.0
..
Patch Set 9:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/2486/9/be/src/codegen/llvm-codegen.h
File be/src/codegen/llvm-codegen.h:
Lin
Dan Hecht has posted comments on this change.
Change subject: IMPALA-3077: Enable runtime filters when PHJ spills
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/2783/2/be/src/exec/partitioned-hash-join-node.cc
Casey Ching has uploaded a new patch set (#3).
Change subject: Simplify creating external Kudu tables and add DROP DATABASE
CASCADE
..
Simplify creating external Kudu tables and add DROP DATABASE CASCADE
Creating an external Ku
Casey Ching has posted comments on this change.
Change subject: Simplify creating external Kudu tables and add DROP DATABASE
CASCADE
..
Patch Set 3:
I ended up merging the drop database cascade fix into this. It was hard to ke
Youwei Wang has posted comments on this change.
Change subject: IMPALA-2459: Implement next_day date/time UDF
..
Patch Set 2:
(11 comments)
http://gerrit.cloudera.org:8080/#/c/1943/2/be/src/exprs/expr-test.cc
File be/src/exprs
Youwei Wang has uploaded a new patch set (#3).
Change subject: IMPALA-2459: Implement next_day date/time UDF
..
IMPALA-2459: Implement next_day date/time UDF
Returns the date of the weekday that follows a particular date.
The we
Juan Yu has posted comments on this change.
Change subject: IMPALA-2076: Correct execution time tracking for
DataStreamSender.
..
Patch Set 4:
(11 comments)
http://gerrit.cloudera.org:8080/#/c/2578/4/be/src/runtime/data-strea
Juan Yu has uploaded a new patch set (#5).
Change subject: IMPALA-2076: Correct execution time tracking for
DataStreamSender.
..
IMPALA-2076: Correct execution time tracking for DataStreamSender.
DataStreamSender uses multiple
Alex Behm has uploaded a new patch set (#2).
Change subject: PREVIEW: Basic column-wise slot materialization in Parquet
scanner.
..
PREVIEW: Basic column-wise slot materialization in Parquet scanner.
This change is a first step
Alex Behm has posted comments on this change.
Change subject: PREVIEW: Basic column-wise slot materialization in Parquet
scanner.
..
Patch Set 1:
(5 comments)
Thanks, Tim!
As discussed in person, let's stick to materializing
93 matches
Mail list logo
