Dan Hecht has posted comments on this change.
Change subject: Strip global constructors and destructors from codegen module
..
Patch Set 5:
Maybe add a comment to that file indicating it's only used by backend tests?
--
To vi
Internal Jenkins has submitted this change and it was merged.
Change subject: IMPALA-1878: Support INSERT and LOAD DATA on S3 and between
filesystems
..
IMPALA-1878: Support INSERT and LOAD DATA on S3 and between filesystems
P
Dan Hecht has posted comments on this change.
Change subject: IMPALA-3462: Fix exec option text for old HJ w/ runtime filters
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/2933
To unsubscribe,
Dan Hecht has posted comments on this change.
Change subject: IMPALA-2686: Add breakpad crash handler to all daemons
..
Patch Set 12:
(12 comments)
http://gerrit.cloudera.org:8080/#/c/2028/12/be/src/common/global-flags.cc
File
Tim Armstrong has posted comments on this change.
Change subject: Strip global constructors and destructors from codegen module
..
Patch Set 4:
It turned out that removing the custom memory manager worked fine for queries
but
Tim Armstrong has posted comments on this change.
Change subject: Strip global constructors and destructors from codegen module
..
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/2910
To unsubscrib
Hello Michael Ho, Internal Jenkins, Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/2910
to look at the new patch set (#5).
Change subject: Strip global constructors and destructors from codegen module
Dan Hecht has posted comments on this change.
Change subject: Enable BOOST_NO_EXCEPTIONS for codegened code
..
Patch Set 4: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/2909/4/be/src/exprs/expr.cc
File be/src/
Dan Hecht has posted comments on this change.
Change subject: IMPALA-1583: Simplify
PartitionedHashJoinNode::ProcessProbeBatch()
..
Patch Set 6: Code-Review+2
(3 comments)
http://gerrit.cloudera.org:8080/#/c/2893/6/be/src/exe
Dan Hecht has posted comments on this change.
Change subject: IMPALA-3286: Software prefetching for hash table build.
..
Patch Set 7:
(9 comments)
Thanks, I think this is simpler. There's more cleanup we can do but we can do
Dan Hecht has posted comments on this change.
Change subject: IMPALA-3344: Simplify sorter and document/enforce invariants.
..
Patch Set 5:
(14 comments)
I had started on this but haven't made it through, but flushing out my c
Alex Behm has uploaded a new patch set (#3).
Change subject: Optimized ReadValueBatch() for Parquet scalar column readers.
..
Optimized ReadValueBatch() for Parquet scalar column readers.
This change builds on top of the recent
Alex Behm has posted comments on this change.
Change subject: Optimized ReadValueBatch() for Parquet scalar column readers.
..
Patch Set 2:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/2843/2/be/src/exec/hdfs-parquet-scann
Internal Jenkins has submitted this change and it was merged.
Change subject: IMPALA-3385: Fix crashes on accessing error_log
..
IMPALA-3385: Fix crashes on accessing error_log
We used to check error_log empty with error_log.em
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3375: Improve TopN performance with a trivial Compare
object.
..
Patch Set 1:
(10 comments)
Looking pretty good, mainly minor comments and curiousity ab
Internal Jenkins has submitted this change and it was merged.
Change subject: IMPALA-3468: fix FindFirstInstance() SSE code to look for '\r'
if necessary
..
IMPALA-3468: fix FindFirstInstance() SSE code to look for '\r' if nece
Henry Robinson has posted comments on this change.
Change subject: IMPALA-3462: Fix exec option text for old HJ w/ runtime filters
..
Patch Set 2: Code-Review+1
Carry Tim's +1.
--
To view, visit http://gerrit.cloudera.org:808
Henry Robinson has posted comments on this change.
Change subject: IMPALA-3462: Fix exec option text for old HJ w/ runtime filters
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/2933/1/be/src/exec/hash-join-no
Hello Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/2933
to look at the new patch set (#2).
Change subject: IMPALA-3462: Fix exec option text for old HJ w/ runtime filters
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-3344: Simplify sorter and document/enforce invariants.
..
Patch Set 5:
Yeah, after I read more of the code I remembered that issue which we've
repeatedl
Casey Ching has posted comments on this change.
Change subject: Preview: Refactor CREATE TABLE grammar rules in prep for
PRIMARY KEY
..
Patch Set 3:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/2865/3/fe/src/main/cup/sql-
Hello Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/2896
to look at the new patch set (#7).
Change subject: IMPALA-3286: Software prefetching for hash table build.
..
IMPA
Hello Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/2896
to look at the new patch set (#6).
Change subject: IMPALA-3286: Software prefetching for hash table build.
..
IMPA
Internal Jenkins has submitted this change and it was merged.
Change subject: Ignore spurious MemPool DCHECK when using --disable_mem_pools
flag
..
Ignore spurious MemPool DCHECK when using --disable_mem_pools flag
This flag m
Alex Behm has posted comments on this change.
Change subject: Preview: Refactor CREATE TABLE grammar rules in prep for
PRIMARY KEY
..
Patch Set 3:
(6 comments)
http://gerrit.cloudera.org:8080/#/c/2865/3/fe/src/main/cup/sql-pa
Michael Ho has posted comments on this change.
Change subject: IMPALA-1583: Simplify
PartitionedHashJoinNode::ProcessProbeBatch()
..
Patch Set 5:
(12 comments)
http://gerrit.cloudera.org:8080/#/c/2893/5/be/src/exec/partitione
Hello Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/2893
to look at the new patch set (#6).
Change subject: IMPALA-1583: Simplify
PartitionedHashJoinNode::ProcessProbeBatch()
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3462: Fix exec option text for old HJ w/ runtime filters
..
Patch Set 1: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/2933/1/be/src/exec
Internal Jenkins has submitted this change and it was merged.
Change subject: IMPALA-2736: Basic column-wise slot materialization in Parquet
scanner.
..
IMPALA-2736: Basic column-wise slot materialization in Parquet scanner.
T
Alex Behm has posted comments on this change.
Change subject: MT: Planner for multi-threaded execution
..
Patch Set 3:
(11 comments)
http://gerrit.cloudera.org:8080/#/c/2846/3/be/src/service/query-options.cc
File be/src/servic
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3344: Simplify sorter and document/enforce invariants.
..
Patch Set 5:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/2826/5/be/src/runtime/sorter.cc
Fi
Michael Ho has posted comments on this change.
Change subject: IMPALA-3286: Software prefetching for hash table build.
..
Patch Set 5:
Patch #5 has been updated to handle lazy evaluation for both build and probe
sides of PHJ.
Henry Robinson has posted comments on this change.
Change subject: IMPALA-2418 Display truncated Details column in profile summary
..
Patch Set 3:
(14 comments)
http://gerrit.cloudera.org:8080/#/c/2930/3//COMMIT_MSG
Commit Mes
Hello Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/2896
to look at the new patch set (#5).
Change subject: IMPALA-3286: Software prefetching for hash table build.
..
IMPA
Henry Robinson has uploaded a new change for review.
http://gerrit.cloudera.org:8080/2933
Change subject: IMPALA-3462: Fix exec option text for old HJ w/ runtime filters
..
IMPALA-3462: Fix exec option text for old HJ w/ runti
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-3344: Simplify sorter and document/enforce invariants.
..
Patch Set 5:
(42 comments)
~phew~ finally got through a first pass
http://gerrit.cloudera.org
Casey Ching has posted comments on this change.
Change subject: IMPALA-2418 Display truncated Details column in profile summary
..
Patch Set 3: Code-Review+1
(1 comment)
It would be great if there was some test for this.
http
Bharath Vissapragada has posted comments on this change.
Change subject: IMPALA-3159: Enable SAN / wildcard certificate support in shell
..
Patch Set 2: Code-Review+1
Thanks Henry. There is already a script tests/util/shell_uti
Skye Wanderman-Milne has posted comments on this change.
Change subject: IMPALA-2548: Codegen Tuple::MaterializeExprs() and use in TopN
node
..
Patch Set 16:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/1901/16/be/src/runt
Hello Marcel Kornacker, Michael Ho, Internal Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/1901
to look at the new patch set (#16).
Change subject: IMPALA-2548: Codegen Tuple::MaterializeExprs() and use in TopN
node
.
Hello Marcel Kornacker, Michael Ho, Internal Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/1901
to look at the new patch set (#15).
Change subject: IMPALA-2548: Codegen Tuple::MaterializeExprs() and use in TopN
node
.
Peter Ebert has uploaded a new patch set (#3).
Change subject: IMPALA-2418 Display truncated Details column in profile summary
..
IMPALA-2418 Display truncated Details column in profile summary
Instead of truncating the profile
Peter Ebert has uploaded a new patch set (#2).
Change subject: IMPALA-2418 Display truncated Details column in profile summary
..
IMPALA-2418 Display truncated Details column in profile summary
Instead of truncating the profile
Hello Marcel Kornacker, Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/2890
to look at the new patch set (#3).
Change subject: IMPALA-3443: Replace BOOST_FOREACH with ranged for()
.
Sailesh Mukil has posted comments on this change.
Change subject: IMPALA-1878: Support INSERT and LOAD DATA on S3 and between
filesystems
..
Patch Set 33: Code-Review+2
Rebase, carry +2.
--
To view, visit http://gerrit.cloud
Sailesh Mukil has posted comments on this change.
Change subject: IMPALA-1878: Support INSERT and LOAD DATA on S3 and between
filesystems
..
Patch Set 31:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/2574/31/fe/src/main/ja
Hello Marcel Kornacker, Michael Brown, Taras Bobrovytsky, Internal Jenkins, Dan
Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/2574
to look at the new patch set (#33).
Change subject: IMPALA-1878: Support INSERT and LOAD DATA on S3 and between
fil
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-3443: Replace BOOST_FOREACH with ranged for()
..
Patch Set 2: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/2890/2/be/src/util/webserv
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-1878: Support INSERT and LOAD DATA on S3 and between
filesystems
..
Patch Set 31:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/2574/31/fe/src/main
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-1878: Support INSERT and LOAD DATA on S3 and between
filesystems
..
Patch Set 32: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/257
Henry Robinson has posted comments on this change.
Change subject: IMPALA-3443: Replace BOOST_FOREACH with ranged for()
..
Patch Set 1:
(16 comments)
http://gerrit.cloudera.org:8080/#/c/2890/1/be/src/codegen/instruction-counte
Hello Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/2890
to look at the new patch set (#2).
Change subject: IMPALA-3443: Replace BOOST_FOREACH with ranged for()
..
IMPALA-
Internal Jenkins has submitted this change and it was merged.
Change subject: IMPALA-3384: add missing frontend -> ext-data-source dependency.
..
IMPALA-3384: add missing frontend -> ext-data-source dependency.
Change-Id: If15f
Hello Marcel Kornacker, Michael Brown, Taras Bobrovytsky, Internal Jenkins, Dan
Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/2574
to look at the new patch set (#32).
Change subject: IMPALA-1878: Support INSERT and LOAD DATA on S3 and between
fil
Sailesh Mukil has posted comments on this change.
Change subject: IMPALA-1878: Support INSERT and LOAD DATA on S3 and between
filesystems
..
Patch Set 31:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/2574/31/fe/src/main/ja
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-1878: Support INSERT and LOAD DATA on S3 and between
filesystems
..
Patch Set 31:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/2574/31/fe/src/main
Henry Robinson has posted comments on this change.
Change subject: IMPALA-3452: S3: Disable Impala staging for INSERTs via flag
for speedup
..
Patch Set 2:
Have you been able to run any perf tests with this change?
--
To vie
Henry Robinson has posted comments on this change.
Change subject: IMPALA-3452: S3: Disable Impala staging for INSERTs via flag
for speedup
..
Patch Set 2:
(6 comments)
http://gerrit.cloudera.org:8080/#/c/2905/2/be/src/exec/h
Thomas Tauber-Marshall has uploaded a new patch set (#10).
Change subject: Initial structure for the C++ hiveserver2 client.
..
Initial structure for the C++ hiveserver2 client.
The basic model: clients connect to the hiveserver
Thomas Tauber-Marshall has posted comments on this change.
Change subject: Initial structure for the C++ hiveserver2 client.
..
Patch Set 9:
(18 comments)
http://gerrit.cloudera.org:8080/#/c/2645/9/.gitignore
File .gitignore:
Dimitris Tsirogiannis has uploaded a new change for review.
http://gerrit.cloudera.org:8080/2932
Change subject: IMPALA-2956: Filters should be able to target multiple scan
nodes
..
IMPALA-2956: Filters should be able to targ
Huaisi Xu has posted comments on this change.
Change subject: IMPALA-3385: Fix crashes on accessing error_log
..
Patch Set 13: Code-Review+2
I rebased aux test, gvm again... carry +2
--
To view, visit http://gerrit.cloudera.o
Tim Armstrong has posted comments on this change.
Change subject: Add option for caller to provide expression buffers for hash
table
..
Patch Set 1:
Yeah I added this plumbing for a different patch that didn't work out, but it
Jim Apple has posted comments on this change.
Change subject: Add option for caller to provide expression buffers for hash
table
..
Patch Set 1:
Is this setting up a performance improvement?
--
To view, visit http://gerrit.c
Henry Robinson has posted comments on this change.
Change subject: IMPALA-3159: Enable SAN / wildcard certificate support in shell
..
Patch Set 1:
(6 comments)
http://gerrit.cloudera.org:8080/#/c/2906/1/be/src/testutil/wildcar
Henry Robinson has uploaded a new patch set (#2).
Change subject: IMPALA-3159: Enable SAN / wildcard certificate support in shell
..
IMPALA-3159: Enable SAN / wildcard certificate support in shell
This patch bumps the Thrift too
Tim Armstrong has posted comments on this change.
Change subject: Strip global constructors and destructors from codegen module
..
Patch Set 4:
It should work fine.
The only case that would be a problem is if it was in a progr
Casey Ching has posted comments on this change.
Change subject: IMPALA-2418 Display truncated Details column in profile summary
..
Patch Set 1:
(4 comments)
Thanks for doing this!
http://gerrit.cloudera.org:8080/#/c/2930/1/be
Tim Armstrong has posted comments on this change.
Change subject: Add ninja support for faster incremental builds
..
Patch Set 3: Code-Review+1
(1 comment)
Carry +1
http://gerrit.cloudera.org:8080/#/c/2923/3/bin/make_impala.s
Tim Armstrong has posted comments on this change.
Change subject: Add ninja support for faster incremental builds
..
Patch Set 4: Code-Review+1
Carry +1
--
To view, visit http://gerrit.cloudera.org:8080/2923
To unsubscribe, v
Hello Casey Ching,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/2923
to look at the new patch set (#4).
Change subject: Add ninja support for faster incremental builds
..
Add ninja supp
Michael Ho has posted comments on this change.
Change subject: Strip global constructors and destructors from codegen module
..
Patch Set 4:
Sorry, based on your reply, I cannot tell if logging in LLVM will still work.
Can you
Tim Armstrong has posted comments on this change.
Change subject: Strip global constructors and destructors from codegen module
..
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/2910
To unsubscrib
Hello Michael Ho, Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/2910
to look at the new patch set (#4).
Change subject: Strip global constructors and destructors from codegen module
..
Tim Armstrong has posted comments on this change.
Change subject: Strip global constructors and destructors from codegen module
..
Patch Set 3:
Yeah I don't think there's any point where the destructors could be
automatically
Thomas Tauber-Marshall has posted comments on this change.
Change subject: IMPALA-2805: Order conjuncts based on selectivity and cost
..
Patch Set 18: Code-Review+2
Carrying Marcel's +2 forward.
--
To view, visit http://gerri
Thomas Tauber-Marshall has posted comments on this change.
Change subject: IMPALA-2805: Order conjuncts based on selectivity and cost
..
Patch Set 17:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/2598/17/fe/src/main/java/c
Hello Marcel Kornacker,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/2598
to look at the new patch set (#18).
Change subject: IMPALA-2805: Order conjuncts based on selectivity and cost
.
Dan Hecht has posted comments on this change.
Change subject: IMPALA-3468: fix FindFirstInstance() SSE code to look for '\r'
if necessary
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/2926
To
Peter Ebert has uploaded a new change for review.
http://gerrit.cloudera.org:8080/2930
Change subject: IMPALA-2418 Display truncated Details column in profile summary
..
IMPALA-2418 Display truncated Details column in profile
Skye Wanderman-Milne has uploaded a new patch set (#2).
Change subject: IMPALA-3468: fix FindFirstInstance() SSE code to look for '\r'
if necessary
..
IMPALA-3468: fix FindFirstInstance() SSE code to look for '\r' if necessary
Skye Wanderman-Milne has posted comments on this change.
Change subject: IMPALA-3468: fix FindFirstInstance() SSE code to look for '\r'
if necessary
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/2926/1/be/sr
Skye Wanderman-Milne has posted comments on this change.
Change subject: IMPALA-3311: fix string data coming out of aggs in subplans
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/2929/1/be/src/exec/partitione
Michael Ho has posted comments on this change.
Change subject: Strip global constructors and destructors from codegen module
..
Patch Set 3: Code-Review+1
Interesting. I thought they were needed for exception. When I looked at
Skye Wanderman-Milne has uploaded a new change for review.
http://gerrit.cloudera.org:8080/2929
Change subject: IMPALA-3311: fix string data coming out of aggs in subplans
..
IMPALA-3311: fix string data coming out of aggs in
Casey Ching has posted comments on this change.
Change subject: Add ninja support for faster incremental builds
..
Patch Set 3: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/2923/3/bin/make_impala.sh
File bin/m
Dan Hecht has posted comments on this change.
Change subject: IMPALA-3385: Fix crashes on accessing error_log
..
Patch Set 13: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/2829
To unsubscribe, visit http://g
Internal Jenkins has submitted this change and it was merged.
Change subject: IMPALA-3458: Fix table creation to test insert with header lines
..
IMPALA-3458: Fix table creation to test insert with header lines
For IMPALA-1740
Dan Hecht has posted comments on this change.
Change subject: IMPALA-3385: Fix crashes on accessing error_log
..
Patch Set 12:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/2829/12/tests/query_test/test_errorlog.py
File test
Dan Hecht has posted comments on this change.
Change subject: IMPALA-3385: Fix crashes on accessing error_log
..
Patch Set 11:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/2829/11/tests/query_test/test_errorlog.py
File test
Dan Hecht has posted comments on this change.
Change subject: IMPALA-3385: Fix crashes on accessing error_log
..
Patch Set 11:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/2829/11/be/src/exec/hdfs-scan-node.cc
File be/src/e
Dan Hecht has posted comments on this change.
Change subject: Strip global constructors and destructors from codegen module
..
Patch Set 3: Code-Review+2
I guess we don't use -ffunction-sections so we wouldn't be able to elimin
Tim Armstrong has uploaded a new patch set (#3).
Change subject: Add ninja support for faster incremental builds
..
Add ninja support for faster incremental builds
Ninja resolves dependencies much faster, so if only a couple of
Huaisi Xu has uploaded a new patch set (#13).
Change subject: IMPALA-3385: Fix crashes on accessing error_log
..
IMPALA-3385: Fix crashes on accessing error_log
We used to check error_log empty with error_log.empty(), but
this m
Huaisi Xu has posted comments on this change.
Change subject: IMPALA-3385: Fix crashes on accessing error_log
..
Patch Set 12:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/2829/12/be/src/util/error-util-test.cc
File be/src
Huaisi Xu has posted comments on this change.
Change subject: IMPALA-3385: Fix crashes on accessing error_log
..
Patch Set 11:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/2829/11/be/src/exec/hdfs-scan-node.cc
File be/src/
Skye Wanderman-Milne has posted comments on this change.
Change subject: Enable BOOST_NO_EXCEPTIONS for codegened code
..
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/2909
To unsubscribe, visit
Skye Wanderman-Milne has posted comments on this change.
Change subject: Enable BOOST_NO_EXCEPTIONS for codegened code
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/2909/2/be/src/exprs/scalar-fn-call.cc
File
Dan Hecht has posted comments on this change.
Change subject: IMPALA-3468: fix FindFirstInstance() SSE code to look for '\r'
if necessary
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/2926/1/be/src/exec/deli
Tim Armstrong has posted comments on this change.
Change subject: Add ninja support for faster incremental builds
..
Patch Set 2:
Martin had an older patch to get this working that was abandonded - I thought
I'd try again. I'v
1 - 100 of 145 matches
Mail list logo
