[Impala-CR](cdh5-trunk) IMPALA-3210: last/first value() support for IGNORE NULLS

2016-06-17 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3210: last/first_value() support for IGNORE NULLS .. Patch Set 2: (14 comments) Thanks! Can you also try building with ASAN [1] and running the tests

[Impala-CR](cdh5-trunk) IMPALA-3575: Add retry to backend connection request and rpc timeout

2016-06-17 Thread Juan Yu (Code Review)
Juan Yu has uploaded a new patch set (#8). Change subject: IMPALA-3575: Add retry to backend connection request and rpc timeout .. IMPALA-3575: Add retry to backend connection request and rpc timeout This patch adds a

[Impala-CR](cdh5-trunk) IMPALA-3754: fix TestParquet.test corrupt rle counts flakiness

2016-06-17 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-3754: fix TestParquet.test_corrupt_rle_counts flakiness .. Patch Set 1: Verified-1 Build failed: http://sandbox.jenkins.cloudera.com/job/mikeb-gvm/23/

[Toolchain-CR] Add Kudu 0.9.0

2016-06-17 Thread Matthew Jacobs (Code Review)
Hello Casey Ching, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3404 to look at the new patch set (#2). Change subject: Add Kudu 0.9.0 .. Add Kudu 0.9.0 Change-Id:

[Toolchain-CR] Add Kudu 0.9.0

2016-06-17 Thread Casey Ching (Code Review)
Casey Ching has posted comments on this change. Change subject: Add Kudu 0.9.0 .. Patch Set 1: Code-Review+2 You should rebase to pull in 1618d. I forgot to push that. That patch removes some build artifacts to clear up

[Toolchain-CR] Kudu: Add 0.9-RC1

2016-06-17 Thread Casey Ching (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3141 to look at the new patch set (#3). Change subject: Kudu: Add 0.9-RC1 .. Kudu: Add 0.9-RC1 Change-Id:

[Toolchain-CR] Kudu: Add 0.9-RC1

2016-06-17 Thread Casey Ching (Code Review)
Casey Ching has submitted this change and it was merged. Change subject: Kudu: Add 0.9-RC1 .. Kudu: Add 0.9-RC1 Change-Id: Ic0ccbd26c2f3c877e1efeb859074a5b4affd9dd7 --- M buildall.sh M source/kudu/build.sh 2 files changed, 16

[Toolchain-CR] Add Kudu 0.9.0

2016-06-17 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: Add Kudu 0.9.0 .. Patch Set 1: Built a local Kudu 0.9.0 Running verify-impala-toolchain-package-build now -- To view, visit

[Toolchain-CR] Add Kudu 0.9.0

2016-06-17 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/3404 Change subject: Add Kudu 0.9.0 .. Add Kudu 0.9.0 Change-Id: I1501b55418acd2a3b4264646a8ce0eb301a1bbe5 --- M buildall.sh 1 file

[Impala-CR](cdh5-trunk) IMPALA-2347: Reuse metastore client connections in Catalog

2016-06-17 Thread Huaisi Xu (Code Review)
Huaisi Xu has posted comments on this change. Change subject: IMPALA-2347: Reuse metastore client connections in Catalog .. Patch Set 4: (1 comment)

[Impala-CR](cdh5-trunk) IMPALA-3711: Check privileges when necessary

2016-06-17 Thread Huaisi Xu (Code Review)
Huaisi Xu has posted comments on this change. Change subject: IMPALA-3711: Check privileges when necessary .. Patch Set 7: I am aware that some comments are outdated.. I will update all comments once you think the code is ok.

[Impala-CR](cdh5-trunk) IMPALA-3711: Check privileges when necessary

2016-06-17 Thread Huaisi Xu (Code Review)
Huaisi Xu has posted comments on this change. Change subject: IMPALA-3711: Check privileges when necessary .. Patch Set 6: (2 comments) sorry for being slow on this.. :)

[Impala-CR](cdh5-trunk) IMPALA-3499: Split catalog update

2016-06-17 Thread Huaisi Xu (Code Review)
Huaisi Xu has posted comments on this change. Change subject: IMPALA-3499: Split catalog update .. Patch Set 25: http://sandbox.jenkins.cloudera.com/view/Impala/view/Private-Utility/job/impala-private-build-and-test/3433/ --

[Impala-CR](cdh5-trunk) IMPALA-3499: Split catalog update

2016-06-17 Thread Huaisi Xu (Code Review)
Huaisi Xu has submitted this change and it was merged. Change subject: IMPALA-3499: Split catalog update .. IMPALA-3499: Split catalog update JNI does not support writing java byte array larger than 2GB. Instead of passing a

[Impala-CR](cdh5-trunk) IMPALA-3499: Split catalog update

2016-06-17 Thread Huaisi Xu (Code Review)
Huaisi Xu has posted comments on this change. Change subject: IMPALA-3499: Split catalog update .. Patch Set 25: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/3067 To unsubscribe, visit

[Impala-CR](cdh5-trunk) IMPALA-3754: fix TestParquet.test corrupt rle counts flakiness

2016-06-17 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3754: fix TestParquet.test_corrupt_rle_counts flakiness .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3402 To unsubscribe,

[Impala-CR](cdh5-trunk) IMPALA-2878: Fix Base64Decode error and remove duplicate codes.

2016-06-17 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-2878: Fix Base64Decode error and remove duplicate codes. .. Patch Set 5: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/3311 To

Re: Investigation of IMPALA-3678

2016-06-17 Thread Dimitris Tsirogiannis
You're more than welcome to submit a patch with your tricks. When Alex or Marcel get back from their PTO, they can go through the code review and see if it is the right solution. Thanks Dimitris On Fri, Jun 17, 2016 at 12:59 AM, Feng, Guangyuan wrote: > Thanks for

[Impala-CR](cdh5-trunk) IMPALA-3637,IMPALA-3636: refactor codegen constant replacement

2016-06-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3637,IMPALA-3636: refactor codegen constant replacement .. Patch Set 4: (1 comment)

[Impala-CR](cdh5-trunk) IMPALA-3637,IMPALA-3636: refactor codegen constant replacement

2016-06-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#4). Change subject: IMPALA-3637,IMPALA-3636: refactor codegen constant replacement .. IMPALA-3637,IMPALA-3636: refactor codegen constant replacement Merge the disparate codegen

[Impala-CR](cdh5-trunk) Use AVX2 operations to speedup Bloom filters by 10-100%.

2016-06-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Use AVX2 operations to speedup Bloom filters by 10-100%. .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/3338/7/be/src/util/bloom-filter.h File

[Impala-CR](cdh5-trunk) Use AVX2 operations to speedup Bloom filters by 10-100%.

2016-06-17 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. Change subject: Use AVX2 operations to speedup Bloom filters by 10-100%. .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/3338/7/be/src/util/bloom-filter.h

[Impala-CR](cdh5-trunk) IMPALA-2347: Reuse metastore client connections in Catalog

2016-06-17 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-2347: Reuse metastore client connections in Catalog .. Patch Set 4: (1 comment)

[Impala-CR](cdh5-trunk) IMPALA-3680: Cleanup the scan range state after failed hdfs cache reads

2016-06-17 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-3680: Cleanup the scan range state after failed hdfs cache reads .. Patch Set 4: Dan, do I need to make any further changes here? Thanks for

[Impala-CR](cdh5-trunk) IMPALA-3687: Prefer Avro field name during schema reconciliation

2016-06-17 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-3687: Prefer Avro field name during schema reconciliation .. Patch Set 6: (1 comment)

[Impala-CR](cdh5-trunk) IMPALA-2347: Reuse metastore client connections in Catalog

2016-06-17 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-2347: Reuse metastore client connections in Catalog .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/3381/3//COMMIT_MSG Commit

RE: Investigation of IMPALA-3678

2016-06-17 Thread Feng, Guangyuan
Thanks for your answering. I'm afraid this simpler case's processing behavior is much different from the mixed SQL with UNION and LEFT JOIN, because it will pass if (!canMigrateConjuncts(inlineViewRef)), but the mixed won't. I must make sure these difference would not impact on too much.