Support new path pattern: 0 or more layers

2022-06-20 Thread guoguan...@qq.com.INVALID
Hi guys! Now IoTDB supports the following path patterns: * (1 asterisk) - one layer ** (2 asterisks) - one or more layers We need to support a new path pattern: 0 or one or more layers, there are some optional schemes: Scheme 1, support it directly with a specific syntax:

Re: Add `pre-commit-hooks` for pre-commit checks

2022-06-20 Thread Eric Pai
Got it! If we use shell script, we should consider both mac/Linux/Windows environment, as we have lots of developers using Windows, coding with powershell is not easy. and the usage of same command may be different in Mac and Linux. If we use Python or Ruby, or any other interpreted programming

Re: Add `pre-commit-hooks` for pre-commit checks

2022-06-20 Thread Ke Lin
Thanks for your advice! After reading the doc of git-hooks , I probably found some solutions: 1. Git-hooks are executable scripts in fact, e.g., shell scripts, ruby or python. So we can define our rules for the linter reports. 2. To reduce

回复: Add `pre-commit-hooks` for pre-commit checks

2022-06-20 Thread Eric Pai
This is a very helpful tool for developers! In IoTDB we have not only code formatter, the spotless, but also the code linter, checkstyle. In maven we can run ‘mvn validate‘ to run checks of both the linter and formatter, or 'mvn validate -pl ' to check one or more particular modules. However,

Add `pre-commit-hooks` for pre-commit checks

2022-06-20 Thread 林地宁宁
Hi guys! AFAIK, we have some style checks in CI/CD. As a novice here, I find it quite annoying to remember the checks before I commit. So how about adding some pre-commit hooks to do these checks for us, such as `mvn spotless:apply`. Though there are some small questions here: 1. Which checks