Re: rename some classes in source codes before releasing

2022-06-25 Thread Jialin Qiao
Hi, Some parameters are changed for consistent iotdb-engine.properties: rpc_address -> rpc_ip iotdb-confignode.properties: target_confignode -> config_nodes Column of Show Cluster and Show Regions: HostAdress -> Host https://github.com/apache/iotdb/pull/6447 Please take a look. Thanks,

Re: Remove the old cluster module from master branch

2022-06-25 Thread HW-Chao Wang
+1 ---Original--- From: "冯 庆新"https://aka.ms/o0ukef; 发件人: Jialin Qiao

Re: Remove the old cluster module from master branch

2022-06-25 Thread 冯 庆新
+1 获取 Outlook for iOS 发件人: Jialin Qiao 发送时间: Sunday, June 26, 2022 9:58:25 AM 收件人: dev@iotdb.apache.org 主题: Re: Remove the old cluster module from master branch +1 ― Jialin Qiao Apache IoTDB PMC Yuan Tian 于2022年6月26日周日

Re: rename some classes in source codes before releasing

2022-06-25 Thread Jialin Qiao
Hi, Here are some could be renamed: server module -> datanode module iotdb-engine.properties -> iotdb-datanode.properties start-new-server.sh -> start-standalone.sh stop-new-server.sh -> stop-standalone.sh Thanks, — Jialin Qiao Apache IoTDB PMC Yuan Tian 于2022年6月26日周日

Re: Remove the old cluster module from master branch

2022-06-25 Thread Jialin Qiao
+1 — Jialin Qiao Apache IoTDB PMC Yuan Tian 于2022年6月26日周日 09:57写道: > Hi, > > +1 > > > Best, > - > Yuan Tian > > On Sun, Jun 26, 2022 at 9:48 AM Haonan Hou > wrote: > > > > Hi, > > > > Since we are going to release the new cluster version 0.14.0-preview in > few

Re: Remove the old cluster module from master branch

2022-06-25 Thread Yuan Tian
Hi, +1 Best, - Yuan Tian On Sun, Jun 26, 2022 at 9:48 AM Haonan Hou wrote: > > Hi, > > Since we are going to release the new cluster version 0.14.0-preview in few > days, > I think we can consider removing the old cluster module before it. > > If we keep the old cluster in

Re: rename some classes in source codes before releasing

2022-06-25 Thread Yuan Tian
Hi, Capitalizing MPP may be better. On Sat, Jun 25, 2022 at 11:58 PM Jialin Qiao wrote: > > Hi, > > I'm renaming the DataBlockManager related, please leave this for me > > dataBlockManagerEndPoint -> mppDataExchangeEndPoint > > Thanks, > — > Jialin Qiao > Apache IoTDB PMC > > >

Remove the old cluster module from master branch

2022-06-25 Thread Haonan Hou
Hi, Since we are going to release the new cluster version 0.14.0-preview in few days, I think we can consider removing the old cluster module before it. If we keep the old cluster in the source code, users who doesn’t familiar the code may confused and may have trouble to understand the

Re: rename some classes in source codes before releasing

2022-06-25 Thread Jialin Qiao
Hi, I'm renaming the DataBlockManager related, please leave this for me dataBlockManagerEndPoint -> mppDataExchangeEndPoint Thanks, — Jialin Qiao Apache IoTDB PMC Xiangdong Huang 于2022年6月25日周六 23:19写道: > Hi, > > When reading the source codes on the master branch, > I noticed

rename some classes in source codes before releasing

2022-06-25 Thread Xiangdong Huang
Hi, When reading the source codes on the master branch, I noticed that some classes and fields names can be renamed for better understanding. Better to rename these names before releasing because I am not sure whether the generated thrift codes are compatible if we modify them later. e.g.,