RE: [DISCUSS] Clean handling of issues in CLIs?

2024-07-15 Thread Stephen Lawrence
> -Original Message- > From: Christofer Dutz > Sent: Monday, July 15, 2024 1:03 PM > To: dev@iotdb.apache.org > Subject: [DISCUSS] Clean handling of issues in CLIs? > > Hi all, > > also while working on the DataNodeServerCli I noticed that we don't > actually handle how CLIs deal with

[DISCUSS] Clean handling of issues in CLIs?

2024-07-15 Thread Christofer Dutz
Hi all, also while working on the DataNodeServerCli I noticed that we don’t actually handle how CLIs deal with issues correctly. While in most case in case of a successful operation we return a code of 0, we don’t consequently do this in case of issues. Sometimes we return -1 or other cases, but

Possible pattern for reducing the negative effects of using singletons and improving testability

2024-07-15 Thread Christofer Dutz
Hi all, I am currently working on some functions and when writing tests for these, I had problems sensibly testing things, as the singletons were preventing that. As I mentioned before … I consider the usage of singletons the probably worst design decision done in IoTDBs core. Even if it simplif