We name this as 'VerticallyConcat' before because its logic is opposite of 'vertical table’. But the thing we forgot is that the target of two operations are different: 1. Vertical table: the target of operation is the table needed to split 2. The discussing operator: the target of operation are the TsBlocks needed to concat
In the view of target, I think this operator should named to ‘HorizontallyConcatOperator’, PlanA. ——— Best, Weihao Li > 2023年2月6日 14:35，Xiangwei Wei <wxw19981...@gmail.com> 写道： > > VerticallyConcatOperator is used to horizontally concatenate TsBlocks with > the same timestamp column. For example, > TsBlock A is: > | Time | ColumnA | > | 1 | 1.0 | > TsBlock B is: > | Time | ColumnB | > | 1 | 2.0 | > After the VerticallyConcatOperator, the result will be: > | Time | ColumnA | ColumnB | > | 1 | 1.0 | 2.0 | > > Literally, I think it's a horizontal concatenation. So I suggest rename it > as HorizontallyConcatOperator. > > However, I asked the author about the reason for this name. He said, "From > the view of a table, adding columns means vertical changes." > > What's your opinion? > > +1 for Plan A: Rename it as HorizontallyConcatOperator. > +1 for Plan B: Keep current name VerticallyConcatOperator. > > -- > Best, > Xiangwei Wei
