Re: [jira] [Created] (IOTDB-229) Inconsistent usage of Marker in TsFile

2019-09-18 Thread Lei Rui
+1, generally the javadoc is not incorrect but can be written more clearly. Lei Rui On 9/19/2019 14:36,Xiangdong Huang wrote: Hi, Ok then just take care when using it. No, I think we need to fix the javadoc. Best, --- Xiangdong Huang School of Software, Tsinghua

Re: [jira] [Created] (IOTDB-229) Inconsistent usage of Marker in TsFile

2019-09-18 Thread Xiangdong Huang
Hi, > Ok then just take care when using it. No, I think we need to fix the javadoc. Best, --- Xiangdong Huang School of Software, Tsinghua University 黄向东 清华大学 软件学院 Lei Rui 于2019年9月19日周四 下午2:31写道: > Hi, > > > > I do not know why the mail does not show the des

Re: [jira] [Created] (IOTDB-229) Inconsistent usage of Marker in TsFile

2019-09-18 Thread Lei Rui
Hi, > I do not know why the mail does not show the description... Sorry it is because I didn't know how to add the detail description when opening an issue on JIRA. Thankfully, I now know how to do that. Below is the raw description: ``` 1) Structure ChunkMetaData.offsetOfChunkHeader refers t

Re: [jira] [Created] (IOTDB-229) Inconsistent usage of Marker in TsFile

2019-09-18 Thread Xiangdong Huang
Hi, I do not know why the mail does not show the description... > As suggested by Jialin Qiao, an ideal case may be that ChunkMetaData.offsetOfChunkHeader refers to the position AFTER Marker_1 too. +1. > A solution is changing the name of the parameter from `markerRead` to `isMarkerExist` The

[jira] [Created] (IOTDB-229) Inconsistent usage of Marker in TsFile

2019-09-18 Thread Lei Rui (Jira)
Lei Rui created IOTDB-229: - Summary: Inconsistent usage of Marker in TsFile Key: IOTDB-229 URL: https://issues.apache.org/jira/browse/IOTDB-229 Project: Apache IoTDB Issue Type: Improvement