Re: Support double quotation in Path and optimize the Path String

2020-08-27 Thread Jialin Qiao
Hi Julian, Here is our discussion: ## Goals 1. let's support double quota on multiply locations of a path (not only the measurement); 2. let's uniform the convert between path and string; 3. maybe we can expose Path object to users in session API. ## Examples ### Session ``` String

Re: Support double quotation in Path and optimize the Path String

2020-08-27 Thread Xiangwei Wei
Hi, Excellent work! Before we mixed String and Path a lot, and have to split or concat string many times. In this PR, we use DetachedPath to replace String and uncertain Path (that we don't know it's a prefixPath or a measurement or others) until we get the full Path from metadata (Mtree). It's

Re: Support double quotation in Path and optimize the Path String

2020-08-27 Thread Julian Feinauer
Ah thanks. If you knowit ist good! Am 27.08.20, 10:34 schrieb "Boris Zhu" : WeChat Group On Thu, Aug 27, 2020 at 4:30 PM Julian Feinauer < j.feina...@pragmaticminds.de> wrote: > Hi Boris, > > excellent initative! > I also had a discussion with @Xiangdong Huang and

Re: Support double quotation in Path and optimize the Path String

2020-08-27 Thread Julian Feinauer
Hi Boris, excellent initative! I also had a discussion with @Xiangdong Huang and @Jialin Qiao about that matter. Does one of you remember where we documented our discussion? Julian Am 27.08.20, 05:44 schrieb "Boris Zhu" : Hi I write a pr about using the detached full path instead of

Support double quotation in Path and optimize the Path String

2020-08-26 Thread Boris Zhu
Hi I write a pr about using the detached full path instead of the full path between SQL analysis and metadata in order to reduce unnecessary path split. A new Class extends Path which is called “PartialPath” which contains the detached full path. BTW, you can use double quotes in name of device.