Coding Implementation doesn't correspond to the design

2020-12-07 Thread Al Wei
When I'm looking through the recovery processing, I find one problem in master branch: An empty file'll have a field "crashed" that is assigned "true" in org.apache.iotdb.tsfile.write.writer.RestorableTsFileIOWriter#RestorableTsFileIOWriter. However, according to the design docs, an empty file w

Re: Coding Implementation doesn't correspond to the design

2020-12-07 Thread Xiangdong Huang
Hi, I checked the codes. There is no bug. But, indeed I think the field name `crashed` is not quite apropos. Best, --- Xiangdong Huang School of Software, Tsinghua University 黄向东 清华大学 软件学院 Al Wei 于2020年12月7日周一 下午5:14写道: > When I'm looking through the recover

Re: [VOTE] Apache IoTDB 0.11.1 RC1 release

2020-12-07 Thread Xiangwei Wei
Hi, +1 from Contributor. I checked the binary distribution in Windows: Download links [ok] Start in Windows, jdk8 [ok] Version number in CLI [ok] Recover from disk [ok] Statements executed successfully: [ok] SET STORAGE GROUP TO root.sg; CREATE TIMESERIES root.sg.d1.s0 WITH DATATYPE=DOUBLE, EN

Re: [VOTE] Apache IoTDB 0.11.1 RC1 release

2020-12-07 Thread Jialin Qiao
Hi, +1 from PMC The source release: incubating in name [ok] apache headers [ok] signatures and hashes [ok] LICENSE and NOTICE [ok] no jar files [ok] could compile from source: ./mvnw.sh clean install [ok] The binary distribution: version number in CLI [ok] signatures and hashes [ok] start in mac

Re: [VOTE] Apache IoTDB 0.11.1 RC1 release

2020-12-07 Thread Haonan Hou
-1 I found a bug in momery control module which calculate the memory size twice when inserting tablet…. Sadly, I think we need to consider RC2 now. Best, Haonan > On Dec 7, 2020, at 1:26 PM, Haonan Hou wrote: > > Hi all, > > Apache IoTDB 0.11.1 is a bug-fix version from 0.11.0. You can ge

[RESULT][VOTE] Apache IoTDB 0.11.1 RC1

2020-12-07 Thread Haonan Hou
Hi all, Since there is a -1 binding vote, the Vote for Apache IoTDB 0.11.1 RC1 closes. As RM I declare the Vote nonetheless as NOT PASSED and suggest to prepare a RC2. It is not unusual for an RC to be cancelled, in fact this is a regular process (therefore we have RCs before releases). I have

Re: [RESULT][VOTE] Apache IoTDB 0.11.1 RC1

2020-12-07 Thread Haonan Hou
Sorry, I double checked the the rel/0.11 branch again and I didn’t see the bug in this branch, Please ignore the previous email. Haonan > On Dec 8, 2020, at 1:44 PM, Haonan Hou wrote: > > Hi all, > > Since there is a -1 binding vote, the Vote for Apache IoTDB 0.11.1 RC1 closes. > > > As RM

Re: [VOTE] Apache IoTDB 0.11.1 RC1 release

2020-12-07 Thread Haonan Hou
Please ignore the previous -1 vote. That is a mistake… Haonan > On Dec 8, 2020, at 1:26 PM, Haonan Hou wrote: > > -1 > > I found a bug in momery control module which calculate the memory size twice > when inserting tablet…. > > Sadly, I think we need to consider RC2 now. > > Best, > Haonan

Re: [VOTE] Apache IoTDB 0.11.1 RC1 release

2020-12-07 Thread Justin Mclean
Hi, > Please ignore the previous -1 vote. That is a mistake… It’s fine to change you vote (unlikely elections). Vote early and vote often! Thanks, Justin